* [PATCH -next] apparmor: Fix some kernel-doc comments
@ 2022-07-18 6:30 Yang Li
2022-07-20 2:28 ` John Johansen
0 siblings, 1 reply; 11+ messages in thread
From: Yang Li @ 2022-07-18 6:30 UTC (permalink / raw)
To: john.johansen
Cc: paul, jmorris, serge, apparmor, linux-security-module,
linux-kernel, Yang Li, Abaci Robot
Remove warnings found by running scripts/kernel-doc, which is caused by
using 'make W=1'.
security/apparmor/policy_ns.c:65: warning: Function parameter or member 'curr' not described in 'aa_ns_name'
security/apparmor/policy_ns.c:65: warning: Function parameter or member 'view' not described in 'aa_ns_name'
security/apparmor/policy_ns.c:65: warning: Function parameter or member 'subns' not described in 'aa_ns_name'
security/apparmor/policy_ns.c:65: warning: expecting prototype for aa_na_name(). Prototype was for aa_ns_name() instead
security/apparmor/policy_ns.c:214: warning: Function parameter or member 'view' not described in '__aa_lookupn_ns'
security/apparmor/policy_ns.c:214: warning: Excess function parameter 'base' description in '__aa_lookupn_ns'
security/apparmor/policy_ns.c:297: warning: expecting prototype for aa_create_ns(). Prototype was for __aa_find_or_create_ns() instead
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
security/apparmor/policy_ns.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
index 300953a02a24..0ef268d6554d 100644
--- a/security/apparmor/policy_ns.c
+++ b/security/apparmor/policy_ns.c
@@ -54,10 +54,10 @@ bool aa_ns_visible(struct aa_ns *curr, struct aa_ns *view, bool subns)
}
/**
- * aa_na_name - Find the ns name to display for @view from @curr
- * @curr - current namespace (NOT NULL)
- * @view - namespace attempting to view (NOT NULL)
- * @subns - are subns visible
+ * aa_ns_name - Find the ns name to display for @view from @curr
+ * @curr: current namespace (NOT NULL)
+ * @view: namespace attempting to view (NOT NULL)
+ * @subns: are subns visible
*
* Returns: name of @view visible from @curr
*/
@@ -200,7 +200,7 @@ struct aa_ns *aa_find_ns(struct aa_ns *root, const char *name)
/**
* __aa_lookupn_ns - lookup the namespace matching @hname
- * @base: base list to start looking up profile name from (NOT NULL)
+ * @view: namespace to search in (NOT NULL)
* @hname: hierarchical ns name (NOT NULL)
* @n: length of @hname
*
@@ -285,7 +285,7 @@ static struct aa_ns *__aa_create_ns(struct aa_ns *parent, const char *name,
}
/**
- * aa_create_ns - create an ns, fail if it already exists
+ * __aa_find_or_create_ns - create an ns, fail if it already exists
* @parent: the parent of the namespace being created
* @name: the name of the namespace
* @dir: if not null the dir to put the ns entries in
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH -next] apparmor: Fix some kernel-doc comments
2022-07-18 6:30 [PATCH -next] apparmor: Fix some kernel-doc comments Yang Li
@ 2022-07-20 2:28 ` John Johansen
0 siblings, 0 replies; 11+ messages in thread
From: John Johansen @ 2022-07-20 2:28 UTC (permalink / raw)
To: Yang Li
Cc: paul, jmorris, serge, apparmor, linux-security-module,
linux-kernel, Abaci Robot
On 7/17/22 23:30, Yang Li wrote:
> Remove warnings found by running scripts/kernel-doc, which is caused by
> using 'make W=1'.
> security/apparmor/policy_ns.c:65: warning: Function parameter or member 'curr' not described in 'aa_ns_name'
> security/apparmor/policy_ns.c:65: warning: Function parameter or member 'view' not described in 'aa_ns_name'
> security/apparmor/policy_ns.c:65: warning: Function parameter or member 'subns' not described in 'aa_ns_name'
> security/apparmor/policy_ns.c:65: warning: expecting prototype for aa_na_name(). Prototype was for aa_ns_name() instead
> security/apparmor/policy_ns.c:214: warning: Function parameter or member 'view' not described in '__aa_lookupn_ns'
> security/apparmor/policy_ns.c:214: warning: Excess function parameter 'base' description in '__aa_lookupn_ns'
> security/apparmor/policy_ns.c:297: warning: expecting prototype for aa_create_ns(). Prototype was for __aa_find_or_create_ns() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
thanks I have pulled this into apparmor-next
Acked-by: John Johansen <john.johansen@canonical.com>
> ---
> security/apparmor/policy_ns.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
> index 300953a02a24..0ef268d6554d 100644
> --- a/security/apparmor/policy_ns.c
> +++ b/security/apparmor/policy_ns.c
> @@ -54,10 +54,10 @@ bool aa_ns_visible(struct aa_ns *curr, struct aa_ns *view, bool subns)
> }
>
> /**
> - * aa_na_name - Find the ns name to display for @view from @curr
> - * @curr - current namespace (NOT NULL)
> - * @view - namespace attempting to view (NOT NULL)
> - * @subns - are subns visible
> + * aa_ns_name - Find the ns name to display for @view from @curr
> + * @curr: current namespace (NOT NULL)
> + * @view: namespace attempting to view (NOT NULL)
> + * @subns: are subns visible
> *
> * Returns: name of @view visible from @curr
> */
> @@ -200,7 +200,7 @@ struct aa_ns *aa_find_ns(struct aa_ns *root, const char *name)
>
> /**
> * __aa_lookupn_ns - lookup the namespace matching @hname
> - * @base: base list to start looking up profile name from (NOT NULL)
> + * @view: namespace to search in (NOT NULL)
> * @hname: hierarchical ns name (NOT NULL)
> * @n: length of @hname
> *
> @@ -285,7 +285,7 @@ static struct aa_ns *__aa_create_ns(struct aa_ns *parent, const char *name,
> }
>
> /**
> - * aa_create_ns - create an ns, fail if it already exists
> + * __aa_find_or_create_ns - create an ns, fail if it already exists
> * @parent: the parent of the namespace being created
> * @name: the name of the namespace
> * @dir: if not null the dir to put the ns entries in
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH -next] apparmor: Fix some kernel-doc comments
2023-10-23 0:55 Yang Li
@ 2023-11-19 9:08 ` John Johansen
0 siblings, 0 replies; 11+ messages in thread
From: John Johansen @ 2023-11-19 9:08 UTC (permalink / raw)
To: Yang Li, paul, jmorris, serge
Cc: apparmor, linux-security-module, linux-kernel, Abaci Robot
On 10/22/23 17:55, Yang Li wrote:
> Fix some kernel-doc comments to silence the warnings:
> security/apparmor/capability.c:66: warning: Function parameter or member 'ad' not described in 'audit_caps'
> security/apparmor/capability.c:66: warning: Excess function parameter 'as' description in 'audit_caps'
> security/apparmor/capability.c:154: warning: Function parameter or member 'subj_cred' not described in 'aa_capable'
> security/apparmor/capability.c:154: warning: Excess function parameter 'subj_cread' description in 'aa_capable'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7035
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
sorry I missed replying to this. It was pulled into apparmor-next and merged upstream during the 6.7 merge window
> ---
> security/apparmor/capability.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/apparmor/capability.c b/security/apparmor/capability.c
> index 0b7d2b1086c9..9934df16c843 100644
> --- a/security/apparmor/capability.c
> +++ b/security/apparmor/capability.c
> @@ -51,7 +51,7 @@ static void audit_cb(struct audit_buffer *ab, void *va)
>
> /**
> * audit_caps - audit a capability
> - * @as: audit data
> + * @ad: audit data
> * @profile: profile being tested for confinement (NOT NULL)
> * @cap: capability tested
> * @error: error code returned by test
> @@ -140,7 +140,7 @@ static int profile_capable(struct aa_profile *profile, int cap,
>
> /**
> * aa_capable - test permission to use capability
> - * @subj_cread: cred we are testing capability against
> + * @subj_cred: cred we are testing capability against
> * @label: label being tested for capability (NOT NULL)
> * @cap: capability to be tested
> * @opts: CAP_OPT_NOAUDIT bit determines whether audit record is generated
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH -next] apparmor: Fix some kernel-doc comments
@ 2023-10-23 0:55 Yang Li
2023-11-19 9:08 ` John Johansen
0 siblings, 1 reply; 11+ messages in thread
From: Yang Li @ 2023-10-23 0:55 UTC (permalink / raw)
To: john.johansen, paul, jmorris, serge
Cc: apparmor, linux-security-module, linux-kernel, Yang Li, Abaci Robot
Fix some kernel-doc comments to silence the warnings:
security/apparmor/capability.c:66: warning: Function parameter or member 'ad' not described in 'audit_caps'
security/apparmor/capability.c:66: warning: Excess function parameter 'as' description in 'audit_caps'
security/apparmor/capability.c:154: warning: Function parameter or member 'subj_cred' not described in 'aa_capable'
security/apparmor/capability.c:154: warning: Excess function parameter 'subj_cread' description in 'aa_capable'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7035
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
security/apparmor/capability.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/apparmor/capability.c b/security/apparmor/capability.c
index 0b7d2b1086c9..9934df16c843 100644
--- a/security/apparmor/capability.c
+++ b/security/apparmor/capability.c
@@ -51,7 +51,7 @@ static void audit_cb(struct audit_buffer *ab, void *va)
/**
* audit_caps - audit a capability
- * @as: audit data
+ * @ad: audit data
* @profile: profile being tested for confinement (NOT NULL)
* @cap: capability tested
* @error: error code returned by test
@@ -140,7 +140,7 @@ static int profile_capable(struct aa_profile *profile, int cap,
/**
* aa_capable - test permission to use capability
- * @subj_cread: cred we are testing capability against
+ * @subj_cred: cred we are testing capability against
* @label: label being tested for capability (NOT NULL)
* @cap: capability to be tested
* @opts: CAP_OPT_NOAUDIT bit determines whether audit record is generated
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH -next] apparmor: Fix some kernel-doc comments
2023-07-07 8:07 Yang Li
2023-07-07 14:55 ` Randy Dunlap
@ 2023-07-10 8:48 ` John Johansen
1 sibling, 0 replies; 11+ messages in thread
From: John Johansen @ 2023-07-10 8:48 UTC (permalink / raw)
To: Yang Li
Cc: paul, jmorris, serge, apparmor, linux-security-module, linux-kernel
On 7/7/23 01:07, Yang Li wrote:
> Use colons to separate parameter names from their specific meanings.
> silencethe warnings:
>
Unfortunately Gaosheng Cui beat you to this fix on 6/24 with
[PATCH -next 08/11] apparmor: Fix kernel-doc warnings in apparmor/resource.c
thankyou for taking the time to help make apparmor better
-
john
> security/apparmor/resource.c:111: warning: Function parameter or member 'label' not described in 'aa_task_setrlimit'
> security/apparmor/resource.c:111: warning: Function parameter or member 'task' not described in 'aa_task_setrlimit'
> security/apparmor/resource.c:111: warning: Function parameter or member 'resource' not described in 'aa_task_setrlimit'
> security/apparmor/resource.c:111: warning: Function parameter or member 'new_rlim' not described in 'aa_task_setrlimit'
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> security/apparmor/resource.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/security/apparmor/resource.c b/security/apparmor/resource.c
> index e85948164896..2bebc5d9e741 100644
> --- a/security/apparmor/resource.c
> +++ b/security/apparmor/resource.c
> @@ -97,10 +97,10 @@ static int profile_setrlimit(struct aa_profile *profile, unsigned int resource,
>
> /**
> * aa_task_setrlimit - test permission to set an rlimit
> - * @label - label confining the task (NOT NULL)
> - * @task - task the resource is being set on
> - * @resource - the resource being set
> - * @new_rlim - the new resource limit (NOT NULL)
> + * @label: label confining the task (NOT NULL)
> + * @task: task the resource is being set on
> + * @resource: the resource being set
> + * @new_rlim: the new resource limit (NOT NULL)
> *
> * Control raising the processes hard limit.
> *
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH -next] apparmor: Fix some kernel-doc comments
2023-07-07 8:07 Yang Li
@ 2023-07-07 14:55 ` Randy Dunlap
2023-07-10 8:48 ` John Johansen
1 sibling, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2023-07-07 14:55 UTC (permalink / raw)
To: Yang Li, john.johansen
Cc: paul, jmorris, serge, apparmor, linux-security-module, linux-kernel
On 7/7/23 01:07, Yang Li wrote:
> Use colons to separate parameter names from their specific meanings.
> silencethe warnings:
>
> security/apparmor/resource.c:111: warning: Function parameter or member 'label' not described in 'aa_task_setrlimit'
> security/apparmor/resource.c:111: warning: Function parameter or member 'task' not described in 'aa_task_setrlimit'
> security/apparmor/resource.c:111: warning: Function parameter or member 'resource' not described in 'aa_task_setrlimit'
> security/apparmor/resource.c:111: warning: Function parameter or member 'new_rlim' not described in 'aa_task_setrlimit'
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> security/apparmor/resource.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/security/apparmor/resource.c b/security/apparmor/resource.c
> index e85948164896..2bebc5d9e741 100644
> --- a/security/apparmor/resource.c
> +++ b/security/apparmor/resource.c
> @@ -97,10 +97,10 @@ static int profile_setrlimit(struct aa_profile *profile, unsigned int resource,
>
> /**
> * aa_task_setrlimit - test permission to set an rlimit
> - * @label - label confining the task (NOT NULL)
> - * @task - task the resource is being set on
> - * @resource - the resource being set
> - * @new_rlim - the new resource limit (NOT NULL)
> + * @label: label confining the task (NOT NULL)
> + * @task: task the resource is being set on
> + * @resource: the resource being set
> + * @new_rlim: the new resource limit (NOT NULL)
> *
> * Control raising the processes hard limit.
> *
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH -next] apparmor: Fix some kernel-doc comments
@ 2023-07-07 8:07 Yang Li
2023-07-07 14:55 ` Randy Dunlap
2023-07-10 8:48 ` John Johansen
0 siblings, 2 replies; 11+ messages in thread
From: Yang Li @ 2023-07-07 8:07 UTC (permalink / raw)
To: john.johansen
Cc: paul, jmorris, serge, apparmor, linux-security-module,
linux-kernel, Yang Li
Use colons to separate parameter names from their specific meanings.
silencethe warnings:
security/apparmor/resource.c:111: warning: Function parameter or member 'label' not described in 'aa_task_setrlimit'
security/apparmor/resource.c:111: warning: Function parameter or member 'task' not described in 'aa_task_setrlimit'
security/apparmor/resource.c:111: warning: Function parameter or member 'resource' not described in 'aa_task_setrlimit'
security/apparmor/resource.c:111: warning: Function parameter or member 'new_rlim' not described in 'aa_task_setrlimit'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
security/apparmor/resource.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/security/apparmor/resource.c b/security/apparmor/resource.c
index e85948164896..2bebc5d9e741 100644
--- a/security/apparmor/resource.c
+++ b/security/apparmor/resource.c
@@ -97,10 +97,10 @@ static int profile_setrlimit(struct aa_profile *profile, unsigned int resource,
/**
* aa_task_setrlimit - test permission to set an rlimit
- * @label - label confining the task (NOT NULL)
- * @task - task the resource is being set on
- * @resource - the resource being set
- * @new_rlim - the new resource limit (NOT NULL)
+ * @label: label confining the task (NOT NULL)
+ * @task: task the resource is being set on
+ * @resource: the resource being set
+ * @new_rlim: the new resource limit (NOT NULL)
*
* Control raising the processes hard limit.
*
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH -next] AppArmor: Fix some kernel-doc comments
2023-03-03 1:28 [PATCH -next] AppArmor: " Yang Li
@ 2023-04-09 22:19 ` John Johansen
0 siblings, 0 replies; 11+ messages in thread
From: John Johansen @ 2023-04-09 22:19 UTC (permalink / raw)
To: Yang Li
Cc: paul, jmorris, serge, apparmor, linux-security-module,
linux-kernel, Abaci Robot
On 3/2/23 17:28, Yang Li wrote:
> Make the description of @table to @strs in function unpack_trans_table()
> to silence the warnings:
>
> security/apparmor/policy_unpack.c:456: warning: Function parameter or member 'strs' not described in 'unpack_trans_table'
> security/apparmor/policy_unpack.c:456: warning: Excess function parameter 'table' description in 'unpack_trans_table'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4332
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: John Johansen <john.johansen@canonical.com>
I have pulled this into the apparmor tree thanks
> ---
> security/apparmor/policy_unpack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
> index cf2ceec40b28..c3f44f1deb07 100644
> --- a/security/apparmor/policy_unpack.c
> +++ b/security/apparmor/policy_unpack.c
> @@ -448,7 +448,7 @@ static struct aa_dfa *unpack_dfa(struct aa_ext *e, int flags)
> /**
> * unpack_trans_table - unpack a profile transition table
> * @e: serialized data extent information (NOT NULL)
> - * @table: str table to unpack to (NOT NULL)
> + * @strs: str table to unpack to (NOT NULL)
> *
> * Returns: true if table successfully unpacked or not present
> */
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH -next] AppArmor: Fix some kernel-doc comments
@ 2023-03-03 1:28 Yang Li
2023-04-09 22:19 ` John Johansen
0 siblings, 1 reply; 11+ messages in thread
From: Yang Li @ 2023-03-03 1:28 UTC (permalink / raw)
To: john.johansen
Cc: paul, jmorris, serge, apparmor, linux-security-module,
linux-kernel, Yang Li, Abaci Robot
Make the description of @table to @strs in function unpack_trans_table()
to silence the warnings:
security/apparmor/policy_unpack.c:456: warning: Function parameter or member 'strs' not described in 'unpack_trans_table'
security/apparmor/policy_unpack.c:456: warning: Excess function parameter 'table' description in 'unpack_trans_table'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4332
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
security/apparmor/policy_unpack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
index cf2ceec40b28..c3f44f1deb07 100644
--- a/security/apparmor/policy_unpack.c
+++ b/security/apparmor/policy_unpack.c
@@ -448,7 +448,7 @@ static struct aa_dfa *unpack_dfa(struct aa_ext *e, int flags)
/**
* unpack_trans_table - unpack a profile transition table
* @e: serialized data extent information (NOT NULL)
- * @table: str table to unpack to (NOT NULL)
+ * @strs: str table to unpack to (NOT NULL)
*
* Returns: true if table successfully unpacked or not present
*/
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH -next] apparmor: Fix some kernel-doc comments
2022-03-17 1:03 [PATCH -next] apparmor: " Yang Li
@ 2022-03-21 20:20 ` John Johansen
0 siblings, 0 replies; 11+ messages in thread
From: John Johansen @ 2022-03-21 20:20 UTC (permalink / raw)
To: Yang Li
Cc: jmorris, serge, apparmor, linux-security-module, linux-kernel,
Abaci Robot
On 3/16/22 18:03, Yang Li wrote:
> Remove some warnings found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
>
> security/apparmor/domain.c:137: warning: Function parameter or member
> 'state' not described in 'label_compound_match'
> security/apparmor/domain.c:137: warning: Excess function parameter
> 'start' description in 'label_compound_match'
> security/apparmor/domain.c:1294: warning: Excess function parameter
> 'onexec' description in 'aa_change_profile'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: John Johansen <john.johansen@canonical.com>
I have pulled this into my tree
> ---
> security/apparmor/domain.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
> index a29e69d2c300..d71023f5c9c4 100644
> --- a/security/apparmor/domain.c
> +++ b/security/apparmor/domain.c
> @@ -119,7 +119,7 @@ static inline unsigned int match_component(struct aa_profile *profile,
> * @profile: profile to find perms for
> * @label: label to check access permissions for
> * @stack: whether this is a stacking request
> - * @start: state to start match in
> + * @state: state to start match in
> * @subns: whether to do permission checks on components in a subns
> * @request: permissions to request
> * @perms: perms struct to set
> @@ -1279,7 +1279,6 @@ static int change_profile_perms_wrapper(const char *op, const char *name,
> /**
> * aa_change_profile - perform a one-way profile transition
> * @fqname: name of profile may include namespace (NOT NULL)
> - * @onexec: whether this transition is to take place immediately or at exec
> * @flags: flags affecting change behavior
> *
> * Change to new profile @name. Unlike with hats, there is no way
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH -next] apparmor: Fix some kernel-doc comments
@ 2022-03-17 1:03 Yang Li
2022-03-21 20:20 ` John Johansen
0 siblings, 1 reply; 11+ messages in thread
From: Yang Li @ 2022-03-17 1:03 UTC (permalink / raw)
To: john.johansen
Cc: jmorris, serge, apparmor, linux-security-module, linux-kernel,
Yang Li, Abaci Robot
Remove some warnings found by running scripts/kernel-doc,
which is caused by using 'make W=1'.
security/apparmor/domain.c:137: warning: Function parameter or member
'state' not described in 'label_compound_match'
security/apparmor/domain.c:137: warning: Excess function parameter
'start' description in 'label_compound_match'
security/apparmor/domain.c:1294: warning: Excess function parameter
'onexec' description in 'aa_change_profile'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
security/apparmor/domain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
index a29e69d2c300..d71023f5c9c4 100644
--- a/security/apparmor/domain.c
+++ b/security/apparmor/domain.c
@@ -119,7 +119,7 @@ static inline unsigned int match_component(struct aa_profile *profile,
* @profile: profile to find perms for
* @label: label to check access permissions for
* @stack: whether this is a stacking request
- * @start: state to start match in
+ * @state: state to start match in
* @subns: whether to do permission checks on components in a subns
* @request: permissions to request
* @perms: perms struct to set
@@ -1279,7 +1279,6 @@ static int change_profile_perms_wrapper(const char *op, const char *name,
/**
* aa_change_profile - perform a one-way profile transition
* @fqname: name of profile may include namespace (NOT NULL)
- * @onexec: whether this transition is to take place immediately or at exec
* @flags: flags affecting change behavior
*
* Change to new profile @name. Unlike with hats, there is no way
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-11-19 9:08 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 6:30 [PATCH -next] apparmor: Fix some kernel-doc comments Yang Li
2022-07-20 2:28 ` John Johansen
-- strict thread matches above, loose matches on Subject: below --
2023-10-23 0:55 Yang Li
2023-11-19 9:08 ` John Johansen
2023-07-07 8:07 Yang Li
2023-07-07 14:55 ` Randy Dunlap
2023-07-10 8:48 ` John Johansen
2023-03-03 1:28 [PATCH -next] AppArmor: " Yang Li
2023-04-09 22:19 ` John Johansen
2022-03-17 1:03 [PATCH -next] apparmor: " Yang Li
2022-03-21 20:20 ` John Johansen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.