Re: b4 submit ready for beta testing

From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Maxime Ripard <maxime@cerno.tech>,
	users@linux.kernel.org, tools@linux.kernel.org
Subject: Re: b4 submit ready for beta testing
Date: Mon, 18 Jul 2022 14:26:27 -0400	[thread overview]
Message-ID: <20220718182627.ajyopwr2gqeikxty@meerkat.local> (raw)
In-Reply-To: <20220718182046.GD5049@ziepe.ca>

On Mon, Jul 18, 2022 at 03:20:46PM -0300, Jason Gunthorpe wrote:
> > > >    - If you modify actual code (even as much as fixing a typo in a string), any
> > > >      received trailers will no longer match. This is as designed, because if
> > > >      you change the code, it's no longer reviewed (but we won't remove any
> > > >      existing trailers that were already applied).
> 
> IMHO, I don't like this. It means even minor changes that don't
> invalidate a given "reviewed-by" will not be taken. It should only be
> up to the user to make these decisions when tags should be dropped.

Should we go with "patch-id OR commit subject"?

-K

> > Yeah, and it's the part that I'd like to have as a standalone tool in b4.
> > Can we have some kind of "b4 update-trailers <MSGID>" subcommand?
> 
> +1

Yes, this is easy -- just a matter of sanely identifying how far back we start
looking to match commits to patches. I will probably go with "find all commits
by the current user for the past month and match subjects/patch-ids."

-K