From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C19C43334 for ; Tue, 19 Jul 2022 15:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237944AbiGSPY5 (ORCPT ); Tue, 19 Jul 2022 11:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239342AbiGSPYy (ORCPT ); Tue, 19 Jul 2022 11:24:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F20F8564E7; Tue, 19 Jul 2022 08:24:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 614196183C; Tue, 19 Jul 2022 15:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C198C341C6; Tue, 19 Jul 2022 15:24:49 +0000 (UTC) Date: Tue, 19 Jul 2022 11:24:48 -0400 From: Steven Rostedt To: Chunfeng Yun Cc: , Ingo Molnar , "Andrew Morton" , , , , Greg Kroah-Hartman Subject: Re: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper Message-ID: <20220719112448.4e9915e0@gandalf.local.home> In-Reply-To: <2893728a294ef13bdeba9e587083b82fb794cc68.camel@mediatek.com> References: <20220714164256.403842845@goodmis.org> <20220714164330.311734558@goodmis.org> <1267b234b09280b9b475cfe2bb32580e967e2dac.camel@mediatek.com> <20220715173944.386743d8@gandalf.local.home> <2893728a294ef13bdeba9e587083b82fb794cc68.camel@mediatek.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2022 13:23:06 +0800 Chunfeng Yun wrote: > > Care to send me a patch, and I'll just include it in my series? > Seems no need add another patch, just modify this patch as below: > > diff --git a/drivers/usb/mtu3/mtu3_trace.h > b/drivers/usb/mtu3/mtu3_trace.h > index a09deae1146f..03d2a9bac27e 100644 > --- a/drivers/usb/mtu3/mtu3_trace.h > +++ b/drivers/usb/mtu3/mtu3_trace.h > @@ -18,18 +18,16 @@ > > #include "mtu3.h" > > -#define MTU3_MSG_MAX 256 > - > TRACE_EVENT(mtu3_log, > TP_PROTO(struct device *dev, struct va_format *vaf), > TP_ARGS(dev, vaf), > TP_STRUCT__entry( > __string(name, dev_name(dev)) > - __dynamic_array(char, msg, MTU3_MSG_MAX) > + __vstring(msg, vaf->fmt, vaf->va) > ), > TP_fast_assign( > __assign_str(name, dev_name(dev)); > - vsnprintf(__get_str(msg), MTU3_MSG_MAX, vaf->fmt, *vaf- > >va); > + __assign_vstr(msg, vaf->fmt, vaf->va); > ), > TP_printk("%s: %s", __get_str(name), __get_str(msg)) > ); > > > > remove below two lines > " > -#define MTU3_MSG_MAX 256 > - Fine. Even though I already pushed to linux-next, I did something I seldom do. I rebased my for-next branch and removed this patch. I'll send a v2. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47630C43334 for ; Tue, 19 Jul 2022 15:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2RuLFOQGRkqUg7nz4CxFzi3Li1zlmvqdPjJ1IEsWDVw=; b=gpz9WI80wq5Srl mGicjbPBUfZRWzoqTDIeW210lH1pQvvP/ZTVIeV3bJKaMOuG+tHbjMQUn1maSR8aladOg6933Agd2 bGjV8hegI6KjWTEcjRr+HlABmG7pT5FTessOHz41GiXQwyFLLQnoB6xTv5k70HqJrUv3lVZH9GInr krwubbv/tt2WQkqPXegK7QZGI09aD6RGuBIG19AX7tAktgOanWi9T6KSTYXhjUaRas/G/BD/Flxv6 YRetG3PbpcJAKlNDe7p5z5dAfVcT0tvrjcg7xAef+tZecVqze4sgo9xNj70TtWe3WU/pldXEiZzBT d+5y9ujtcI0n6vx2BkPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDp5n-00A0tE-Qu; Tue, 19 Jul 2022 15:24:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDp5i-00A0qH-Ac; Tue, 19 Jul 2022 15:24:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C97FDB81C00; Tue, 19 Jul 2022 15:24:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C198C341C6; Tue, 19 Jul 2022 15:24:49 +0000 (UTC) Date: Tue, 19 Jul 2022 11:24:48 -0400 From: Steven Rostedt To: Chunfeng Yun Cc: , Ingo Molnar , "Andrew Morton" , , , , Greg Kroah-Hartman Subject: Re: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper Message-ID: <20220719112448.4e9915e0@gandalf.local.home> In-Reply-To: <2893728a294ef13bdeba9e587083b82fb794cc68.camel@mediatek.com> References: <20220714164256.403842845@goodmis.org> <20220714164330.311734558@goodmis.org> <1267b234b09280b9b475cfe2bb32580e967e2dac.camel@mediatek.com> <20220715173944.386743d8@gandalf.local.home> <2893728a294ef13bdeba9e587083b82fb794cc68.camel@mediatek.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_082454_581456_0629EEA4 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Jul 2022 13:23:06 +0800 Chunfeng Yun wrote: > > Care to send me a patch, and I'll just include it in my series? > Seems no need add another patch, just modify this patch as below: > > diff --git a/drivers/usb/mtu3/mtu3_trace.h > b/drivers/usb/mtu3/mtu3_trace.h > index a09deae1146f..03d2a9bac27e 100644 > --- a/drivers/usb/mtu3/mtu3_trace.h > +++ b/drivers/usb/mtu3/mtu3_trace.h > @@ -18,18 +18,16 @@ > > #include "mtu3.h" > > -#define MTU3_MSG_MAX 256 > - > TRACE_EVENT(mtu3_log, > TP_PROTO(struct device *dev, struct va_format *vaf), > TP_ARGS(dev, vaf), > TP_STRUCT__entry( > __string(name, dev_name(dev)) > - __dynamic_array(char, msg, MTU3_MSG_MAX) > + __vstring(msg, vaf->fmt, vaf->va) > ), > TP_fast_assign( > __assign_str(name, dev_name(dev)); > - vsnprintf(__get_str(msg), MTU3_MSG_MAX, vaf->fmt, *vaf- > >va); > + __assign_vstr(msg, vaf->fmt, vaf->va); > ), > TP_printk("%s: %s", __get_str(name), __get_str(msg)) > ); > > > > remove below two lines > " > -#define MTU3_MSG_MAX 256 > - Fine. Even though I already pushed to linux-next, I did something I seldom do. I rebased my for-next branch and removed this patch. I'll send a v2. -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel