All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: andrey.konovalov@linaro.org, konrad.dybcio@somainline.org,
	devicetree@vger.kernel.org, daniele.alessandrelli@intel.com,
	jacopo@jmondi.org, linux-media@vger.kernel.org,
	dmitry.baryshkov@linaro.org, mchehab@kernel.org,
	sakari.ailus@iki.fi, paul.j.murphy@intel.com
Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: Rename imx412 to imx577
Date: Wed, 20 Jul 2022 16:31:40 -0600	[thread overview]
Message-ID: <20220720223140.GA4099645-robh@kernel.org> (raw)
In-Reply-To: <20220718014215.1240114-2-bryan.odonoghue@linaro.org>

On Mon, 18 Jul 2022 02:42:13 +0100, Bryan O'Donoghue wrote:
> The yaml and driver we have right now misidentifies the imx577 as the
> imx412.
> 
> Looking at similar IMX chips which give their chip identifier via register
> 0x0016 we can see:
> 
> drivers/media/i2c/imx258.c:#define IMX258_REG_CHIP_ID    0x0016
> drivers/media/i2c/imx258.c:#define IMX258_CHIP_ID        0x0258
> 
> drivers/media/i2c/imx319.c:#define IMX319_REG_CHIP_ID    0x0016
> drivers/media/i2c/imx319.c:#define IMX319_CHIP_ID        0x0319
> 
> drivers/media/i2c/imx355.c:#define IMX355_REG_CHIP_ID    0x0016
> drivers/media/i2c/imx355.c:#define IMX355_CHIP_ID        0x0355
> 
> Right now imx412.c does:
> 
> drivers/media/i2c/imx412.c:#define IMX412_REG_ID         0x0016
> drivers/media/i2c/imx412.c:#define IMX412_ID             0x577
> 
> As a first step to fixing this problem rename the supporting yaml file and
> containing text from imx412 to imx577.
> 
> Fixes: 333b3125d130 ("media: dt-bindings: media: Add bindings for imx412")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../i2c/{sony,imx412.yaml => sony,imx577.yaml} | 18 +++++++++---------
>  MAINTAINERS                                    |  6 +++---
>  2 files changed, 12 insertions(+), 12 deletions(-)
>  rename Documentation/devicetree/bindings/media/i2c/{sony,imx412.yaml => sony,imx577.yaml} (83%)
> 

Acked-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2022-07-20 22:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  1:42 [PATCH v2 0/3] Add imx577 compatible to imx412 Bryan O'Donoghue
2022-07-18  1:42 ` [PATCH v2 1/3] media: dt-bindings: media: Rename imx412 to imx577 Bryan O'Donoghue
2022-07-20 22:31   ` Rob Herring [this message]
2022-07-22 16:03   ` Sakari Ailus
2022-07-22 16:47     ` Bryan O'Donoghue
2022-07-18  1:42 ` [PATCH v2 2/3] media: i2c: imx577: Rename imx412.c to imx577.c Bryan O'Donoghue
2022-07-18  1:42 ` [PATCH v2 3/3] media: i2c: imx577: Fix chip identifier define name Bryan O'Donoghue
2022-07-21 15:15 ` [PATCH v2 0/3] Add imx577 compatible to imx412 Alessandrelli, Daniele
2022-07-21 15:24   ` Bryan O'Donoghue
2022-07-27 20:12   ` Alessandrelli, Daniele
2022-07-28  2:01     ` Bryan O'Donoghue
2022-07-28 11:41       ` sakari.ailus
2022-07-28 12:05         ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720223140.GA4099645-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrey.konovalov@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=daniele.alessandrelli@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jacopo@jmondi.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.