From: Vikas Gupta <vikas.gupta@broadcom.com>
To: jiri@nvidia.com, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, dsahern@kernel.org,
stephen@networkplumber.org, edumazet@google.com,
pabeni@redhat.com, ast@kernel.org, leon@kernel.org,
linux-doc@vger.kernel.org, corbet@lwn.net,
michael.chan@broadcom.com, andrew.gospodarek@broadcom.com,
Vikas Gupta <vikas.gupta@broadcom.com>
Subject: [PATCH net-next v4 0/3] add framework for selftests in devlink
Date: Thu, 21 Jul 2022 12:51:18 +0530 [thread overview]
Message-ID: <20220721072121.43648-1-vikas.gupta@broadcom.com> (raw)
In-Reply-To: <20220718062032.22426-1-vikas.gupta@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]
Hi,
This patchset adds support for selftests in the devlink framework.
It adds a callback .selftests_check and .selftests_run in devlink_ops.
User can add test(s) suite which is subsequently passed to the driver
and driver can opt for running particular tests based on its capabilities.
Patchset adds a flash based test for the bnxt_en driver.
Suggested commands at user level would be as below:
changes from:
v3->v4:
Addressed the changes requested by kuba@kernel.org in patch v3.
v2->v3:
1)
After discussions with jiri@nvidia.com, passing a testmask from
user to kernel is removed and a flag based arguments are adopted.
This way we can have more than 32/64 selftests defined in the
kernel.
Below is the format from user to kernel and vice-versa.
Kernel to user for show command . Users can know what all tests are
supported by the driver. A return from kernel to user if driver
supports TEST1, TEST4, and TEST7.
______
|NEST |
|_____ |TEST1|TEST4|TEST7|...
User to kernel to execute test: If user wants to execute test4, test8,
test1...
______
|NEST |
|_____ |TEST4|TEST8|TEST1|...
After executing the tests kernel return to user.
|NEST |
|_____ | NEST| |NEST| |NEST|
TEST4,RES4 TEST8,RES8 TEST1, RES1
2) Added dumpit in devlink for list/show command.
v1->v2:
Addressed the changes requested by kuba@kernel.org in patch v1.
Fixed the style issues.
Thanks,
Vikas
Vikas Gupta (3):
devlink: introduce framework for selftests
bnxt_en: refactor NVM APIs
bnxt_en: implement callbacks for devlink selftests
.../networking/devlink/devlink-selftests.rst | 38 +++
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 60 +++++
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 24 +-
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 12 +
include/net/devlink.h | 20 ++
include/uapi/linux/devlink.h | 29 +++
net/core/devlink.c | 225 ++++++++++++++++++
7 files changed, 396 insertions(+), 12 deletions(-)
create mode 100644 Documentation/networking/devlink/devlink-selftests.rst
--
2.31.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]
next prev parent reply other threads:[~2022-07-21 7:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0220707182950.29348-1-vikas.gupta@broadcom.com>
2022-07-18 6:20 ` [PATCH net-next v3 0/3] add framework for selftests in devlink Vikas Gupta
2022-07-18 6:20 ` [PATCH net-next v3 1/3] devlink: introduce framework for selftests Vikas Gupta
2022-07-19 3:33 ` Jakub Kicinski
2022-07-19 10:18 ` Vikas Gupta
2022-07-18 6:20 ` [PATCH net-next v3 2/3] bnxt_en: refactor NVM APIs Vikas Gupta
2022-07-18 6:20 ` [PATCH net-next v3 3/3] bnxt_en: implement callbacks for devlink selftests Vikas Gupta
2022-07-21 7:21 ` Vikas Gupta [this message]
2022-07-21 7:21 ` [PATCH net-next v4 1/3] devlink: introduce framework for selftests Vikas Gupta
2022-07-21 12:56 ` Jiri Pirko
2022-07-21 17:32 ` Vikas Gupta
2022-07-22 6:41 ` Jiri Pirko
2022-07-21 13:01 ` Jiri Pirko
2022-07-21 7:21 ` [PATCH net-next v4 2/3] bnxt_en: refactor NVM APIs Vikas Gupta
2022-07-21 13:02 ` Jiri Pirko
2022-07-21 14:24 ` Vikas Gupta
2022-07-21 7:21 ` [PATCH net-next v4 3/3] bnxt_en: implement callbacks for devlink selftests Vikas Gupta
2022-07-21 12:59 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721072121.43648-1-vikas.gupta@broadcom.com \
--to=vikas.gupta@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=ast@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.