From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDD4CCA487 for ; Thu, 21 Jul 2022 15:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230011AbiGUPaE (ORCPT ); Thu, 21 Jul 2022 11:30:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiGUPaC (ORCPT ); Thu, 21 Jul 2022 11:30:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A32980497; Thu, 21 Jul 2022 08:30:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C314BB8253C; Thu, 21 Jul 2022 15:29:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A0C0C3411E; Thu, 21 Jul 2022 15:29:55 +0000 (UTC) Date: Thu, 21 Jul 2022 11:29:53 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: Wim Van Sebroeck , Guenter Roeck , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , Tao Zhou , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Petr Mladek , Sergey Senozhatsky , John Ogness Subject: Re: [PATCH V6 15/16] rv/reactor: Add the printk reactor Message-ID: <20220721112953.12828bd5@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Including the printk folks ] On Tue, 19 Jul 2022 19:27:20 +0200 Daniel Bristot de Oliveira wrote: > A reactor that printks the reaction message. > > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: Jonathan Corbet > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: Will Deacon > Cc: Catalin Marinas > Cc: Marco Elver > Cc: Dmitry Vyukov > Cc: "Paul E. McKenney" > Cc: Shuah Khan > Cc: Gabriele Paoloni > Cc: Juri Lelli > Cc: Clark Williams > Cc: Tao Zhou > Cc: Randy Dunlap > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-trace-devel@vger.kernel.org > Signed-off-by: Daniel Bristot de Oliveira > --- > kernel/trace/rv/Kconfig | 8 ++++++ > kernel/trace/rv/Makefile | 3 ++- > kernel/trace/rv/reactor_printk.c | 42 ++++++++++++++++++++++++++++++++ > 3 files changed, 52 insertions(+), 1 deletion(-) > create mode 100644 kernel/trace/rv/reactor_printk.c > > diff --git a/kernel/trace/rv/Kconfig b/kernel/trace/rv/Kconfig > index d8c40fd67e88..f1d92d431130 100644 > --- a/kernel/trace/rv/Kconfig > +++ b/kernel/trace/rv/Kconfig > @@ -63,3 +63,11 @@ config RV_REACTORS > on the model's execution. By default, the monitors have > tracing reactions, printing the monitor output via tracepoints, > but other reactions can be added (on-demand) via this interface. > + > +config RV_REACT_PRINTK > + bool "Printk reactor" > + depends on RV_REACTORS > + default y > + help > + Enables the printk reactor. The printk reactor emits a printk() > + message if an exception is found. > diff --git a/kernel/trace/rv/Makefile b/kernel/trace/rv/Makefile > index af0ff9a46418..a13c750a35c1 100644 > --- a/kernel/trace/rv/Makefile > +++ b/kernel/trace/rv/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_RV) += rv.o > -obj-$(CONFIG_RV_REACTORS) += rv_reactors.o > obj-$(CONFIG_RV_MON_WIP) += monitors/wip/wip.o > obj-$(CONFIG_RV_MON_WWNR) += monitors/wwnr/wwnr.o > +obj-$(CONFIG_RV_REACTORS) += rv_reactors.o > +obj-$(CONFIG_RV_REACT_PRINTK) += reactor_printk.o > diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c > new file mode 100644 > index 000000000000..8b5c70b05634 > --- /dev/null > +++ b/kernel/trace/rv/reactor_printk.c > @@ -0,0 +1,42 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira > + * > + * Printk RV reactor: > + * Prints the exception msg to the kernel message log. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > + > +static void rv_printk_reaction(char *msg) > +{ > + printk_deferred(msg); I added the printk folks just so that they are aware of another printk_deferred() being added to the kernel. -- Steve > +} > + > +static struct rv_reactor rv_printk = { > + .name = "printk", > + .description = "prints the exception msg to the kernel message log", > + .react = rv_printk_reaction > +}; > + > +static int register_react_printk(void) > +{ > + rv_register_reactor(&rv_printk); > + return 0; > +} > + > +static void unregister_react_printk(void) > +{ > + rv_unregister_reactor(&rv_printk); > +} > + > +module_init(register_react_printk); > +module_exit(unregister_react_printk); > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Daniel Bristot de Oliveira"); > +MODULE_DESCRIPTION("printk rv reactor: printk if an exception is hit");