From: kernel test robot <lkp@intel.com>
To: Yevhen Orlov <yevhen.orlov@plvision.eu>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-kernel@vger.kernel.org,
Yevhen Orlov <yevhen.orlov@plvision.eu>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: Re: [PATCH net-next v2 6/9] net: marvell: prestera: Add heplers to interact with fib_notifier_info
Date: Fri, 22 Jul 2022 08:21:45 +0800 [thread overview]
Message-ID: <202207220859.9D3mfHop-lkp@intel.com> (raw)
In-Reply-To: <20220721221148.18787-7-yevhen.orlov@plvision.eu>
Hi Yevhen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Yevhen-Orlov/net-marvell-prestera-add-nexthop-routes-offloading/20220722-061517
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5588d628027092e66195097bdf6835ddf64418b3
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220722/202207220859.9D3mfHop-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/a6535f7f7b3aea14504cac208c170d413739d5f9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yevhen-Orlov/net-marvell-prestera-add-nexthop-routes-offloading/20220722-061517
git checkout a6535f7f7b3aea14504cac208c170d413739d5f9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/ethernet/marvell/prestera/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/marvell/prestera/prestera_router.c: In function 'prestera_kern_fib_info_nhs':
>> drivers/net/ethernet/marvell/prestera/prestera_router.c:274:47: warning: the comparison will always evaluate as 'true' for the address of 'fib6_nh' will never be NULL [-Waddress]
274 | return fen6_info->rt->fib6_nh ?
| ^
In file included from include/net/nexthop.h:17,
from drivers/net/ethernet/marvell/prestera/prestera_router.c:10:
include/net/ip6_fib.h:206:41: note: 'fib6_nh' declared here
206 | struct fib6_nh fib6_nh[];
| ^~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c: In function '__prestera_k_arb_fc_apply':
drivers/net/ethernet/marvell/prestera/prestera_router.c:466:9: warning: enumeration value 'PRESTERA_FIB_TYPE_UC_NH' not handled in switch [-Wswitch]
466 | switch (fc->lpm_info.fib_type) {
| ^~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c: At top level:
drivers/net/ethernet/marvell/prestera/prestera_router.c:262:12: warning: 'prestera_kern_fib_info_nhs' defined but not used [-Wunused-function]
262 | static int prestera_kern_fib_info_nhs(struct fib_notifier_info *info)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c:230:1: warning: 'prestera_kern_fib_info_nhc' defined but not used [-Wunused-function]
230 | prestera_kern_fib_info_nhc(struct fib_notifier_info *info, int n)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c:216:1: warning: 'prestera_util_kern_set_nh_offload' defined but not used [-Wunused-function]
216 | prestera_util_kern_set_nh_offload(struct fib_nh_common *nhc, bool offloaded, bool trap)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c:206:13: warning: 'prestera_util_kern_set_neigh_offload' defined but not used [-Wunused-function]
206 | static void prestera_util_kern_set_neigh_offload(struct neighbour *n,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c:194:1: warning: 'prestera_util_kern_n_is_reachable' defined but not used [-Wunused-function]
194 | prestera_util_kern_n_is_reachable(u32 tb_id,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c:135:13: warning: 'prestera_fib_info_is_nh' defined but not used [-Wunused-function]
135 | static bool prestera_fib_info_is_nh(struct fib_notifier_info *info)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/prestera/prestera_router.c:122:13: warning: 'prestera_fib_info_is_direct' defined but not used [-Wunused-function]
122 | static bool prestera_fib_info_is_direct(struct fib_notifier_info *info)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +274 drivers/net/ethernet/marvell/prestera/prestera_router.c
261
262 static int prestera_kern_fib_info_nhs(struct fib_notifier_info *info)
263 {
264 struct fib6_entry_notifier_info *fen6_info;
265 struct fib_entry_notifier_info *fen4_info;
266
267 if (info->family == AF_INET) {
268 fen4_info = container_of(info, struct fib_entry_notifier_info,
269 info);
270 return fib_info_num_path(fen4_info->fi);
271 } else if (info->family == AF_INET6) {
272 fen6_info = container_of(info, struct fib6_entry_notifier_info,
273 info);
> 274 return fen6_info->rt->fib6_nh ?
275 (fen6_info->rt->fib6_nsiblings + 1) : 0;
276 }
277
278 return 0;
279 }
280
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-22 0:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 22:11 [PATCH net-next v2 0/9] net: marvell: prestera: add nexthop routes offloading Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 1/9] net: marvell: prestera: Add router nexthops ABI Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 2/9] net: marvell: prestera: Add cleanup of allocated fib_nodes Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 3/9] net: marvell: prestera: Add strict cleanup of fib arbiter Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 4/9] net: marvell: prestera: add delayed wq and flush wq on deinit Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 5/9] net: marvell: prestera: Add length macros for prestera_ip_addr Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 6/9] net: marvell: prestera: Add heplers to interact with fib_notifier_info Yevhen Orlov
2022-07-22 0:21 ` kernel test robot [this message]
2022-07-23 10:11 ` kernel test robot
2022-07-21 22:11 ` [PATCH net-next v2 7/9] net: marvell: prestera: add stub handler neighbour events Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 8/9] net: marvell: prestera: Add neighbour cache accounting Yevhen Orlov
2022-07-21 22:11 ` [PATCH net-next v2 9/9] net: marvell: prestera: Propogate nh state from hw to kernel Yevhen Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207220859.9D3mfHop-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=pabeni@redhat.com \
--cc=serhiy.pshyk@plvision.eu \
--cc=stephen@networkplumber.org \
--cc=taras.chornyi@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
--cc=yevhen.orlov@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.