All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Stefano Brivio" <sbrivio@redhat.com>
Subject: [PATCH v6 06/14] net: stream: Don't ignore EINVAL on netdev socket connection
Date: Fri, 22 Jul 2022 20:56:53 +0200	[thread overview]
Message-ID: <20220722185701.300449-7-lvivier@redhat.com> (raw)
In-Reply-To: <20220722185701.300449-1-lvivier@redhat.com>

From: Stefano Brivio <sbrivio@redhat.com>

Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 net/stream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/stream.c b/net/stream.c
index 0851e90becca..e8afbaca50b6 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -363,8 +363,7 @@ static int net_stream_client_init(NetClientState *peer,
                 if (errno == EINTR || errno == EWOULDBLOCK) {
                     /* continue */
                 } else if (errno == EINPROGRESS ||
-                           errno == EALREADY ||
-                           errno == EINVAL) {
+                           errno == EALREADY) {
                     break;
                 } else {
                     error_setg_errno(errp, errno, "can't connect socket");
-- 
2.37.1



  parent reply	other threads:[~2022-07-22 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22 18:56 [PATCH v6 00/14] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 01/14] net: introduce convert_host_port() Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 02/14] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 03/14] net: simplify net_client_parse() error management Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 04/14] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 05/14] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-07-22 18:56 ` Laurent Vivier [this message]
2022-07-22 18:56 ` [PATCH v6 07/14] net: stream: add unix socket Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 08/14] net: dgram: make dgram_dst generic Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 09/14] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-07-22 18:56 ` [PATCH v6 10/14] net: dgram: add unix socket Laurent Vivier
2022-07-22 19:06 ` [PATCH v6 00/14] qapi: net: add unix socket type support to netdev backend Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220722185701.300449-7-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sbrivio@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.