From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C321C433EF for ; Sat, 23 Jul 2022 00:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B07F06B0071; Fri, 22 Jul 2022 20:17:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB69E6B0073; Fri, 22 Jul 2022 20:17:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A51E6B0074; Fri, 22 Jul 2022 20:17:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8ADF76B0071 for ; Fri, 22 Jul 2022 20:17:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 656A6120DB5 for ; Sat, 23 Jul 2022 00:17:29 +0000 (UTC) X-FDA: 79716450618.09.560D056 Received: from r3-24.sinamail.sina.com.cn (r3-24.sinamail.sina.com.cn [202.108.3.24]) by imf09.hostedemail.com (Postfix) with SMTP id 2EFC4140005 for ; Sat, 23 Jul 2022 00:17:26 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.249.59.48]) by sina.com (172.16.97.23) with ESMTP id 62DB3E00000024AD; Sat, 23 Jul 2022 08:17:06 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 67424154920716 From: Hillf Danton To: Doug Anderson Cc: Waiman Long , Peter Zijlstra , Will Deacon , Davidlohr Bueso , MM , LKML Subject: Re: [PATCH v5] locking/rwsem: Make handoff bit handling more consistent Date: Sat, 23 Jul 2022 08:17:13 +0800 Message-Id: <20220723001713.2156-1-hdanton@sina.com> In-Reply-To: References: <20211116012912.723980-1-longman@redhat.com> <20220719104104.1634-1-hdanton@sina.com> <20220722115510.2101-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658535449; a=rsa-sha256; cv=none; b=uYihzFkJsWdfeWKB5RdBvYB1dnGQjKXP4fP62xW/yf2BwOwev01wNa0xr/MwSOTHZVHVSf /Pxr25zkre9o4K316aDcu2TVH6fL2rs+f3F2RVa3ay+bhnXRSWRK6X04OCSUfPXxbBKITQ z1BMxKFyPRdAoA3P2kjteEEqVvPQGnw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.24 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658535449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/rXgh+JtpRuN3UM5KayrRu5XkqoJqsRhtXM5rHql4cw=; b=UMrRcoEyoJ7SHdv4K8sWrktcODWU+ErtjIJwRgiTl+jLljnO6Q35/Nx8dXSVpuTUZot7C6 NSDlmz3217YmEuvzkbTJOcKuQ0Gmwycr6z9jJ9X4hyQtxNH8hKjZAOjRRI7N+sq3FWJFMs NXpy6Vptr0sGk5hZEv0hrakstKAu5GE= X-Rspamd-Queue-Id: 2EFC4140005 Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.24 as permitted sender) smtp.mailfrom=hdanton@sina.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 4w9i96whweeinmprb8iqeoeicudhw1nc X-HE-Tag: 1658535446-670674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Jul 2022 07:02:42 -0700 Doug Anderson wrote: > > Thanks! I added this diff to your previous diff and my simple test > still passes and I don't see your WARN_ON triggered. Thanks! > > How do we move forward? Are you going to officially submit a patch > with both of your diffs squashed together? Are we waiting for > additional review from someone? Given it is not unusual for us to miss anything important, lets take a RWSEM_WAIT_TIMEOUT nap now or two. Hillf