Re: [Buildroot] [PATCH v3] package/ntpsec: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Peter,

On Fri, 31 Dec 2021 09:49:23 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> - set 'CC="$(HOSTCC)"' to avoid cross-compile failure (see [1]):
> 
>   /bin/sh: line 1: .../build/ntpsec-1_2_0/build/host/ntpd/keyword-gen: cannot execute binary file: Exec format error
> 
>   Waf: Leaving directory `.../build/ntpsec-1_2_0/build/host'
>   Build failed
>    -> task in 'ntp_keyword.h' failed with exit status 126 (run with -v to display more information)  
> 
> - set '-std=gnu99"' to avoid compile failure with old compilers
> 
> - explicit set PYTHON_CONFIG
> 
> - add patch 001-ntptime-fix-jfmt5-ofmt5-jfmt6-ofmt6-related-compile-.patch to
>   fix ntptime jfmt5/ofmt5 jfmt6/ofmt6 related compile failure
> 
> - add patch 0002-wscript-remove-checks-for-bsd-string.h-fixes-host-co.patch to
>   fix host-compile failure in case target libbsd is detected
> 
> - add SYSV init file (S49ntp)
> 
> - add example ntpd.conf (with legacy option enabled and provide skeleton
>   for NTS configuration)
> 
> - add config option for NTS support
> 
> - depend on python3 (omit python2 to reduce test effort)
> 
> - add ntp user/group and run ntpd as restricted user
> 
> - add libcap dependency (compile time optional but needed for droproot
>   support)
> 
> [1] https://gitlab.com/NTPsec/ntpsec/-/issues/694
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v2 -> v3:
>   - update 0001-ntptime-fix-jfmt5-ofmt5-jfmt6-ofmt6-related-compile-.patch
>   - add 0002-wscript-remove-checks-for-bsd-string.h-fixes-host-co.patch

I've finally applied to master. Changes done:

 - S49ntp was renamed to S49ntpd, because check-package wants the init
   script to be named after the daemon that it starts

 - the LICENSE variable is comma separated, not space-separated

 - the depends on BR2_PACKAGE_PYTHON3 has been replaced by select
   BR2_PACKAGE_PYTHON3, as we now only support python3

Speaking of the need for python on the target, I found it a bit silly,
because the daemon itself is written in C. So I filled an issue
upstream yesterday: https://gitlab.com/NTPsec/ntpsec/-/issues/743, and
they are already working on it, with an initial proposal at
https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1282. It will be
useful to follow this issue and see if we can lift the python3
requirement on the target.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot