Re: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu interface

From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	Christoph Hellwig <hch@infradead.org>,
	Kevin Tian <kevin.tian@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
	Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
	Jacob jun Pan <jacob.jun.pan@intel.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	Zhu Tony <tony.zhu@intel.com>,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu interface
Date: Mon, 25 Jul 2022 11:40:05 -0300	[thread overview]
Message-ID: <20220725144005.GE3747@nvidia.com> (raw)
In-Reply-To: <686b137f-232a-2a78-beb0-e4373bd20959@linux.intel.com>

On Sun, Jul 24, 2022 at 03:03:16PM +0800, Baolu Lu wrote:

> How about rephrasing this part of commit message like below:
> 
> Some buses, like PCI, route packets without considering the PASID value.
> Thus a DMA target address with PASID might be treated as P2P if the
> address falls into the MMIO BAR of other devices in the group. To make
> things simple, these interfaces only apply to devices belonging to the
> singleton groups.

> Considering that the PCI bus supports hot-plug, even a device boots with
> a singleton group, a later hot-added device is still possible to share
> the group, which breaks the singleton group assumption. In order to
> avoid this situation, this interface requires that the ACS is enabled on
> all devices on the path from the device to the host-PCI bridge.

But ACS directly fixes the routing issue above

This entire explanation can be recast as saying we block PASID
attachment in all cases where the PCI fabric is routing based on
address. ACS disables that.

Not sure it even has anything to do with hotplug or singleton??

Jason