From: Daniel Wagner <dwagner@suse.de>
To: Chao Leng <lengchao@huawei.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: consider also host_iface when checking ip options
Date: Tue, 26 Jul 2022 09:18:45 +0200 [thread overview]
Message-ID: <20220726071845.i2sq2p3c6e6hoa7h@carbon> (raw)
In-Reply-To: <37845bb2-c868-938b-8aed-cbc18594b9d6@huawei.com>
On Tue, Jul 26, 2022 at 10:11:41AM +0800, Chao Leng wrote:
> Checking host_iface is similar to host_tradr, so some suggestions:
> First, move these codes near checking host_traddr.
We have several places where we have the same sequence as above, that is
traddr, trsvcid and then host_iface, e.g. nvme_class_uevent,
nvmf_free_options, nvmf_get_address. So I'd say we should stick to this
and not start introducing a new ordering scheme.
> Second, the checking logic should be the same as that of host_tradr.
What do you mean with this? We compare the host_iface with strcmp. It is
exactly the same thing we do with traddr and trsvcid.
> It might be better to add a helper to implement host port attribute
> checking. Of course, this can be considered as a separate patch.
As far I can tell Christoph is not a big fan of small one-line helpers
especially if there is only one call place. But as you said, that's his
call :)
next prev parent reply other threads:[~2022-07-26 7:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 9:24 [PATCH v2] nvme: consider also host_iface when checking ip options Daniel Wagner
2022-07-22 9:37 ` Chao Leng
2022-07-22 9:46 ` Daniel Wagner
2022-07-22 9:55 ` Chao Leng
2022-07-22 10:09 ` Daniel Wagner
2022-07-25 0:52 ` Chao Leng
2022-07-25 9:25 ` Daniel Wagner
2022-07-26 2:11 ` Chao Leng
2022-07-26 7:18 ` Daniel Wagner [this message]
2022-07-27 6:52 ` Chao Leng
2022-07-27 8:03 ` Daniel Wagner
2022-07-28 1:20 ` Chao Leng
2022-07-22 13:49 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726071845.i2sq2p3c6e6hoa7h@carbon \
--to=dwagner@suse.de \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.