From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D808AC00144 for ; Tue, 26 Jul 2022 16:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239450AbiGZQb6 (ORCPT ); Tue, 26 Jul 2022 12:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbiGZQb4 (ORCPT ); Tue, 26 Jul 2022 12:31:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9845F765A; Tue, 26 Jul 2022 09:31:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F23161513; Tue, 26 Jul 2022 16:31:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BD8BC433C1; Tue, 26 Jul 2022 16:31:52 +0000 (UTC) Date: Tue, 26 Jul 2022 12:31:50 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: Wim Van Sebroeck , Guenter Roeck , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , Tao Zhou , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org Subject: Re: [PATCH V7 11/16] Documentation/rv: Add deterministic automata instrumentation documentation Message-ID: <20220726123150.208e7a17@gandalf.local.home> In-Reply-To: <9ed16a6d24b9d993e09755d6e18ff5e7d5434636.1658778484.git.bristot@kernel.org> References: <9ed16a6d24b9d993e09755d6e18ff5e7d5434636.1658778484.git.bristot@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2022 22:11:23 +0200 Daniel Bristot de Oliveira wrote: > +++ b/Documentation/trace/rv/da_monitor_instrumentation.rst > @@ -0,0 +1,171 @@ > +Finally, the "handle_sched_waking()" will look like:: > + > + void handle_sched_waking(void *data, struct task_struct *task) > + { > + da_handle_event_wip(sched_waking_wip); > + } > + > +And the explanation is left for the reader as an exercise. > + > +enable and disable functions > +------------------------ The doc processing requires that the '-' count matches the above string count. And you may want to capitalize the first letter: Enable and disable functions ---------------------------- -- Steve > + > +dot2k automatically creates two special functions:: > + > + enable_$(MONITOR_NAME)() > + disable_$(MONITOR_NAME)() > +