* [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins
@ 2022-07-27 14:01 Krzysztof Kozlowski
2022-07-28 15:01 ` Rob Herring
2022-07-31 12:30 ` Jonathan Cameron
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-27 14:01 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Rob Herring,
Krzysztof Kozlowski, H. Nikolaus Schaller, linux-iio, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
BMG160 has two interrupt pins to which interrupts can be freely mapped.
Correct the schema to express such case and fix warnings like:
qcom/msm8916-alcatel-idol347.dtb: gyroscope@68: interrupts: [[97, 1], [98, 1]] is too long
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
index b6bbc312a7cf..ebf98bc2eb7f 100644
--- a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
+++ b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
@@ -24,6 +24,9 @@ properties:
interrupts:
minItems: 1
+ items:
+ - description: INT1 pin
+ - description: INT2 pin
description:
Should be configured with type IRQ_TYPE_EDGE_RISING.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins
2022-07-27 14:01 [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins Krzysztof Kozlowski
@ 2022-07-28 15:01 ` Rob Herring
2022-07-31 12:30 ` Jonathan Cameron
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-07-28 15:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, H. Nikolaus Schaller, linux-kernel,
linux-iio, devicetree, Jonathan Cameron, Rob Herring,
Lars-Peter Clausen
On Wed, 27 Jul 2022 16:01:48 +0200, Krzysztof Kozlowski wrote:
> BMG160 has two interrupt pins to which interrupts can be freely mapped.
> Correct the schema to express such case and fix warnings like:
>
> qcom/msm8916-alcatel-idol347.dtb: gyroscope@68: interrupts: [[97, 1], [98, 1]] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins
2022-07-27 14:01 [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins Krzysztof Kozlowski
2022-07-28 15:01 ` Rob Herring
@ 2022-07-31 12:30 ` Jonathan Cameron
2022-08-05 7:10 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2022-07-31 12:30 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lars-Peter Clausen, Rob Herring, Krzysztof Kozlowski,
H. Nikolaus Schaller, linux-iio, devicetree, linux-kernel
On Wed, 27 Jul 2022 16:01:48 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> BMG160 has two interrupt pins to which interrupts can be freely mapped.
> Correct the schema to express such case and fix warnings like:
>
> qcom/msm8916-alcatel-idol347.dtb: gyroscope@68: interrupts: [[97, 1], [98, 1]] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
We may need more than this. What if only INT2 is wired? I'd expect such
a device's binding to include interrupt-names to cover that case.
We'd also need a bunch of driver code to route the resulting interrupts.
I think the snag is that adding such support will break existing bindings using the
below.
> ---
> .../devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
> index b6bbc312a7cf..ebf98bc2eb7f 100644
> --- a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
> +++ b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
> @@ -24,6 +24,9 @@ properties:
>
> interrupts:
> minItems: 1
> + items:
> + - description: INT1 pin
> + - description: INT2 pin
> description:
> Should be configured with type IRQ_TYPE_EDGE_RISING.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins
2022-07-31 12:30 ` Jonathan Cameron
@ 2022-08-05 7:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-05 7:10 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Rob Herring, Krzysztof Kozlowski,
H. Nikolaus Schaller, linux-iio, devicetree, linux-kernel
On 31/07/2022 14:30, Jonathan Cameron wrote:
> On Wed, 27 Jul 2022 16:01:48 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> BMG160 has two interrupt pins to which interrupts can be freely mapped.
>> Correct the schema to express such case and fix warnings like:
>>
>> qcom/msm8916-alcatel-idol347.dtb: gyroscope@68: interrupts: [[97, 1], [98, 1]] is too long
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> We may need more than this. What if only INT2 is wired?
Right, thanks for pointing it out.
> I'd expect such
> a device's binding to include interrupt-names to cover that case.
> We'd also need a bunch of driver code to route the resulting interrupts.
Yes, which is a bit out of scope of fixing schema/DTS. The driver
supports only one interrupt and bindings are unspecific, so I think the
author just did not care about making it correct.
>
> I think the snag is that adding such support will break existing bindings using the
> below.
I can prepare more relaxed version of the patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-05 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 14:01 [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins Krzysztof Kozlowski
2022-07-28 15:01 ` Rob Herring
2022-07-31 12:30 ` Jonathan Cameron
2022-08-05 7:10 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.