From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F646C04A68 for ; Wed, 27 Jul 2022 14:15:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0676683445; Wed, 27 Jul 2022 16:15:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dZNeQuzf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E62BC83FFF; Wed, 27 Jul 2022 16:15:23 +0200 (CEST) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 186C781F69 for ; Wed, 27 Jul 2022 16:15:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id b11so8431228qvo.11 for ; Wed, 27 Jul 2022 07:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qwqzwECkNfETpb89WWOiU33PI7adh33lEjMOJYFrQGs=; b=dZNeQuzfMl7J0gq7icSqs9UcEXW/fXAtDqCHzj3HYgEJnPCZ7GYQIVfvtvT7UDJ71d uU+ygj4+7ZUhg32PpjYM5Yyjn7BSUUJC2TKUp28KjiCNkrP5pPm5hRBg7e17l6AfLHBP NbkCUO7uewdqWyI5BrZlZ3ZCBjdssK27Eqzrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qwqzwECkNfETpb89WWOiU33PI7adh33lEjMOJYFrQGs=; b=wu3XD30BylLuYd3r8MB91vZyNtQ4UVNxmUw3OBTtTcjVMkbmZI/dQ3r7X9G0JcclUn my2t1/XZmLUSzST4ZCxuQTKugXbg+cfvZNV1s9uwtVZ4dfMCoUzZWimRIZtm1lw6jeLZ NcV9MhcaquY8LoqfFFBOcIeRdJfANqAD29bl+fhsqmQRBReX9pYn0A0a2Q1TZixTYJ4z CGxvbhk5hYLZJUq72NHs/5Pg4MYDVLeCiHyz/bKDthX723fWKUnMEBKBfeJq9LnGQopt 15fnmkKETht89/gQKnxTq3OQ0h2DMppvIWupCcrktE5IUDmAcRBrPA0N4tlJQjrfWTFT deEg== X-Gm-Message-State: AJIora81vATdgMkkzZEZ+ETix1aLm15TReu6AjrF7gpMzKg4l2zG+wF/ 4rJ4oLku7AZzqQyiyk14W8EmVw== X-Google-Smtp-Source: AGRyM1v5zjAxlr/VgutN2kNYtUpZAmi0zdpmAZSkDqtrsog1zCCLwq8f+AX4YdtToFErvXw2VhmM7g== X-Received: by 2002:ad4:5f88:0:b0:474:7243:a436 with SMTP id jp8-20020ad45f88000000b004747243a436mr3417186qvb.13.1658931319703; Wed, 27 Jul 2022 07:15:19 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id p2-20020a05622a00c200b0031d3d0b2a04sm11515743qtw.9.2022.07.27.07.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 07:15:18 -0700 (PDT) Date: Wed, 27 Jul 2022 10:15:16 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Martin Bonner , Bin Meng , u-boot@lists.denx.de Subject: Re: [PATCH v4] Improve Windows build documentation Message-ID: <20220727141516.GX1146598@bill-the-cat> References: <18521899-b63c-6f91-971e-3efb6067fdb9@gmx.de> <809d36a7-12a8-669b-e9e5-07a398e0f746@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sd9do8a5kVlkH6z4" Content-Disposition: inline In-Reply-To: <809d36a7-12a8-669b-e9e5-07a398e0f746@gmx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --sd9do8a5kVlkH6z4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2022 at 03:56:07PM +0200, Heinrich Schuchardt wrote: > On 7/27/22 15:51, Heinrich Schuchardt wrote: > > On 7/27/22 15:29, Heinrich Schuchardt wrote: > > > On 7/25/22 09:42, Martin Bonner wrote: > > > > * Add three more modules that are required. > > > > * Remove the version numbers (because they are hard to keep in sync > > > > =A0=A0 with the latest MSYS2 versions) > > > > * Add a pacman command line to install everything. > > > >=20 > > > > Signed-off-by: Martin Bonner > > >=20 > > > Your mail is not a valid patch: > > >=20 > > > $ git am /tmp/0.patch > > > Applying: Improve Windows build documentation > > > error: corrupt patch at line 10 > > > Patch failed at 0001 Improve Windows build documentation > > >=20 > > > Please, use 'git send-email' for sending patches. > > >=20 > > > Best regards > > >=20 > > > Heinrich > > >=20 > > > > --- > > > > =A0 doc/build/tools.rst | 22 ++++++++++++++-------- > > > > =A0 1 file changed, 14 insertions(+), 8 deletions(-) > > > >=20 > > > > diff --git a/doc/build/tools.rst b/doc/build/tools.rst > > > > index c06f915274..5f8a04a31b 100644 > > > > --- a/doc/build/tools.rst > > > > +++ b/doc/build/tools.rst > > > > @@ -24,14 +24,20 @@ you can use MSYS2, a software distro and buildi= ng > > > > platform for Windows. > > > > =A0 Download the MSYS2 installer from https://www.msys2.org. Make s= ure > > > > you have > > > > =A0 installed all required packages below in order to build these h= ost > > > > tools:: > > > >=20 > > > > -=A0=A0 * gcc (9.1.0) > > > > -=A0=A0 * make (4.2.1) > > > > -=A0=A0 * bison (3.4.2) > > > > -=A0=A0 * diffutils (3.7) > > > > -=A0=A0 * openssl-devel (1.1.1.d) > > > > - > > > > -Note the version numbers in these parentheses above are the package > > > > versions > > > > -at the time being when writing this document. The MSYS2 installer > > > > tested is > > > > +=A0=A0 * gcc > > > > +=A0=A0 * make > > > > +=A0=A0 * bison > > > > +=A0=A0 * diffutils > > > > +=A0=A0 * openssl-devel > > > > +=A0=A0 * flex > > > > +=A0=A0 * libgnutls-devel > > > > +=A0=A0 * libuuid-devel > >=20 > > This should not be pre-formatted text but simply a list. > >=20 > > > > + > > > > +You probably want ``git`` as well.=A0 You can install all these wi= th:: > >=20 > > Allow for syntax highlighting: > >=20 > > .. code-block:: bash > >=20 > > > > + > > > > +=A0=A0=A0 $ pacman -S gcc make bison diffutils openssl-devel flex > > > > libgnutls-devel libuuid-devel git > >=20 > > The line should be limited to 80 characters. Use \. > > Please, remove the leading $. > >=20 > > Best regards > >=20 > > Heinrich > >=20 > > > > + > > > > +The MSYS2 installer tested is > > > > =A0 http://repo.msys2.org/distrib/x86_64/msys2-x86_64-20190524.exe. >=20 > Do you really suggest to download a 3 year old version? It should be kept in-sync with what .azure-pipeline.yml does which is a newer version than that, yes. --=20 Tom --sd9do8a5kVlkH6z4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLhSHQACgkQFHw5/5Y0 tyyKugwAsalTHB2VgEV1poEbq31K30XNCyOGdXVTa8UlnFl/zZqm+gBroSgy7dbH OrF6XhQp9Nfutmgr3XwIC/TWeNg7UB4Mp2GIe5G/Zq1aIw4Xstn/XNuQKCtvaoyB MLa6n6DqbTGlZUzrrRVX4obRKk/D0Xvl94j5+p+mwdnv0GrrZXo3WdyUE2Jwx73Z mt+wrkWCYEwTpGr8dqhy+B9p84m2oPLS05/oaKjQuEcdD/wVL03cSfhC6C+6UKKy tuj+FiMy9pQaFivKN+o7uump5koBetKRYR5o62A2BKdUj3Q0b6dpuJ+mrPVOwSJZ nQDGo/joFrDxPCsVJVU9BuVHw60dK5MueMY4TA9GcJ6ThPL8mJoSeyrfQVgQxWIv 6guIId0h0XArOQRS23SQpgcuROuqi88eA6VpF2GVuP36XOcNSUPIGjdTCj7BfSa3 ae1AzltBiFeTIMH7RcrKV+VIghNNtRSHrLCI9u5zAaL7zSJ7JuQ5lRIaC2B6awUt RrZWvX4Z =T5gi -----END PGP SIGNATURE----- --sd9do8a5kVlkH6z4--