From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C728EC04A68 for ; Wed, 27 Jul 2022 19:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236892AbiG0TTf (ORCPT ); Wed, 27 Jul 2022 15:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238002AbiG0TTU (ORCPT ); Wed, 27 Jul 2022 15:19:20 -0400 Received: from mail.pr-group.ru (mail.pr-group.ru [178.18.215.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 307D14F663; Wed, 27 Jul 2022 12:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to: references; bh=a52mJhM1gg4pRCLX2QchY4yYs0Td4xCM9hQG7dTnPWc=; b=Bo6Vlb1aBj1EOmh8KUPkZyW2iZeA69lLQLzjQZlo152fYud67iqWd3Bwgt97TPQzx+0nbMntvI4/+ cEEPyYuz2LcyX/7zAYjgf2nE208mCyjJigtg6+gVMyf4yzLvCOuzFBxxOTUKBOZDvLZ9T63YQWKkbY PuTaBq7pxb0LAnzj0q+kg1stfbXaD7Xo2v0EDWBPYq46vX8cMTjjprx4xSKcNbvCmFSB5QLqAtH6oX Ml2Jn/E+w8VWq/LpZIt69VKXdP2XouTf5qi7RX/aL8r2lNrNsGET3d9CYv8F+fWzmIToESktsJm/la SsqMRG9zxfWX+FzBvNaaAPn3zMLe6+w== X-Kerio-Anti-Spam: Build: [Engines: 2.16.3.1424, Stamp: 3], Multi: [Enabled, t: (0.000008,0.009919)], BW: [Enabled, t: (0.000013,0.000001)], RTDA: [Enabled, t: (0.074415), Hit: No, Details: v2.41.0; Id: 15.52k3hs.1g90h4fac.fvmn; mclb], total: 0(700) X-Footer: bWV0cm90ZWsucnU= Received: from x260 ([85.93.58.13]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Wed, 27 Jul 2022 22:11:27 +0300 Date: Wed, 27 Jul 2022 21:46:43 +0300 From: Ivan Bornyakov To: Krzysztof Kozlowski Cc: Conor Dooley , Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix , Rob Herring , Krzysztof Kozlowski , linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: fpga: microchip,mpf-spi-fpga-mgr: use spi-peripheral-props.yaml Message-ID: <20220727184643.7bpsrxxrrpyqbwtx@x260> References: <20220727164347.386398-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220727164347.386398-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2022 at 06:43:47PM +0200, Krzysztof Kozlowski wrote: > Instead of listing directly properties typical for SPI peripherals, > reference the spi-peripheral-props.yaml schema. This allows using all > properties typical for SPI-connected devices, even these which device > bindings author did not tried yet. > > Remove the spi-* properties which now come via spi-peripheral-props.yaml > schema, except for the cases when device schema adds some constraints > like maximum frequency. > > While changing additionalProperties->unevaluatedProperties, put it in > typical place, just before example DTS. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Technically, this depends on [1] merged to SPI tree, if we want to > preserve existing behavior of not allowing SPI CPHA and CPOL in each of > schemas in this patch. > > If this patch comes independently via different tree, the SPI CPHA and > CPOL will be allowed for brief period of time, before [1] is merged. > This will not have negative impact, just DT schema checks will be > loosened for that period. > > [1] https://lore.kernel.org/all/20220722191539.90641-2-krzysztof.kozlowski@linaro.org/ > --- > .../bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml > index aee45cb15592..527532f039ce 100644 > --- a/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml > +++ b/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml > @@ -22,13 +22,14 @@ properties: > description: SPI chip select > maxItems: 1 > > - spi-max-frequency: true > - > required: > - compatible > - reg > > -additionalProperties: false > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > > examples: > - | > -- > 2.34.1 > Acked-by: Ivan Bornyakov