From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C084AC04A68 for ; Thu, 28 Jul 2022 02:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234905AbiG1Cvc (ORCPT ); Wed, 27 Jul 2022 22:51:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232484AbiG1Cvb (ORCPT ); Wed, 27 Jul 2022 22:51:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2486E52FCE for ; Wed, 27 Jul 2022 19:51:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0C8F61957 for ; Thu, 28 Jul 2022 02:51:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E011CC433C1; Thu, 28 Jul 2022 02:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658976690; bh=8CM6gHjjRz6JK5sh4S1FIuPuoM5wGf1lcREqsAHnRM4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZILHO+dH60xX6+clrPYwlaDqq8P8zBfnwP4s60sDq/0LZymV8v85E1HbVNc8hyysT UwztbZiA4IrUJB5jJI5qohC8n0kot7glNXj6e99SSmpCpSFwgijbVEfUm+Yb1txB0j J9RkdmfThRjCgrgsaojAKksm0X3q+6Q6Gtq8JzkETo6Em8GxVKuCDODoT31UFOnI+O CR4L2TrYLYJEnBimsy4QSML8109k4xX7uCUaB4A3S3mt5m39NbRnSmQ/mrjSeKX1p/ xFkvpqETau0GjZHqAOc7Q/6qiaHoaLjiU3gyJeAQyZpfUOOQgJo9EAzS4EGUvv+GA0 NVgWunEAWqGVw== Date: Wed, 27 Jul 2022 19:51:28 -0700 From: Jakub Kicinski To: Subbaraya Sundeep Cc: , , , , , Harman Kalra Subject: Re: [net v2 PATCH 2/5] octeontx2-af: suppress external profile loading warning Message-ID: <20220727195128.3a5b4297@kernel.org> In-Reply-To: <20220727194120.62af8ee7@kernel.org> References: <1658844682-12913-1-git-send-email-sbhatta@marvell.com> <1658844682-12913-3-git-send-email-sbhatta@marvell.com> <20220727194120.62af8ee7@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 27 Jul 2022 19:41:20 -0700 Jakub Kicinski wrote: > On Tue, 26 Jul 2022 19:41:19 +0530 Subbaraya Sundeep wrote: > > - if (!request_firmware(&fw, kpu_profile, rvu->dev)) { > > + if (!firmware_request_nowarn(&fw, kpu_profile, rvu->dev)) { > > Consider switching to request_firmware_direct() in net-next. > I doubt you need the sysfs fallback, I think udev dropped > the support for it. Well, the next patch needs work, so perhaps do it in v3?