On 28.07.2022 22:28:51, Vincent MAILHOL wrote:
> > > diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
> > > index 78a21ab63601..b1677588a4c8 100644
> > > --- a/drivers/net/can/mscan/mscan.c
> > > +++ b/drivers/net/can/mscan/mscan.c
> > > @@ -676,6 +676,7 @@ struct net_device *alloc_mscandev(void)
> > >       priv = netdev_priv(dev);
> > >
> > >       dev->netdev_ops = &mscan_netdev_ops;
> > > +     dev->ethtool_ops = &mscan_ethtool_ops;
> > >
> > >       dev->flags |= IFF_ECHO; /* we support local echo */
> >
> > | drivers/net/can/mscan/mscan.c: In function ‘alloc_mscandev’:
> > | drivers/net/can/mscan/mscan.c:679:29: error: ‘mscan_ethtool_ops’ undeclared (first use in this function)
> > |   679 |         dev->ethtool_ops = &mscan_ethtool_ops;
> > |       |                             ^~~~~~~~~~~~~~~~~
> > | drivers/net/can/mscan/mscan.c:679:29: note: each undeclared identifier is reported only once for each function it appears in
> >
> > I'm fixing this.
> 
> Thanks for catching this.

n.p.

> mscan does not show up in the menuconfig by default because it
> requires CONFIG_PPC. And it is not possible to add CONFIG_COMPILE_TEST
> to mscan's KBUILD file because some PPC specific symbols would be
> missing. So this is yet another pitfall.

:(

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |