From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E9D8C19F2B for ; Thu, 28 Jul 2022 22:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HrU4UxdAHPJJAosXA5fvMwpagO1gpguDDyhSyKPkN+o=; b=XBloB2mPvH7j9gDe5eKyRxa7rS rA/gWeERRhSaO2inEjcc3nP93bb1t9K17GN/MINSBQs0dF/hLcJyasTRoyFqnxE6hKvGU0UE6WK6b xeoXbYVD32z4MRV4D+4fHkhb5n7iAJlEEECyVJ/Bm5pixTUicEejTVIVqYTP4hsDD+UI922YXvvo1 AO2lsas1vE7rvOEYyL4VJdY/YylISlTSPhTZnf4B3uN1goTYNJTaJN6yZmuf7bmUH7gJ0EA58cJxz s5/bzjdl7CuguJsNGJPPbIRILZGCXn1jOZ/UPQd3x4XVKIi7hIJNBonNiW0yN2v3o1vvOVVVG/+P9 IvfFlxVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHBjy-00FI7V-6q; Thu, 28 Jul 2022 22:12:22 +0000 Received: from mx0b-00082601.pphosted.com ([67.231.153.30] helo=mx0a-00082601.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHBjj-00FI2R-BV for linux-nvme@lists.infradead.org; Thu, 28 Jul 2022 22:12:10 +0000 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.5/8.17.1.5) with ESMTP id 26SILoxD032703 for ; Thu, 28 Jul 2022 15:12:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=HrU4UxdAHPJJAosXA5fvMwpagO1gpguDDyhSyKPkN+o=; b=n8dWliq5IoapzMpZQOp43At9WoHS9cWL3gv8TLYNOdZWFclT3hCUNJw/xLFA+jEO5llQ 5yAmxUp8j7E212puNktcp2H/FBBXqmV38foAAhBFF4M/LDqjTteUJCGIQTofCTJafjSD G8w0VrQIIwwToui03x/d93SR4MBTgVgrrR8= Received: from mail.thefacebook.com ([163.114.132.120]) by m0001303.ppops.net (PPS) with ESMTPS id 3hkpemdmxb-8 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 28 Jul 2022 15:12:03 -0700 Received: from twshared25107.07.ash9.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c085:11d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 15:12:00 -0700 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id B144A6B202AE; Thu, 28 Jul 2022 15:11:52 -0700 (PDT) From: Keith Busch To: CC: , , Keith Busch Subject: [PATCH 3/5] nvme-pci: iod npages fits in s8 Date: Thu, 28 Jul 2022 15:11:49 -0700 Message-ID: <20220728221152.538648-4-kbusch@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220728221152.538648-1-kbusch@fb.com> References: <20220728221152.538648-1-kbusch@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: 8V63m4gPesr-1ikT9wMa0UpSUzobgU2y X-Proofpoint-GUID: 8V63m4gPesr-1ikT9wMa0UpSUzobgU2y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220728_151207_533209_6F561CA2 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Keith Busch The largest allowed transfer is 4MB, which can use at most 1025 PRPs. Each PRP is 8 bytes, so the maximum number of 4k nvme pages needed for the iod_list is 3, which fits in an 's8'. Signed-off-by: Keith Busch --- drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index a8ae043e33de..9e5bbf4e3e07 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -228,7 +228,7 @@ struct nvme_iod { struct nvme_command cmd; bool use_sgl; bool aborted; - int npages; /* In the PRP list. 0 means small pool in use */ + s8 npages; /* In the PRP list. 0 means small pool in use */ int nents; /* Used in scatterlist */ dma_addr_t first_dma; unsigned int dma_len; /* length of single DMA segment mapping */ --=20 2.30.2