From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Li zeming <zeming@nfschina.com>,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/net/act: Remove temporary state variables
Date: Fri, 29 Jul 2022 00:18:42 -0700 [thread overview]
Message-ID: <20220729001842.5bc9f0b2@kernel.org> (raw)
In-Reply-To: <YuOFd2oqA1Cbl+at@nanopsycho>
On Fri, 29 Jul 2022 09:00:07 +0200 Jiri Pirko wrote:
> >> What backports do you have in mind exactly?
> >
> >Code backports. I don't understand the question.
>
> Code backports of what where?
> Are you talking about:
> 1) mainline kernels
> 2) distrubutions kernels? Or even worse, in-house kernels of companies?
>
> If 2), I believe it is not relevant for the upstream discussion, at all.
Fixes and stable. Frankly it's just a generic justification
to discourage people from sending subjective code cleanups.
I'd never argue for the benefit of (2) :)
There's been a string of patches cleaning up return values
of functions in the last few days. If people have a lot of
time on their hands they should go do something useful, like
converting netdev features to a bitmap. Hell, go fix W=1 warnings,
even easier.
The time spent reviewing those "cleanups" adds up, and I suspect
there's hundreds of places they can be applied. Hence my question
about automation...
next prev parent reply other threads:[~2022-07-29 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 9:41 [PATCH] sched/net/act: Remove temporary state variables Li zeming
2022-07-29 3:15 ` Jakub Kicinski
2022-07-29 6:30 ` Jiri Pirko
2022-07-29 6:51 ` Jakub Kicinski
2022-07-29 7:00 ` Jiri Pirko
2022-07-29 7:18 ` Jakub Kicinski [this message]
2022-07-29 8:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729001842.5bc9f0b2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.