From: "Michael S. Tsirkin" <mst@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Jason Wang" <jasowang@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marcel Apfelbaum" <marcel@redhat.com>
Subject: Re: virtio: why no full reset on virtio_set_status 0 ?
Date: Fri, 29 Jul 2022 06:13:22 -0400 [thread overview]
Message-ID: <20220729061221-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <be4dc741-4153-1620-223f-852ff5aa34a7@suse.de>
On Fri, Jul 29, 2022 at 11:46:05AM +0200, Claudio Fontana wrote:
> >> @@ -2025,7 +2031,6 @@ void virtio_reset(void *opaque)
> >> VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev);
> >> int i;
> >>
> >> - virtio_set_status(vdev, 0);
> >> if (current_cpu) {
> >> /* Guest initiated reset */
> >> vdev->device_endian = virtio_current_cpu_endian();
> >> --
> >> 2.26.2
> >
> > As you say this is incomplete ... bout could you share a bit more
> > of what issue does this address?
> >
>
> Hi, the problem I am trying to address is a segfault in OVS/dpdk that looks like this:
Sorry I was not clear. What I mean is, you don't yet know why does removing
virtio_set_status call here prevent the crash in ovs, do you?
--
MST
next prev parent reply other threads:[~2022-07-29 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 10:51 virtio: why no full reset on virtio_set_status 0 ? Claudio Fontana
2022-07-27 15:32 ` Michael S. Tsirkin
2022-07-28 1:27 ` Jason Wang
2022-07-28 7:16 ` Claudio Fontana
2022-07-28 7:43 ` Claudio Fontana
2022-07-28 9:09 ` Claudio Fontana
2022-07-28 10:24 ` Cornelia Huck
2022-07-31 20:38 ` Claudio Fontana
2022-07-28 13:39 ` Michael S. Tsirkin
2022-07-29 9:46 ` Claudio Fontana
2022-07-29 10:13 ` Michael S. Tsirkin [this message]
2022-07-29 10:19 ` Claudio Fontana
2022-07-29 13:21 ` Alex Bennée
2022-07-29 14:00 ` Claudio Fontana
2022-07-31 20:42 ` Claudio Fontana
2022-08-01 8:44 ` Alex Bennée
2022-07-28 11:41 ` Michael S. Tsirkin
2022-07-27 16:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729061221-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=jasowang@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.