All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Ning <zhuning0077@gmail.com>
To: pierre-louis.bossart@linux.intel.com
Cc: alsa-devel@alsa-project.org, zhuning0077@gmail.com,
	tiwai@suse.com, 20220727152203.GA2681685-robh@kernel.org,
	broonie@kernel.org, zhuning@everest-semi.com,
	yangxiaohua@everest-semi.com
Subject: Subject: Re: [PATCH v3 2/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC
Date: Fri, 29 Jul 2022 15:27:21 +0800	[thread overview]
Message-ID: <20220729072720.420184-1-zhuning0077@gmail.com> (raw)
In-Reply-To: <20220727152203.GA2681685-robh@kernel.org>

>> +  everest,jack-detect-inverted:
>> +    description:
>> +      Defined to invert the jack detection.
>
>What's the difference with this and bit 3 of everest,jack-pol?
>
>We already have numerous vendor properties for jack detect. Can we come 
>up with something common?
>
>The problem with 'inverted' is it assumes you know the non-inverted 
>state. Better to just state high or low.

This property is in compatible with the property in es8316.c and sof_essx8336.c.
(which is not documented in es8316.yaml, another problem)
There is a quirk in sof_essx8336.c so that when the user find they're having a 
wrong jack insert configuration, they can set the quirk to invert it.

                 reply	other threads:[~2022-07-29  7:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220729072720.420184-1-zhuning0077@gmail.com \
    --to=zhuning0077@gmail.com \
    --cc=20220727152203.GA2681685-robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yangxiaohua@everest-semi.com \
    --cc=zhuning@everest-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.