From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0DDC19F2B for ; Fri, 29 Jul 2022 07:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234871AbiG2HoF (ORCPT ); Fri, 29 Jul 2022 03:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234154AbiG2HoD (ORCPT ); Fri, 29 Jul 2022 03:44:03 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1928665666 for ; Fri, 29 Jul 2022 00:44:02 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id jx17-20020a17090b46d100b001f33b230098so260305pjb.7 for ; Fri, 29 Jul 2022 00:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=1Wg9cHm2UMgNHmJrbWYqWjDLkwNy+fZSAbVTsV+UQns=; b=imxY0j49nHkgRuVEtqcu1lSRSM5vwuyb3SjeUn8WrBKKWgIK3aBc/DJkUn0uVgqwOh Ej0opAKoYwLjSbESFDo0kegDOw4cDV0ByjwDcaEb6ChpE7xPt2dRxOjNZCN74daQ6OTF 8t37Vx+QadrW8tIzFFrrZG7lRomzlJ7cQsjdFeQmXPwnlSXdqoqJvbhVyX31Qa8Ybn4v V10uDxd0aNexsoDvQTOuXWxJ4ZGA2aQjrkkDzW+9zzNx6B3m4wqlza2fBJIMKZIGfXxq CPmT9NEsvcORRgNR4d0aIXB0JJN5C9i+yR1gseWIHqK6ALt4WvQy++imDh4cGjVOu6vQ QdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=1Wg9cHm2UMgNHmJrbWYqWjDLkwNy+fZSAbVTsV+UQns=; b=HZSdZUy/PYdajux/rVgi3QOg7V1Pj4oGYx131OjHj1H9s7uK4IYNBAA/V70B0XLhK/ tnuKmsjoD7atIrT41wB+JNN6Ta58mXrDfFFCUgeC9dESXv0W88cx2zzlbDn73+x7nDwA AX4Uchfz9OPTZ54RXe0acV3EGpcU2vTXX9FJTB3Ci1ypXt+kQzsuNt2UuHCEAN+6O6Go 8t3sIS6/MSQTIeUDZRBBM8u5MpVox4i7/zpfH3IsYillB2IUZM3tlxhSPL/YxXxr05pu OQdVq4w6tLAy5rPYzBOul0QU9fOBzsv9uo27ME/q429olgg00TJO87yh9bdZYQDky2G1 jNYw== X-Gm-Message-State: AJIora88vSdjIXooz2KzZy18FUwRt82KQIJ0NjG82q7qv44ovdEfkgZX wmCxtpGuNsQXbDlU2hGFz3h5KGCEIUUB X-Google-Smtp-Source: AGRyM1s5Kyemr2tcw/wnsGgnx2UTjqJzLMWlkCo84p8rnvtDM0dFBbz53/1DqEA7btgqXB4XxzCpKr2k1GtG X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:524b:47b4:2aeb:1b49]) (user=irogers job=sendgmr) by 2002:a05:6a00:1ac7:b0:52b:37ac:442c with SMTP id f7-20020a056a001ac700b0052b37ac442cmr2234362pfv.76.1659080641572; Fri, 29 Jul 2022 00:44:01 -0700 (PDT) Date: Fri, 29 Jul 2022 00:43:34 -0700 Message-Id: <20220729074351.138260-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.455.g008518b4e5-goog Subject: [PATCH v3 00/17] Compress the pmu_event tables From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org jevents.py creates a number of large arrays from the json events. The arrays contain pointers to strings that need relocating. The relocations have file size, run time and memory costs. These changes refactor the pmu_events API so that the storage of the pmu_event struct isn't exposed. The format is then changed to an offset within a combined big string, with adjacent pmu_event struct variables being next to each other in the string separated by \0 - meaning only the first variable of the struct needs its offset recording. Some related fixes are contained with the patches. The architecture jevents.py creates tables for can now be set by the JEVENTS_ARCH make variable, with a new 'all' that generates the events and metrics for all architectures. An example of the improvement to the file size on x86 is: no jevents - the same 19,788,464bytes x86 jevents - ~16.7% file size saving 23,744,288bytes vs 28,502,632bytes all jevents - ~19.5% file size saving 24,469,056bytes vs 30,379,920bytes default build options plus NO_LIBBFD=1. I originally suggested fixing this problem in: https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/ v3. Fix an ARM build issue with a missed weak symbol. Perform some pytype clean up. v2. Split the substring folding optimization to its own patch and comment tweaks as suggested by Namhyung Kim . Recompute the file size savings with the latest json events and metrics. Ian Rogers (17): perf jevents: Clean up pytype warnings perf jevents: Simplify generation of C-string perf jevents: Add JEVENTS_ARCH make option perf jevent: Add an 'all' architecture argument perf jevents: Remove the type/version variables perf jevents: Provide path to json file on error perf jevents: Sort json files entries perf pmu-events: Hide pmu_sys_event_tables perf pmu-events: Avoid passing pmu_events_map perf pmu-events: Hide pmu_events_map perf test: Use full metric resolution perf pmu-events: Move test events/metrics to json perf pmu-events: Don't assume pmu_event is an array perf pmu-events: Hide the pmu_events perf metrics: Copy entire pmu_event in find metric perf jevents: Compress the pmu_events_table perf jevents: Fold strings optimization tools/perf/arch/arm64/util/pmu.c | 4 +- tools/perf/pmu-events/Build | 6 +- .../arch/test/test_soc/cpu/metrics.json | 64 +++ tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++- tools/perf/pmu-events/jevents.py | 495 ++++++++++++++---- tools/perf/pmu-events/pmu-events.h | 40 +- tools/perf/tests/expand-cgroup.c | 25 +- tools/perf/tests/parse-metric.c | 77 +-- tools/perf/tests/pmu-events.c | 466 +++++++---------- tools/perf/util/metricgroup.c | 275 ++++++---- tools/perf/util/metricgroup.h | 5 +- tools/perf/util/pmu.c | 139 ++--- tools/perf/util/pmu.h | 8 +- tools/perf/util/s390-sample-raw.c | 50 +- 14 files changed, 1140 insertions(+), 718 deletions(-) create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json -- 2.37.1.455.g008518b4e5-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBBE1C00144 for ; Fri, 29 Jul 2022 07:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=MRp6ElSmzlrE8/7t6T82QfqCLatuUMIRFt3+VXbjvfM=; b=nb5 bpZRwORJGTNcR+DwamNYvsL1BWZ5m7ao7YUmAYHLInSQNtvmCdMjUaXmG+rj5eG3ekfn+Cw1tfSfJ yTCAdMtrY3ujouq9FxA3GCDMLKW28ETTCpAMiwRQg3wzMvektIliEImds/PKS+JDzGOfq/wE9AdoZ 2d0f+yzhdDjfIyCtOkK4o2zWPwxuPxMw6ytJBwKHPqGjnmVmeLFgN2DtpMIOUdEZhwOmogW1cwOTX Py5h1ozA1iHu71YRMnydn+JlAA4c0nkmTldEOqogeM0hXHbMKnOO5l3G2gp5kicl0tYGfynWOjJUz vbBrepSdEUx/XZsAN8LhtvUsOhKn8MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHKfH-002j0D-EI; Fri, 29 Jul 2022 07:44:07 +0000 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHKfE-002iwW-6r for linux-arm-kernel@lists.infradead.org; Fri, 29 Jul 2022 07:44:05 +0000 Received: by mail-pj1-x1049.google.com with SMTP id o6-20020a17090ab88600b001f30b8c11c5so3830912pjr.2 for ; Fri, 29 Jul 2022 00:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=1Wg9cHm2UMgNHmJrbWYqWjDLkwNy+fZSAbVTsV+UQns=; b=imxY0j49nHkgRuVEtqcu1lSRSM5vwuyb3SjeUn8WrBKKWgIK3aBc/DJkUn0uVgqwOh Ej0opAKoYwLjSbESFDo0kegDOw4cDV0ByjwDcaEb6ChpE7xPt2dRxOjNZCN74daQ6OTF 8t37Vx+QadrW8tIzFFrrZG7lRomzlJ7cQsjdFeQmXPwnlSXdqoqJvbhVyX31Qa8Ybn4v V10uDxd0aNexsoDvQTOuXWxJ4ZGA2aQjrkkDzW+9zzNx6B3m4wqlza2fBJIMKZIGfXxq CPmT9NEsvcORRgNR4d0aIXB0JJN5C9i+yR1gseWIHqK6ALt4WvQy++imDh4cGjVOu6vQ QdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=1Wg9cHm2UMgNHmJrbWYqWjDLkwNy+fZSAbVTsV+UQns=; b=xIKEspBDITpPc5w6TzcQalpgvyYDaXWQQ1SKQtOKJDmWF0xWBnbomQvx+PdL9qTrws 0v+idNxydsXx2eJzEffx53PaaB2QKy9sWKlvu+SzT/KMEfO9keqh9duf04Sq2Q/PQ5wa qaazmj3kOgnnkr5jiH6fbuxRg8tX5SVcCfd5K12lbd+a1tpXxatwi+3bTFTRlsf8CkFj WobJLCm7Ly7QTNhl5Kpvk/aI1LOq4Zt/rqV11Wb/YLzCHj7ZCbkCISO2Dv64TxTfbI5U PeD/+0KNvkEJqHSDPuFWFx1+AC5RtZTCIMBwtAPshlgVPt5WuWsoxTa8ODv99aIQfB8P CGcw== X-Gm-Message-State: AJIora+sVMkTCxS8zV/PnrPQOXQLJtFcHCCs94ddsJTjFU4PhkSyDzfY MLE2YQMga72JVY061ObcMK0kvRqVnqL5 X-Google-Smtp-Source: AGRyM1s5Kyemr2tcw/wnsGgnx2UTjqJzLMWlkCo84p8rnvtDM0dFBbz53/1DqEA7btgqXB4XxzCpKr2k1GtG X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:524b:47b4:2aeb:1b49]) (user=irogers job=sendgmr) by 2002:a05:6a00:1ac7:b0:52b:37ac:442c with SMTP id f7-20020a056a001ac700b0052b37ac442cmr2234362pfv.76.1659080641572; Fri, 29 Jul 2022 00:44:01 -0700 (PDT) Date: Fri, 29 Jul 2022 00:43:34 -0700 Message-Id: <20220729074351.138260-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.455.g008518b4e5-goog Subject: [PATCH v3 00/17] Compress the pmu_event tables From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian , Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_004404_297959_C9E9DFEE X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org jevents.py creates a number of large arrays from the json events. The arrays contain pointers to strings that need relocating. The relocations have file size, run time and memory costs. These changes refactor the pmu_events API so that the storage of the pmu_event struct isn't exposed. The format is then changed to an offset within a combined big string, with adjacent pmu_event struct variables being next to each other in the string separated by \0 - meaning only the first variable of the struct needs its offset recording. Some related fixes are contained with the patches. The architecture jevents.py creates tables for can now be set by the JEVENTS_ARCH make variable, with a new 'all' that generates the events and metrics for all architectures. An example of the improvement to the file size on x86 is: no jevents - the same 19,788,464bytes x86 jevents - ~16.7% file size saving 23,744,288bytes vs 28,502,632bytes all jevents - ~19.5% file size saving 24,469,056bytes vs 30,379,920bytes default build options plus NO_LIBBFD=1. I originally suggested fixing this problem in: https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/ v3. Fix an ARM build issue with a missed weak symbol. Perform some pytype clean up. v2. Split the substring folding optimization to its own patch and comment tweaks as suggested by Namhyung Kim . Recompute the file size savings with the latest json events and metrics. Ian Rogers (17): perf jevents: Clean up pytype warnings perf jevents: Simplify generation of C-string perf jevents: Add JEVENTS_ARCH make option perf jevent: Add an 'all' architecture argument perf jevents: Remove the type/version variables perf jevents: Provide path to json file on error perf jevents: Sort json files entries perf pmu-events: Hide pmu_sys_event_tables perf pmu-events: Avoid passing pmu_events_map perf pmu-events: Hide pmu_events_map perf test: Use full metric resolution perf pmu-events: Move test events/metrics to json perf pmu-events: Don't assume pmu_event is an array perf pmu-events: Hide the pmu_events perf metrics: Copy entire pmu_event in find metric perf jevents: Compress the pmu_events_table perf jevents: Fold strings optimization tools/perf/arch/arm64/util/pmu.c | 4 +- tools/perf/pmu-events/Build | 6 +- .../arch/test/test_soc/cpu/metrics.json | 64 +++ tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++- tools/perf/pmu-events/jevents.py | 495 ++++++++++++++---- tools/perf/pmu-events/pmu-events.h | 40 +- tools/perf/tests/expand-cgroup.c | 25 +- tools/perf/tests/parse-metric.c | 77 +-- tools/perf/tests/pmu-events.c | 466 +++++++---------- tools/perf/util/metricgroup.c | 275 ++++++---- tools/perf/util/metricgroup.h | 5 +- tools/perf/util/pmu.c | 139 ++--- tools/perf/util/pmu.h | 8 +- tools/perf/util/s390-sample-raw.c | 50 +- 14 files changed, 1140 insertions(+), 718 deletions(-) create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json -- 2.37.1.455.g008518b4e5-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel