From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Taylor Simpson <tsimpson@quicinc.com>
Subject: [PULL 6/6] configure: pass correct cflags to container-based cross compilers
Date: Fri, 29 Jul 2022 17:04:38 +0200 [thread overview]
Message-ID: <20220729150438.20293-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20220729150438.20293-1-pbonzini@redhat.com>
probe_target_compiler returns nonempty $target_cc for installed toolchains
and $container_cross_cc for container-based toolchains. In both cases
however the flags (coming from $cross_cc_cflags_${target_arch}) must be
in $target_cflags.
Therefore, do not clear them prior to returning from probe_target_compiler.
Reported-by: Taylor Simpson <tsimpson@quicinc.com>
Fixes: 92e288fcfb ("build: try both native and cross compilers", 2022-07-08)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure b/configure
index c4c02b8438..72ab03f11a 100755
--- a/configure
+++ b/configure
@@ -2173,7 +2173,6 @@ probe_target_compiler() {
build_static=
target_cc=
target_ccas=
- target_cflags=
target_ar=
target_as=
target_ld=
--
2.36.1
next prev parent reply other threads:[~2022-07-29 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 15:04 [PULL 0/6] Fixes for QEMU 7.1-rc1 Paolo Bonzini
2022-07-29 15:04 ` [PULL 1/6] ui: dbus-display requires CONFIG_GBM Paolo Bonzini
2022-07-29 15:04 ` [PULL 2/6] vga: fix incorrect line height in 640x200x2 mode Paolo Bonzini
2022-07-29 15:04 ` [PULL 3/6] stubs: update replay-tools to match replay.h types Paolo Bonzini
2022-07-29 15:04 ` [PULL 4/6] configure: Fix ppc container_cross_cc substitution Paolo Bonzini
2022-07-29 15:04 ` [PULL 5/6] kvm: don't use perror() without useful errno Paolo Bonzini
2022-07-29 15:04 ` Paolo Bonzini [this message]
2022-07-29 17:30 ` [PULL 0/6] Fixes for QEMU 7.1-rc1 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729150438.20293-7-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.