From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V4 0/4] ublk_drv: add generic mechanism to get/set parameters
Date: Sat, 30 Jul 2022 17:27:46 +0800 [thread overview]
Message-ID: <20220730092750.1118167-1-ming.lei@redhat.com> (raw)
Hello Jens,
The 1st two patches fixes ublk device leak or hang issue in case of some
failure path, such as, failing to start device.
The 3rd patch adds two control commands for setting/getting device
parameters in generic way, and easy to extend to add new parameter
type.
The 4th patch cleans UAPI of ublksrv_ctrl_dev_info, and userspace needs
to be updated for this driver change, so please consider this patchset
for v5.20.
Verified by all targets in the following branch, and pass all built-in
tests.
https://github.com/ming1/ubdsrv/tree/parameter_out
Also all device data including parameters is exported as json in
above tree.
V4:
- take Christoph's suggestion to put all parameters into one single
structure.
- move reserved fields of ublksrv_ctrl_dev_info into end
V3:
- drop device reference after add_disk fails, as suggested by Christoph, 1/5
- simplify the 3rd patch: replace xarray with plain array, remove
function table and avoid indirect call, then reduce boiler plate for
addressing Christoph's comment
V2:
- re-organize patches
- limit parameter max length
- take Christoph's approach to replace bitfields with flags, and use
char type to define block size shift
- add two fixes, which is triggered when testing set/get parameter
commands
- cleanup uapi header
Ming Lei (4):
ublk_drv: cancel device even though disk isn't up
ublk_drv: fix ublk device leak in case that add_disk fails
ublk_drv: add SET_PARAMS/GET_PARAMS control command
ublk_drv: cleanup ublksrv_ctrl_dev_info
drivers/block/ublk_drv.c | 242 +++++++++++++++++++++++++++++-----
include/uapi/linux/ublk_cmd.h | 62 ++++++++-
2 files changed, 264 insertions(+), 40 deletions(-)
--
2.31.1
next reply other threads:[~2022-07-30 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 9:27 Ming Lei [this message]
2022-07-30 9:27 ` [PATCH V4 1/4] ublk_drv: cancel device even though disk isn't up Ming Lei
2022-07-30 9:27 ` [PATCH V4 2/4] ublk_drv: fix ublk device leak in case that add_disk fails Ming Lei
2022-07-30 9:27 ` [PATCH V4 3/4] ublk_drv: add SET_PARAMS/GET_PARAMS control command Ming Lei
2022-07-30 9:27 ` [PATCH V4 4/4] ublk_drv: cleanup ublksrv_ctrl_dev_info Ming Lei
2022-07-30 15:04 ` [PATCH V4 0/4] ublk_drv: add generic mechanism to get/set parameters Jens Axboe
2022-08-01 2:13 ` Ming Lei
2022-07-30 15:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220730092750.1118167-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=ZiyangZhang@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.