All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <foss+uboot@0leil.net>
Cc: bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com,
	sjg@chromium.org, philipp.tomsich@vrull.eu,
	kever.yang@rock-chips.com, jagan@amarulasolutions.com,
	alpernebiyasak@gmail.com, xypron.glpk@gmx.de,
	heiko.thiery@gmail.com, u-boot@lists.denx.de,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Quentin Schulz <foss+uboot@0leil.net>
Subject: [PATCH v3 6/8] rockchip: simplify binman image dependencies addition to INPUTS
Date: Mon,  1 Aug 2022 18:06:08 +0200	[thread overview]
Message-ID: <20220801160610.2330151-7-foss+uboot@0leil.net> (raw)
In-Reply-To: <20220801160610.2330151-1-foss+uboot@0leil.net>

From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

By factoring SPL check in the first condition, this makes the checks a
bit less convoluted and more readable.

Cc: Quentin Schulz <foss+uboot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 Makefile | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index f8e919e136..640d4b8f65 100644
--- a/Makefile
+++ b/Makefile
@@ -995,19 +995,14 @@ ifeq ($(CONFIG_MPC85xx)$(CONFIG_OF_SEPARATE),yy)
 INPUTS-y += u-boot-with-dtb.bin
 endif
 
-ifeq ($(CONFIG_ARCH_ROCKCHIP),y)
-# On ARM64 this target is produced by binman so we don't need this dep
+ifeq ($(CONFIG_ARCH_ROCKCHIP)$(CONFIG_SPL),yy)
+# Binman image dependencies
 ifeq ($(CONFIG_ARM64),y)
-ifeq ($(CONFIG_SPL),y)
 INPUTS-y += u-boot.itb
 endif
 else
-ifeq ($(CONFIG_SPL),y)
-# Generate these inputs for binman which will create the output files
 INPUTS-y += u-boot.img
 endif
-endif
-endif
 
 INPUTS-$(CONFIG_X86) += u-boot-x86-start16.bin u-boot-x86-reset16.bin \
 	$(if $(CONFIG_SPL_X86_16BIT_INIT),spl/u-boot-spl.bin) \
-- 
2.37.1


  parent reply	other threads:[~2022-08-01 16:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 16:06 [PATCH v3 0/8] migrate u-boot-rockchip.bin to binman and generate an image for SPI Quentin Schulz
2022-08-01 16:06 ` [PATCH v3 1/8] binman: add support for skipping file concatenation for mkimage Quentin Schulz
2022-08-01 16:06 ` [PATCH v3 2/8] binman: allow user-defined filenames for mkimage entry Quentin Schulz
2022-08-01 19:13   ` Simon Glass
2022-08-01 16:06 ` [PATCH v3 3/8] rockchip: remove binman temporary files when cleaning Quentin Schulz
2022-08-01 18:59   ` Johan Jonker
2022-08-01 19:13     ` Simon Glass
2022-08-01 16:06 ` [PATCH v3 4/8] rockchip: generate idbloader.img content for u-boot-rockchip.bin with binman for ARM Quentin Schulz
2022-08-01 19:13   ` Simon Glass
2022-08-01 16:06 ` [PATCH v3 5/8] rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards Quentin Schulz
2022-08-01 19:13   ` Simon Glass
2022-08-01 16:06 ` Quentin Schulz [this message]
2022-08-01 16:24   ` [PATCH v3 6/8] rockchip: simplify binman image dependencies addition to INPUTS Quentin Schulz
2022-08-01 16:06 ` [PATCH v3 7/8] rockchip: allow to build SPI images even without HAS_ROM option Quentin Schulz
2022-08-01 16:06 ` [PATCH v3 8/8] rockchip: add u-boot-rockchip-spi.bin image for booting from SPI-NOR flash Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801160610.2330151-7-foss+uboot@0leil.net \
    --to=foss+uboot@0leil.net \
    --cc=alpernebiyasak@gmail.com \
    --cc=bharat.gooty@broadcom.com \
    --cc=heiko.thiery@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=rayagonda.kokatanur@broadcom.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.