From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8AAC00144 for ; Mon, 1 Aug 2022 17:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233956AbiHAR6l (ORCPT ); Mon, 1 Aug 2022 13:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233721AbiHAR6F (ORCPT ); Mon, 1 Aug 2022 13:58:05 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1914A2980E for ; Mon, 1 Aug 2022 10:57:49 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 27E2768AA6; Mon, 1 Aug 2022 19:57:45 +0200 (CEST) Date: Mon, 1 Aug 2022 19:57:44 +0200 From: Christoph Hellwig To: yf.wang@mediatek.com Cc: Christoph Hellwig , Robin Murphy , Marek Szyprowski , Matthias Brugger , "open list:DMA MAPPING HELPERS" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , wsd_upstream@mediatek.com, Libo Kang , Ning Li , Yong Wu , Miles Chen , jianjiao zeng Subject: Re: [PATCH] dma-debug: Fix overflow issue in bucket_find_contain Message-ID: <20220801175744.GA17256@lst.de> References: <20220730114146.32669-1-yf.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220730114146.32669-1-yf.wang@mediatek.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + unsigned int shift = (1 << HASH_FN_SHIFT); Please just add a constant for that right nxt to the HASH_FN_SHIFT definition. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95806C00144 for ; Mon, 1 Aug 2022 17:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=efMCRCNTRmh0WfFDIh1ZZPsZ/USh7qvWujVLKvZY4S4=; b=i4xpruvjgJXqRk ZehEAAhJkz/6krbGsXH4alS8f3WMOTm0xHHaJlyTBpYB2ACN+IFlby76fEPeb/COjfspRd3QHm21T l0iQDlp85uoMVi3zeuo0tIEZBMx+QfLZqzy7fq78dA4vcO7D+xRaO9kW5ftsooCudcJLS2PISViOc UQJizwmyUGHJnXVhgGJ4+xDn2T1jU0slVfZqH3DDw8YedM7Bp6F79cZdOHSNCTn5+e6cZjhNJZK4+ GF7QIrkBT+ekCFkYmFI2UJfZZ8Sz1Ktc5fK1dekobJJAbqOJTO2T5fzOBx61C1hVRdwHfTeqqJdJQ SYOYCTE8LhypI6tbyQNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIZfu-008Rsh-89; Mon, 01 Aug 2022 17:57:54 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIZfq-008Rn9-La; Mon, 01 Aug 2022 17:57:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 27E2768AA6; Mon, 1 Aug 2022 19:57:45 +0200 (CEST) Date: Mon, 1 Aug 2022 19:57:44 +0200 From: Christoph Hellwig To: yf.wang@mediatek.com Cc: Christoph Hellwig , Robin Murphy , Marek Szyprowski , Matthias Brugger , "open list:DMA MAPPING HELPERS" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , wsd_upstream@mediatek.com, Libo Kang , Ning Li , Yong Wu , Miles Chen , jianjiao zeng Subject: Re: [PATCH] dma-debug: Fix overflow issue in bucket_find_contain Message-ID: <20220801175744.GA17256@lst.de> References: <20220730114146.32669-1-yf.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220730114146.32669-1-yf.wang@mediatek.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_105751_055180_3307A8D3 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + unsigned int shift = (1 << HASH_FN_SHIFT); Please just add a constant for that right nxt to the HASH_FN_SHIFT definition. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel