From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E70DFC19F2C for ; Mon, 1 Aug 2022 19:39:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7868F83E4C; Mon, 1 Aug 2022 21:39:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ZeQsb1FK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 527E983F8E; Mon, 1 Aug 2022 21:39:09 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F28738300F for ; Mon, 1 Aug 2022 21:39:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7CE05B81603; Mon, 1 Aug 2022 19:39:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C385C433D6; Mon, 1 Aug 2022 19:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659382744; bh=i1FmhzmWSrJ8ZMn8u0mlT4lznpyROM77O5VFfEm8osw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZeQsb1FKz1noYIthXvnewUpG0eASmJnDmPWh9dY0iQAt7CNg5hAdS2pj4MdEZ7Vyw E1WV9+YUsrOhD6kfPHi55RZ9TXJRH1UZg+URcVIFW1T4Vmaezo17t0bOxMVve//sZ/ vc7TJXDMhlpIMNubSlQY0dL/KnEDS8WoPI7ilDAQkIwspV2aJPT9lAY0p8dBJIy7aS oxUCnyRhnOlTG+riYe2temR5cVfpxs/1QYM30E8NOFjrbh5h8+GzOMUi/a2LJEGgya BBhqkyjPQwAV/ICCRyOPd8/qwHqo7U7b5czFmrevzxQqutDURRwC9SIiqcTRMoSqSM 8AfkX0DMWeGLw== Received: by pali.im (Postfix) id C989375F; Mon, 1 Aug 2022 21:39:00 +0200 (CEST) Date: Mon, 1 Aug 2022 21:39:00 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Tom Rini , U-Boot Mailing List Subject: Re: [PATCH 2/2] Makefile: Build final mpc85xx non-SPL image in standard file u-boot.bin Message-ID: <20220801193900.zpbunhwopisefjjh@pali> References: <20220801154220.20068-1-pali@kernel.org> <20220801154220.20068-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Monday 01 August 2022 13:13:22 Simon Glass wrote: > Hi Pali, > > On Mon, 1 Aug 2022 at 09:43, Pali Rohár wrote: > > > > Currently Makefile produces final mpc85xx image when SPL is not used in > > custom file u-boot-with-dtb.bin. It is quite confusing name as build > > process produce also intermediate file standard file u-boot-dtb.bin (which > > is just intermediate and not bootable). Other platforms use u-boot.bin > > (UBOOT_BIN) as standard name for final bootable raw image. > > > > So change Makefile rules and binman to produce final bootable file for > > mpc85xx also into file u-boot.bin. There is just need for mpc85xx to not > > define default rule for u-boot.bin then instruct binman (via DTS file) to > > store final image into u-boot.bin (instead of u-boot-with-dtb.bin) and > > finally rename target u-boot-with-dtb.bin to u-boot.bin. > > > > With this change are also removed custom Makefile hacks for mpc85xx that it > > produced non-standard output file. And also updated documentation. > > > > Signed-off-by: Pali Rohár > > --- > > Makefile | 19 +++++-------------- > > arch/powerpc/dts/kmcent2-u-boot.dtsi | 2 +- > > arch/powerpc/dts/u-boot.dtsi | 2 +- > > board/freescale/p1_p2_rdb_pc/README | 2 +- > > board/freescale/p2041rdb/README | 3 --- > > board/freescale/t102xrdb/README | 2 +- > > board/freescale/t104xrdb/README | 2 +- > > board/freescale/t208xqds/README | 2 +- > > board/freescale/t208xrdb/README | 2 +- > > 9 files changed, 12 insertions(+), 24 deletions(-) > > At present u-boot.bin has a very standard meaning - it is U-Boot with the DT. > > Boards which need something more than that can/should use binman to > create a separate file. > > I certainly agree that u-boot-with-dtb.bin is a terrible name, though. > Something more descriptive would be better. > > But is it possible to drop these SoC-specific rules in the Makefile > and just build everything needed in the standard binman rule in the > Makefile? > > Regards, > Simon I do not know what is binman doing and how to use it. I just do not see reason why it is needed to use such additional tool for building final binary for powerpc/mpc85xx as other arm boards do not use it at all. Ad your comment "At present u-boot.bin has a very standard meaning - it is U-Boot with the DT." - This is exactly what binman for mpc85xx produces. So I see there could be improvements, but as a first step this my patch should be enough?