From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABB82C00144 for ; Mon, 1 Aug 2022 23:15:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 30C47810E8; Tue, 2 Aug 2022 01:15:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Wg1vkom6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 531CE83C51; Tue, 2 Aug 2022 01:15:53 +0200 (CEST) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D72D180CF3 for ; Tue, 2 Aug 2022 01:15:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id h8so8529828qvs.6 for ; Mon, 01 Aug 2022 16:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G2CimmMY5+/BvWzY20IdgLssbF4I9xhBhXs2kS9hYoI=; b=Wg1vkom6VCA+Ury+AKNEw2CiY5DQkuKSqGjPW0WRxKX3dLE+G3YTSYG34yxE8jyXpN vxqqaxyL85dHa9P60qwyatDWZ9CGPiyX0XH129UpqGTo9tISemIAU9Wcngq0PFQ7FjLr 7FPiJlQYUqicf4pX8uxmfUqbmP9PVxp1mxkzI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G2CimmMY5+/BvWzY20IdgLssbF4I9xhBhXs2kS9hYoI=; b=rKhZtytCJZnvLgpMuqd2ZYPLLtGyNXiPhT3Co7fLsBHriazwBcBtmJeKNfmd29FSUl Ytd0itAqmTmdSdqtXDlEWSBN82epAUk4xJnU70+pCVXNlFPoY3wy1KuNVEJFSBL0FVZz 79FZjh7ETnD8XKazN4PehVquppf2k/2rXJDyhDl8UzyW7DmG4grSUMfL0QvnpOwFV+S6 FKVJVXxPOzwKFiDmiaXaTIw7qex75+f5kzQThw2WBbmrU5RHnaT6n06LDfdvKLtUXUUs hGtwFJD3nBVq2tcL6J1KEC9CUoTroDVpy3JWxiuqJlZ+TkZiUw8dJnRocvdS2FvQOlAV AVdg== X-Gm-Message-State: ACgBeo0v2w4djxJEVZBxDvz2BkR0B0AEujsGuoXHURymGoYifYglgNeC fP4c5+aRgb/fsmj2hdbSRP4Mxg== X-Google-Smtp-Source: AA6agR45qe8rSxhRv1mNrZYZcL60ZKw6kqhBAtfQP2Nyk8PJk2MxCElhn+fvn4os1+LlzEf4V7RgdQ== X-Received: by 2002:a05:6214:27c4:b0:473:568:adc with SMTP id ge4-20020a05621427c400b0047305680adcmr16835173qvb.95.1659395749458; Mon, 01 Aug 2022 16:15:49 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id c4-20020ac853c4000000b0031ef0081d77sm7921135qtq.79.2022.08.01.16.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 16:15:48 -0700 (PDT) Date: Mon, 1 Aug 2022 19:15:46 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH 2/2] Makefile: Build final mpc85xx non-SPL image in standard file u-boot.bin Message-ID: <20220801231546.GY1146598@bill-the-cat> References: <20220801154220.20068-1-pali@kernel.org> <20220801154220.20068-2-pali@kernel.org> <20220801193900.zpbunhwopisefjjh@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LFqHrttRSbjloOaY" Content-Disposition: inline In-Reply-To: <20220801193900.zpbunhwopisefjjh@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --LFqHrttRSbjloOaY Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 01, 2022 at 09:39:00PM +0200, Pali Roh=E1r wrote: > On Monday 01 August 2022 13:13:22 Simon Glass wrote: > > Hi Pali, > >=20 > > On Mon, 1 Aug 2022 at 09:43, Pali Roh=E1r wrote: > > > > > > Currently Makefile produces final mpc85xx image when SPL is not used = in > > > custom file u-boot-with-dtb.bin. It is quite confusing name as build > > > process produce also intermediate file standard file u-boot-dtb.bin (= which > > > is just intermediate and not bootable). Other platforms use u-boot.bin > > > (UBOOT_BIN) as standard name for final bootable raw image. > > > > > > So change Makefile rules and binman to produce final bootable file for > > > mpc85xx also into file u-boot.bin. There is just need for mpc85xx to = not > > > define default rule for u-boot.bin then instruct binman (via DTS file= ) to > > > store final image into u-boot.bin (instead of u-boot-with-dtb.bin) and > > > finally rename target u-boot-with-dtb.bin to u-boot.bin. > > > > > > With this change are also removed custom Makefile hacks for mpc85xx t= hat it > > > produced non-standard output file. And also updated documentation. > > > > > > Signed-off-by: Pali Roh=E1r > > > --- > > > Makefile | 19 +++++-------------- > > > arch/powerpc/dts/kmcent2-u-boot.dtsi | 2 +- > > > arch/powerpc/dts/u-boot.dtsi | 2 +- > > > board/freescale/p1_p2_rdb_pc/README | 2 +- > > > board/freescale/p2041rdb/README | 3 --- > > > board/freescale/t102xrdb/README | 2 +- > > > board/freescale/t104xrdb/README | 2 +- > > > board/freescale/t208xqds/README | 2 +- > > > board/freescale/t208xrdb/README | 2 +- > > > 9 files changed, 12 insertions(+), 24 deletions(-) > >=20 > > At present u-boot.bin has a very standard meaning - it is U-Boot with t= he DT. > >=20 > > Boards which need something more than that can/should use binman to > > create a separate file. > >=20 > > I certainly agree that u-boot-with-dtb.bin is a terrible name, though. > > Something more descriptive would be better. > >=20 > > But is it possible to drop these SoC-specific rules in the Makefile > > and just build everything needed in the standard binman rule in the > > Makefile? > >=20 > > Regards, > > Simon >=20 > I do not know what is binman doing and how to use it. I just do not see > reason why it is needed to use such additional tool for building final > binary for powerpc/mpc85xx as other arm boards do not use it at all. >=20 > Ad your comment "At present u-boot.bin has a very standard meaning - it > is U-Boot with the DT." - This is exactly what binman for mpc85xx > produces. >=20 > So I see there could be improvements, but as a first step this my patch > should be enough? So, one of the issues with PowerPC stuff is that much of it is so far behind the rest of U-Boot in terms of frameworks. So yes, let us start by fixing the functional problem you're describing here and then see what appetite exists for further work here. --=20 Tom --LFqHrttRSbjloOaY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLoXp8ACgkQFHw5/5Y0 tyyQ+Qv/brl13zzsKAQq3CvUWlq2iRLo2TOjBNE7lCVYQXNKW8vP3RX3N9n4ambA chkGMJAqLYpqg5OVk1e3orwzqoXC9FnTdTWbyMlqPinh6ZRoUprjZsCAFTwVk/79 Pv/6lifExbEYWODiHGpfjao394KDpUB2zMcIflODeR/VL9JBIWClHeUp9PqJimwU uTFhiZVn3j4RZMZtgNRC3I5zwr0bLRrqA0FY0Ytc8ZkI8dLOMH0OE9sWajhSIIDF YPf7twDyW7xdsU813tVlNGbdmwOV8xdrxwep6mfi14vjZFUJQyoxxcZmmSDQO/uB 6rBI5Fdun8hk1YOvqyoNmiOCskan0fVPzciS3p38eT4q6vzv2+ufm8MOGVn9ki79 2SnM7ERhxEgTCMrdUp6GF8COx9H/vOJGM9EE7prmkmja+S4zKMjzPvinqiTqVfr+ BVe1H+Dus5ejBtf75AQx4iJHZZxYv1sdixYy6ZzsLmDqxZag+FnEA6Cjxbe4EeK2 lH1QldEs =WxKV -----END PGP SIGNATURE----- --LFqHrttRSbjloOaY--