Re: [PATCH V4 7/8] libgpiod: Add rust tests

From: Viresh Kumar <viresh.kumar@linaro.org>
To: Kent Gibson <warthog618@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	linux-gpio@vger.kernel.org,
	"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
	"Wedson Almeida Filho" <wedsonaf@google.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	stratos-dev@op-lists.linaro.org,
	"Gerard Ryan" <g.m0n3y.2503@gmail.com>
Subject: Re: [PATCH V4 7/8] libgpiod: Add rust tests
Date: Tue, 2 Aug 2022 11:14:34 +0530	[thread overview]
Message-ID: <20220802054434.prvmgvv6hklilbfq@vireshk-i7> (raw)
In-Reply-To: <20220801123806.GA42433@sol>

On 01-08-22, 20:38, Kent Gibson wrote:
> The request_lines() could be considered sufficient to test
> the conversions for both request_config and line_config objects.
> 
> But testing request_lines() and reconfigure_lines() doesn't just test
> those conversions, it checks that the functions don't mess with the
> config along the way.
> If you want to take that as a given then sure, just testing the
> config variants for request_lines() will do.

Okay, so we want test setting various flag types in line_config and
then see if request_line() fails or not and verify (read) them later.
Right ?

Very similar to this is also done in tests/line_info now, where you
suggested:

"Test that you can read all supported values for all fields."

So I set all possible values for fields and then read them back.

Lets see after the next version, if they are sufficient or not. I will
happily add more if required then.

Thanks.

-- 
viresh