From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0C087F for ; Tue, 2 Aug 2022 07:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659423674; x=1690959674; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jCjvLaBxmp2E3FvGdoq4c5UFWwHPuOwd+qnY5JFqxA4=; b=LjLLn25QiOAdCjZpf8fJ8Mx2RO8LeMojF6kit3xQQEosCOa34rxzgiBk bS+BnkbGmcsBtYT51c4aclmfKBp4nEo2lVC9MsL8dhVT5vWtOKNWRTBAm iHwgfriFYitAoted2RHXudXEQr9Z4a1K/eMLe5nrs6+zr0mYjJLlXhcGI ptynbxbVUR3AsduWhYUAeRf3SP0pxnXrsGRTSa1d4fq9UD2YP04VElCY4 44tIssjHwpIy5XsnLb81w85WK0r8ieinpKw+TfoxX9PL1UPIx9UwtIro/ ay+t6Uu8b71lmRlmO7HhHls8v113zJZ880OO/eUrCdJaWfLkSvmCRIOGV Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10426"; a="269720177" X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="269720177" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 00:01:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="661499498" Received: from lkp-server01.sh.intel.com (HELO e0eace57cfef) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 02 Aug 2022 00:01:08 -0700 Received: from kbuild by e0eace57cfef with local (Exim 4.96) (envelope-from ) id 1oIlts-000FnT-0R; Tue, 02 Aug 2022 07:01:08 +0000 Date: Tue, 2 Aug 2022 15:00:10 +0800 From: kernel test robot To: Huacai Chen , Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Catalin Marinas , Will Deacon , Dinh Nguyen Cc: kbuild-all@lists.01.org, loongarch@lists.linux.dev, linux-arch@vger.kernel.org, Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux Memory Management List , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Feiyang Chen , Min Zhou Subject: Re: [PATCH V6 2/4] LoongArch: Add sparse memory vmemmap support Message-ID: <202208021409.KLLd0NYP-lkp@intel.com> References: <20220728113801.2235151-3-chenhuacai@loongson.cn> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728113801.2235151-3-chenhuacai@loongson.cn> Hi Huacai, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on soc/for-next] [also build test WARNING on kvm/queue arm64/for-next/core linus/master v5.19] [cannot apply to akpm-mm/mm-everything tip/x86/mm] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/mm-sparse-vmemmap-Generalise-helpers-and-enable-for-LoongArch/20220728-194351 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: loongarch-randconfig-p002-20220801 (https://download.01.org/0day-ci/archive/20220802/202208021409.KLLd0NYP-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d391b94d4c12d54baaf038273712f8da86d50e8d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Huacai-Chen/mm-sparse-vmemmap-Generalise-helpers-and-enable-for-LoongArch/20220728-194351 git checkout d391b94d4c12d54baaf038273712f8da86d50e8d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash arch/loongarch/mm/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): arch/loongarch/mm/init.c:161:15: warning: no previous prototype for 'vmemmap_populate_hugepages' [-Wmissing-prototypes] 161 | int __meminit vmemmap_populate_hugepages(unsigned long start, unsigned long end, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> arch/loongarch/mm/init.c:223:6: warning: no previous prototype for 'vmemmap_free' [-Wmissing-prototypes] 223 | void vmemmap_free(unsigned long start, unsigned long end, | ^~~~~~~~~~~~ vim +/vmemmap_free +223 arch/loongarch/mm/init.c 159 160 #ifdef CONFIG_SPARSEMEM_VMEMMAP > 161 int __meminit vmemmap_populate_hugepages(unsigned long start, unsigned long end, 162 int node, struct vmem_altmap *altmap) 163 { 164 unsigned long addr = start; 165 unsigned long next; 166 pgd_t *pgd; 167 p4d_t *p4d; 168 pud_t *pud; 169 pmd_t *pmd; 170 171 for (addr = start; addr < end; addr = next) { 172 next = pmd_addr_end(addr, end); 173 174 pgd = vmemmap_pgd_populate(addr, node); 175 if (!pgd) 176 return -ENOMEM; 177 p4d = vmemmap_p4d_populate(pgd, addr, node); 178 if (!p4d) 179 return -ENOMEM; 180 pud = vmemmap_pud_populate(p4d, addr, node); 181 if (!pud) 182 return -ENOMEM; 183 184 pmd = pmd_offset(pud, addr); 185 if (pmd_none(*pmd)) { 186 void *p = NULL; 187 188 p = vmemmap_alloc_block_buf(PMD_SIZE, node, NULL); 189 if (p) { 190 pmd_t entry; 191 192 entry = pfn_pmd(virt_to_pfn(p), PAGE_KERNEL); 193 pmd_val(entry) |= _PAGE_HUGE | _PAGE_HGLOBAL; 194 set_pmd_at(&init_mm, addr, pmd, entry); 195 196 continue; 197 } 198 } else if (pmd_val(*pmd) & _PAGE_HUGE) { 199 vmemmap_verify((pte_t *)pmd, node, addr, next); 200 continue; 201 } 202 if (vmemmap_populate_basepages(addr, next, node, NULL)) 203 return -ENOMEM; 204 } 205 206 return 0; 207 } 208 209 #if CONFIG_PGTABLE_LEVELS == 2 210 int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, 211 struct vmem_altmap *altmap) 212 { 213 return vmemmap_populate_basepages(start, end, node, NULL); 214 } 215 #else 216 int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, 217 struct vmem_altmap *altmap) 218 { 219 return vmemmap_populate_hugepages(start, end, node, NULL); 220 } 221 #endif 222 > 223 void vmemmap_free(unsigned long start, unsigned long end, 224 struct vmem_altmap *altmap) 225 { 226 } 227 #endif 228 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F97CC00140 for ; Tue, 2 Aug 2022 07:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZOu/SprAflO9JkRuUTu7W+6+nlrX6XglfP5x/8ZjdfU=; b=fOKlMdHWYqU/iB bLqcaTUCgpf1sVhi7bIdsuFWZTFhe+j5aI0gsW9Jn+MQsalf50rS17Um1wQddz02An/YRrbKYm4Sk fFfYbOSx8YX0pMWCVG7ZuYS/Spv7MBLCB+34jf7GguQoPcCkGmDujpVw47ZLGE6j80tdavcv61s0i zfGIFNZXhyIFrRumrR5ZHjbC1i15e3cq0IDI9V/egVtbFH6yeg8OUCeqBFm7HDhG5dNz0R8mpzjyd ZUrTT/q6aFqve7Z50TMykH6o9iB8YGyQg/krXjhnv34FWbaMmakVO3n92oQTnSLrnFxY5OqhTohrH 7WFBtLsgqmOwvb1cVU6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIlu9-00B9sp-TJ; Tue, 02 Aug 2022 07:01:26 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIlu3-00B9oa-1L for linux-arm-kernel@lists.infradead.org; Tue, 02 Aug 2022 07:01:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659423678; x=1690959678; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jCjvLaBxmp2E3FvGdoq4c5UFWwHPuOwd+qnY5JFqxA4=; b=ArApqMaP9CtsZZAZAMkLzj6OJX320chHDV+XYDo+mn0mQeNC+Xjje48d fAZOZ1b2zXh+E/Ujgt0KViiQ8Tkg75vmbWl3nqmu7OVCa0XlPe/VYu3aH /sWCWbh58+cryk7CONXhuuQVVFlnLdHMnK1dFQC8Vc/dcis2fXKxsbiWl WgNN0R4CkoW025pdPPwBBmadzim1vSn9FE3i1WhyI7lMjGgepSr1z32FR Y43ImEt2MuIbK21RAS1lY9iNsq4iQRW2JNNG5j5iB32PmdUvDcqOzO6C8 iqev495XjinsNG+GElb8Q3hn0p80K4mXhyDKu4uNQ6OLIXKN/OOIIH1X3 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10426"; a="351047968" X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="351047968" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 00:01:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="661499498" Received: from lkp-server01.sh.intel.com (HELO e0eace57cfef) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 02 Aug 2022 00:01:08 -0700 Received: from kbuild by e0eace57cfef with local (Exim 4.96) (envelope-from ) id 1oIlts-000FnT-0R; Tue, 02 Aug 2022 07:01:08 +0000 Date: Tue, 2 Aug 2022 15:00:10 +0800 From: kernel test robot To: Huacai Chen , Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Catalin Marinas , Will Deacon , Dinh Nguyen Cc: kbuild-all@lists.01.org, loongarch@lists.linux.dev, linux-arch@vger.kernel.org, Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux Memory Management List , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Feiyang Chen , Min Zhou Subject: Re: [PATCH V6 2/4] LoongArch: Add sparse memory vmemmap support Message-ID: <202208021409.KLLd0NYP-lkp@intel.com> References: <20220728113801.2235151-3-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220728113801.2235151-3-chenhuacai@loongson.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_000119_288896_06BFE338 X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Huacai, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on soc/for-next] [also build test WARNING on kvm/queue arm64/for-next/core linus/master v5.19] [cannot apply to akpm-mm/mm-everything tip/x86/mm] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/mm-sparse-vmemmap-Generalise-helpers-and-enable-for-LoongArch/20220728-194351 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: loongarch-randconfig-p002-20220801 (https://download.01.org/0day-ci/archive/20220802/202208021409.KLLd0NYP-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d391b94d4c12d54baaf038273712f8da86d50e8d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Huacai-Chen/mm-sparse-vmemmap-Generalise-helpers-and-enable-for-LoongArch/20220728-194351 git checkout d391b94d4c12d54baaf038273712f8da86d50e8d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash arch/loongarch/mm/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): arch/loongarch/mm/init.c:161:15: warning: no previous prototype for 'vmemmap_populate_hugepages' [-Wmissing-prototypes] 161 | int __meminit vmemmap_populate_hugepages(unsigned long start, unsigned long end, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> arch/loongarch/mm/init.c:223:6: warning: no previous prototype for 'vmemmap_free' [-Wmissing-prototypes] 223 | void vmemmap_free(unsigned long start, unsigned long end, | ^~~~~~~~~~~~ vim +/vmemmap_free +223 arch/loongarch/mm/init.c 159 160 #ifdef CONFIG_SPARSEMEM_VMEMMAP > 161 int __meminit vmemmap_populate_hugepages(unsigned long start, unsigned long end, 162 int node, struct vmem_altmap *altmap) 163 { 164 unsigned long addr = start; 165 unsigned long next; 166 pgd_t *pgd; 167 p4d_t *p4d; 168 pud_t *pud; 169 pmd_t *pmd; 170 171 for (addr = start; addr < end; addr = next) { 172 next = pmd_addr_end(addr, end); 173 174 pgd = vmemmap_pgd_populate(addr, node); 175 if (!pgd) 176 return -ENOMEM; 177 p4d = vmemmap_p4d_populate(pgd, addr, node); 178 if (!p4d) 179 return -ENOMEM; 180 pud = vmemmap_pud_populate(p4d, addr, node); 181 if (!pud) 182 return -ENOMEM; 183 184 pmd = pmd_offset(pud, addr); 185 if (pmd_none(*pmd)) { 186 void *p = NULL; 187 188 p = vmemmap_alloc_block_buf(PMD_SIZE, node, NULL); 189 if (p) { 190 pmd_t entry; 191 192 entry = pfn_pmd(virt_to_pfn(p), PAGE_KERNEL); 193 pmd_val(entry) |= _PAGE_HUGE | _PAGE_HGLOBAL; 194 set_pmd_at(&init_mm, addr, pmd, entry); 195 196 continue; 197 } 198 } else if (pmd_val(*pmd) & _PAGE_HUGE) { 199 vmemmap_verify((pte_t *)pmd, node, addr, next); 200 continue; 201 } 202 if (vmemmap_populate_basepages(addr, next, node, NULL)) 203 return -ENOMEM; 204 } 205 206 return 0; 207 } 208 209 #if CONFIG_PGTABLE_LEVELS == 2 210 int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, 211 struct vmem_altmap *altmap) 212 { 213 return vmemmap_populate_basepages(start, end, node, NULL); 214 } 215 #else 216 int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, 217 struct vmem_altmap *altmap) 218 { 219 return vmemmap_populate_hugepages(start, end, node, NULL); 220 } 221 #endif 222 > 223 void vmemmap_free(unsigned long start, unsigned long end, 224 struct vmem_altmap *altmap) 225 { 226 } 227 #endif 228 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel