From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA6C4C19F2C for ; Wed, 3 Aug 2022 14:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236554AbiHCO0q (ORCPT ); Wed, 3 Aug 2022 10:26:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbiHCO0n (ORCPT ); Wed, 3 Aug 2022 10:26:43 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB424F595; Wed, 3 Aug 2022 07:26:41 -0700 (PDT) Date: Wed, 3 Aug 2022 16:26:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1659536799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a21Mzo/WHyccC08tC0VXa91bkOq8OW9CcHwOisfYdPQ=; b=EqFaUed3/VNo8MquR1lHM+NIh+hCWF2/EI8Frah6p7AL20Lw8DLnrvPhlPSevM03w2knZG kchAKMl5wnl/lUjTKU6T/NqDJVaduzMDAyWZyxCD3qqiUHKpngV0b3gmK8OaWLp60QWZYy t/CZbZxG5y/ZJE9C5l1p1AMwVEOa2So= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Jinrong Liang Cc: Paolo Bonzini , Wanpeng Li , Sean Christopherson , Jim Mattson , Vitaly Kuznetsov , Joerg Roedel , Jinrong Liang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: kvm: Fix a compile error in selftests/kvm/rseq_test.c Message-ID: <20220803142637.3y5fj2cwyvbrwect@kamzik> References: <20220802071240.84626-1-cloudliang@tencent.com> <20220802150830.rgzeg47enbpsucbr@kamzik> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2022 at 09:58:51PM +0800, Jinrong Liang wrote: > My ldd version is (GNU libc) 2.28, and I get a compilation error in this case. > But I use another ldd (Ubuntu GLIBC 2.31-0ubuntu9.2) 2.31 is compiling fine. > This shows that compilation errors may occur in different GNU libc environments. > Would it be more appropriate to use syscall for better compatibility? OK, it's a pity, but no big deal to use syscall(). Reviewed-by: Andrew Jones Thanks, drew