From: Jack Champagne <jackchampagne.r@gmail.com>
To: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Stephen Kitt <steve@sk2.org>,
Jack Champagne <jackchampagne.r@gmail.com>
Subject: [PATCH] hwmon: (ads7828) Rename regmap_config variable
Date: Wed, 3 Aug 2022 13:43:56 -0400 [thread overview]
Message-ID: <20220803174356.474969-1-jackchampagne.r@gmail.com> (raw)
The regmap_config variable for the ads7828 and the ads7830 are both
misnamed to `ads2828_regmap_config` and `ads2830_regmap_config`
respectively. These variables refer to regmap configs for the ads7828
and the ads7830 and should be named accordingly.
This patch does not introduce functional changes as the only two usages
of these regmap_config variables are within the changed file.
Signed-off-by: Jack Champagne <jackchampagne.r@gmail.com>
---
drivers/hwmon/ads7828.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hwmon/ads7828.c b/drivers/hwmon/ads7828.c
index 7246198f0901..20bdee769882 100644
--- a/drivers/hwmon/ads7828.c
+++ b/drivers/hwmon/ads7828.c
@@ -89,12 +89,12 @@ static struct attribute *ads7828_attrs[] = {
ATTRIBUTE_GROUPS(ads7828);
-static const struct regmap_config ads2828_regmap_config = {
+static const struct regmap_config ads7828_regmap_config = {
.reg_bits = 8,
.val_bits = 16,
};
-static const struct regmap_config ads2830_regmap_config = {
+static const struct regmap_config ads7830_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
};
@@ -152,11 +152,11 @@ static int ads7828_probe(struct i2c_client *client)
if (chip == ads7828) {
data->lsb_resol = DIV_ROUND_CLOSEST(vref_mv * 1000, 4096);
data->regmap = devm_regmap_init_i2c(client,
- &ads2828_regmap_config);
+ &ads7828_regmap_config);
} else {
data->lsb_resol = DIV_ROUND_CLOSEST(vref_mv * 1000, 256);
data->regmap = devm_regmap_init_i2c(client,
- &ads2830_regmap_config);
+ &ads7830_regmap_config);
}
if (IS_ERR(data->regmap))
--
2.25.1
next reply other threads:[~2022-08-03 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 17:43 Jack Champagne [this message]
2022-08-04 6:47 ` [PATCH] hwmon: (ads7828) Rename regmap_config variable Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803174356.474969-1-jackchampagne.r@gmail.com \
--to=jackchampagne.r@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.