Re: [PATCH 2/2] mm: Remember young bit for page migrations

From: kernel test robot <lkp@intel.com>
To: Peter Xu <peterx@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org, Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	David Hildenbrand <david@redhat.com>,
	Hugh Dickins <hughd@google.com>,
	Huang Ying <ying.huang@intel.com>,
	peterx@redhat.com, Nadav Amit <nadav.amit@gmail.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 2/2] mm: Remember young bit for page migrations
Date: Wed, 3 Aug 2022 20:21:43 +0800	[thread overview]
Message-ID: <202208032031.PVcMB0Hr-lkp@intel.com> (raw)
In-Reply-To: <20220803012159.36551-3-peterx@redhat.com>

Hi Peter,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-Remember-young-bit-for-migration-entries/20220803-092311
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: openrisc-randconfig-r016-20220803 (https://download.01.org/0day-ci/archive/20220803/202208032031.PVcMB0Hr-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2fca6cb25745d1404fc34e0ec2ea89b6195a8c27
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Peter-Xu/mm-Remember-young-bit-for-migration-entries/20220803-092311
        git checkout 2fca6cb25745d1404fc34e0ec2ea89b6195a8c27
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   or1k-linux-ld: mm/rmap.o: in function `migration_entry_supports_young':
>> include/linux/swapops.h:288: undefined reference to `max_swapfile_size'
   include/linux/swapops.h:288:(.text+0x31a0): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `max_swapfile_size'
   or1k-linux-ld: mm/migrate.o: in function `migration_entry_supports_young':
>> include/linux/swapops.h:288: undefined reference to `max_swapfile_size'
   include/linux/swapops.h:288:(.text+0x158): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `max_swapfile_size'

vim +288 include/linux/swapops.h

   279	
   280	static inline bool migration_entry_supports_young(void)
   281	{
   282		/*
   283		 * max_swapfile_size() returns the max supported swp-offset plus 1.
   284		 * We can support the migration young bit only if the pfn swap
   285		 * entry has the offset larger than storing the PFN value, then it
   286		 * means there's extra bit(s) where we can store the young bit.
   287		 */
 > 288		return max_swapfile_size() > SWP_MIG_YOUNG_BIT;
   289	}
   290	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp