From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F59C25B07 for ; Sat, 6 Aug 2022 13:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbiHFNs0 (ORCPT ); Sat, 6 Aug 2022 09:48:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230388AbiHFNsY (ORCPT ); Sat, 6 Aug 2022 09:48:24 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DBCDE02A for ; Sat, 6 Aug 2022 06:48:22 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id r186so4889487pgr.2 for ; Sat, 06 Aug 2022 06:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=TvgStXa3vG7bi+uh32sGsPJgv8LsfCjRHZ5xxTji6lE=; b=ES3bR2McfzepqYPSSNZOJNByBNU66z7MPhvQimFx/YBeXozBQ6nqrnDlDbGbWmPwSk jF4AdnNySCbx+TDceM4oFR52qxYMPnSx7jmX/XQKO+sY0PuyxqAVZNmRGnyIU2wmdkx7 hDVIJPE6RdXG2SN+O3oftHsK2uHvwrAkTXmGdD20/1QNRd9WyipNhksqSZ0YVj4sZvKc zfmAFbEB72Bj1nhfml0x1z0w5AI3814EtRv3vMPdgDfroYP1WYcjTt7rJ/WMwrUduNfQ p5X7GKIr3sWEGAxQkhqNKUBnhB8H8OoPuHLACJWTsPT6lYwUdt7LBWYI9DGGiZaMrI0a FOLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TvgStXa3vG7bi+uh32sGsPJgv8LsfCjRHZ5xxTji6lE=; b=u++PjF4tnln/NoQSbrL33FNb16qkY/ItQfPdqAj5Wjnn6TVw2i6l+iw7H06jf7d1bN /pQ2UsxcD9zxxvR2h6q+zDJMkmTNb/qQgpUC9AqB3qKCQyRQ97T5mL6+6HHCC4tA9oLf l9CJLKQn7a9qJtDDqiNC+zPtfCvoC8ZTwrStFZ7X4Idoh3Z16hA0Yi7RXSodSRnQbMSO JsdpRroRrx6pxPwgiZKj6UjDSBf/RwiIx5byhWZKiAudXb1dst7lSjrsBSWTe/b8kbvN Zs7bBTVRCGc2mOZI+fpbrSIlzjAkk/gLXAKxyY+wv6KKLNWvRI1oCJVBZeXdOZaCJ6xV Zt8g== X-Gm-Message-State: ACgBeo2jV8tn49xrzbD2mwGz9s5qj6HzqdZxZn++6kZlgF7YAnBZ5iPx Y2wA2dVqm2zJBy+f+gbG8tyQ X-Google-Smtp-Source: AA6agR4fxjllwhUaGWVmBM/fFPtDlHG357VCe4ud9OsIE0eNpij3HDe+s37YBQUhgIivve2UUInYvQ== X-Received: by 2002:a63:85c8:0:b0:41b:f27f:5a7e with SMTP id u191-20020a6385c8000000b0041bf27f5a7emr9588798pgd.590.1659793701451; Sat, 06 Aug 2022 06:48:21 -0700 (PDT) Received: from thinkpad ([117.202.188.20]) by smtp.gmail.com with ESMTPSA id k92-20020a17090a4ce500b001f506804af3sm3276667pjh.52.2022.08.06.06.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 06:48:21 -0700 (PDT) Date: Sat, 6 Aug 2022 19:18:10 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krishna Kurapati , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Pavankumar Kondeti , quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrew Halaney Subject: Re: [PATCH v2 1/9] usb: dwc3: fix PHY disable sequence Message-ID: <20220806134810.GB14384@thinkpad> References: <20220804151001.23612-1-johan+linaro@kernel.org> <20220804151001.23612-2-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220804151001.23612-2-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Aug 04, 2022 at 05:09:53PM +0200, Johan Hovold wrote: > Generic PHYs must be powered-off before they can be tore down. > > Similarly, suspending legacy PHYs after having powered them off makes no > sense. > > Fix the dwc3_core_exit() (e.g. called during suspend) and open-coded > dwc3_probe() error-path sequences that got this wrong. > > Note that this makes dwc3_core_exit() match the dwc3_core_init() error > path with respect to powering off the PHYs. > > Fixes: 03c1fd622f72 ("usb: dwc3: core: add phy cleanup for probe error handling") > Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths") > Cc: stable@vger.kernel.org # 4.8 > Reviewed-by: Andrew Halaney > Reviewed-by: Matthias Kaehlcke > Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/usb/dwc3/core.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index c5c238ab3083..16d1f328775f 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -833,15 +833,16 @@ static void dwc3_core_exit(struct dwc3 *dwc) > { > dwc3_event_buffers_cleanup(dwc); > > + usb_phy_set_suspend(dwc->usb2_phy, 1); > + usb_phy_set_suspend(dwc->usb3_phy, 1); > + phy_power_off(dwc->usb2_generic_phy); > + phy_power_off(dwc->usb3_generic_phy); > + > usb_phy_shutdown(dwc->usb2_phy); > usb_phy_shutdown(dwc->usb3_phy); > phy_exit(dwc->usb2_generic_phy); > phy_exit(dwc->usb3_generic_phy); > > - usb_phy_set_suspend(dwc->usb2_phy, 1); > - usb_phy_set_suspend(dwc->usb3_phy, 1); > - phy_power_off(dwc->usb2_generic_phy); > - phy_power_off(dwc->usb3_generic_phy); > dwc3_clk_disable(dwc); > reset_control_assert(dwc->reset); > } > @@ -1879,16 +1880,16 @@ static int dwc3_probe(struct platform_device *pdev) > dwc3_debugfs_exit(dwc); > dwc3_event_buffers_cleanup(dwc); > > - usb_phy_shutdown(dwc->usb2_phy); > - usb_phy_shutdown(dwc->usb3_phy); > - phy_exit(dwc->usb2_generic_phy); > - phy_exit(dwc->usb3_generic_phy); > - > usb_phy_set_suspend(dwc->usb2_phy, 1); > usb_phy_set_suspend(dwc->usb3_phy, 1); > phy_power_off(dwc->usb2_generic_phy); > phy_power_off(dwc->usb3_generic_phy); > > + usb_phy_shutdown(dwc->usb2_phy); > + usb_phy_shutdown(dwc->usb3_phy); > + phy_exit(dwc->usb2_generic_phy); > + phy_exit(dwc->usb3_generic_phy); > + > dwc3_ulpi_exit(dwc); > > err4: > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்