From: Randy Dunlap <rdunlap@infradead.org> To: linux-kernel@vger.kernel.org Cc: Randy Dunlap <rdunlap@infradead.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-riscv@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org Subject: [PATCH] asm-generic: unistd.h: make 'compat_sys_fadvise64_64' conditional Date: Sun, 7 Aug 2022 10:28:54 -0700 [thread overview] Message-ID: <20220807172854.12971-1-rdunlap@infradead.org> (raw) Don't require 'compat_sys_fadvise64_64' when __ARCH_WANT_COMPAT_FADVISE64_64 is not set. Fixes this build error when CONFIG_ADVISE_SYSCALLS is not set: include/uapi/asm-generic/unistd.h:649:49: error: 'compat_sys_fadvise64_64' undeclared here (not in a function); did you mean 'ksys_fadvise64_64'? 649 | __SC_COMP(__NR3264_fadvise64, sys_fadvise64_64, compat_sys_fadvise64_64) arch/riscv/kernel/compat_syscall_table.c:12:42: note: in definition of macro '__SYSCALL' 12 | #define __SYSCALL(nr, call) [nr] = (call), include/uapi/asm-generic/unistd.h:649:1: note: in expansion of macro '__SC_COMP' 649 | __SC_COMP(__NR3264_fadvise64, sys_fadvise64_64, compat_sys_fadvise64_64) Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: linux-riscv@lists.infradead.org Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-arch@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org --- include/uapi/asm-generic/unistd.h | 2 ++ 1 file changed, 2 insertions(+) --- a/include/uapi/asm-generic/unistd.h +++ b/include/uapi/asm-generic/unistd.h @@ -645,8 +645,10 @@ __SC_COMP(__NR_execve, sys_execve, compa #define __NR3264_mmap 222 __SC_3264(__NR3264_mmap, sys_mmap2, sys_mmap) /* mm/fadvise.c */ +#ifdef __ARCH_WANT_COMPAT_FADVISE64_64 #define __NR3264_fadvise64 223 __SC_COMP(__NR3264_fadvise64, sys_fadvise64_64, compat_sys_fadvise64_64) +#endif /* mm/, CONFIG_MMU only */ #ifndef __ARCH_NOMMU
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: linux-kernel@vger.kernel.org Cc: Randy Dunlap <rdunlap@infradead.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-riscv@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org Subject: [PATCH] asm-generic: unistd.h: make 'compat_sys_fadvise64_64' conditional Date: Sun, 7 Aug 2022 10:28:54 -0700 [thread overview] Message-ID: <20220807172854.12971-1-rdunlap@infradead.org> (raw) Don't require 'compat_sys_fadvise64_64' when __ARCH_WANT_COMPAT_FADVISE64_64 is not set. Fixes this build error when CONFIG_ADVISE_SYSCALLS is not set: include/uapi/asm-generic/unistd.h:649:49: error: 'compat_sys_fadvise64_64' undeclared here (not in a function); did you mean 'ksys_fadvise64_64'? 649 | __SC_COMP(__NR3264_fadvise64, sys_fadvise64_64, compat_sys_fadvise64_64) arch/riscv/kernel/compat_syscall_table.c:12:42: note: in definition of macro '__SYSCALL' 12 | #define __SYSCALL(nr, call) [nr] = (call), include/uapi/asm-generic/unistd.h:649:1: note: in expansion of macro '__SC_COMP' 649 | __SC_COMP(__NR3264_fadvise64, sys_fadvise64_64, compat_sys_fadvise64_64) Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: linux-riscv@lists.infradead.org Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-arch@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org --- include/uapi/asm-generic/unistd.h | 2 ++ 1 file changed, 2 insertions(+) --- a/include/uapi/asm-generic/unistd.h +++ b/include/uapi/asm-generic/unistd.h @@ -645,8 +645,10 @@ __SC_COMP(__NR_execve, sys_execve, compa #define __NR3264_mmap 222 __SC_3264(__NR3264_mmap, sys_mmap2, sys_mmap) /* mm/fadvise.c */ +#ifdef __ARCH_WANT_COMPAT_FADVISE64_64 #define __NR3264_fadvise64 223 __SC_COMP(__NR3264_fadvise64, sys_fadvise64_64, compat_sys_fadvise64_64) +#endif /* mm/, CONFIG_MMU only */ #ifndef __ARCH_NOMMU _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2022-08-07 17:29 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-07 17:28 Randy Dunlap [this message] 2022-08-07 17:28 ` [PATCH] asm-generic: unistd.h: make 'compat_sys_fadvise64_64' conditional Randy Dunlap 2022-08-07 19:44 ` Arnd Bergmann 2022-08-07 19:44 ` Arnd Bergmann 2022-08-07 22:39 ` Randy Dunlap 2022-08-07 22:39 ` Randy Dunlap 2022-08-08 8:06 ` Arnd Bergmann 2022-08-08 8:06 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220807172854.12971-1-rdunlap@infradead.org \ --to=rdunlap@infradead.org \ --cc=akpm@linux-foundation.org \ --cc=aou@eecs.berkeley.edu \ --cc=arnd@arndb.de \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.