From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C43C25B0C for ; Mon, 8 Aug 2022 10:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238306AbiHHKaE (ORCPT ); Mon, 8 Aug 2022 06:30:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242026AbiHHK36 (ORCPT ); Mon, 8 Aug 2022 06:29:58 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70137.outbound.protection.outlook.com [40.107.7.137]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60519638E; Mon, 8 Aug 2022 03:29:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xm/gFW9AHN9rw3MLU/dmzTeYxDUsM2aLAgJuMSgkhOFRjxNrvzTlyV09VeZpFPRG4CIkzNxqCgf3phAPwDXSLR1CpUoZdUvoo6hILR91O/gaJNKnmMKDiaf27zzFeaaRPbgYcBFfjb1P4dt7e8y1GFuRdSayZ7QNzZ/9VIe5FgYLtN5FolGYNB+K4mQj6sJW+mNCRuxjYdS1cJuW4cERA6NDVdP8UFc8PK74+LFWq1iJCTOeiMjSsHiqeCK1eASvJ9p6FoBYUvOoSWPLF2TvE1Gf2s+0ul1476SaQUOsk3yUtJTkWHySVirGxje+MoueZrMdIxCN3Ie2+ff3hycDKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9OCjIMxnXo++OUR8YLk056Nlono6puOOs857h2pp5iY=; b=KkbpiYVII809iyOCQccvfy2FPYZwVw0A7p3/mZ/8EhCgoYIHFzLYueIcQdUbCH3sAg2LYiqqrR63rrpUdOwkHDPJCXTuZltLw2QDo/eHPz1hemIXuzi2VuzDlN1mwsWV/6GWVJ1MGJ9t+FtOTGtsymgdP77i4SO2/e98nDLw/AP54CBGgP+JJRcC2bJ6rLt8W3b3yw9eDQdus8gkXStcShfVl+e0uZEkpPeDVrUcLmUpeBNrLKbMUYn3zbADQapj0IFx78bH4vHtOUs0xPMF0+fol1r6K25amjPsKKRwBUe6Qhvcnfjm0KeHfPhUNGzIVTvNOIDng/TPPoAJhhAZEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9OCjIMxnXo++OUR8YLk056Nlono6puOOs857h2pp5iY=; b=bnXL50NRPfw1WOMX/XMGnoTFtuN6xL1pOii0xvzn0iJ9q8qZBQJDiXo8KESblQDInQWM3MEkn2HBGW/a6Zk1VS2e79W09zmTusbYtshvxfcWISK/uDs6XKzbnyHHPy9ClCJBqsuQaYnS/IKUAOgBQmkUmGlohNJWqPsb1VgKBzQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=plvision.eu; Received: from DB6P190MB0310.EURP190.PROD.OUTLOOK.COM (2603:10a6:6:3e::13) by VE1P190MB0989.EURP190.PROD.OUTLOOK.COM (2603:10a6:800:1a9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 10:29:50 +0000 Received: from DB6P190MB0310.EURP190.PROD.OUTLOOK.COM ([fe80::80ef:cc92:119c:1a0d]) by DB6P190MB0310.EURP190.PROD.OUTLOOK.COM ([fe80::80ef:cc92:119c:1a0d%7]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022 10:29:50 +0000 Date: Mon, 8 Aug 2022 13:29:47 +0300 From: Vadym Kochan To: Adrian Hunter Cc: Florian Fainelli , Hu Ziji , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Elad Nachman Subject: Re: [PATCH] mmc: sdhci-xenon: Fix 2G limitation on AC5 SoC Message-ID: <20220808102947.GA25118@plvision.eu> References: <20220726170711.30324-1-vadym.kochan@plvision.eu> <139317dc-15e2-ac63-0e04-295e715a7747@gmail.com> <20220727164532.GA19351@plvision.eu> <20220801093044.GA22721@plvision.eu> <9a248303-7a27-e90e-76b3-c01a00be4e3d@intel.com> <20220808095237.GA15939@plvision.eu> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220808095237.GA15939@plvision.eu> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: BE1P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:22::17) To DB6P190MB0310.EURP190.PROD.OUTLOOK.COM (2603:10a6:6:3e::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88b2bbf3-bd6e-4478-335e-08da7928eca7 X-MS-TrafficTypeDiagnostic: VE1P190MB0989:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lHkVQar/o9zdv63URAtn6zhOAi41PchTjORiMgZxbzZU0cEXE5B3LwFAzgsvO07obf4jL/1PhKCmqSDfQ9uF5qQkbfSo4WOcjkVsieGO/sOYCsXY56acUt6HekbB9k7St44FCBY6lbQsbskdUkpDrBgs1u0HNxA6hBQuVFPm18nVXHGQJU0uR+tBao2LncwB7yv7AdYclZvR4FWO7sYqGVqK+JIUTVXSO33T1Brtw7AmUMWttgYlzQSYH3epFHCIDgZDEKkTMbA/PZgnoCk6A4uOIg0XcwsBohcN6aULMzTXq019BcuA+bQV/wjNTiXxnTOYxMAe3GopIPLbV4ajLrLYLlsVU+S1S59oGrksus14dcSoWOQkGVIq3abxF7fLOjuPIRhnnzy+W8SOIqblwjsE0GVqJBPbntrthVACHevhSVn5PsJiq3koTIF3IQshN6zJNagF7c4gv1X+unev72hPCEONYAQ+4nOc3YXSm9R3Uoh0PLqFdhxAp0R+7fq3dIlrmCyObOCiGXuv+TsQlxcV4VyrtyJUrZvQVIyKDcDWMi4SW+ElHZTk/4EhAVSsnxadWbaTX2ZQsHvZyJyUi0EJpv5+NdKT67qql5KG4WcmY7cG1ub6fqCziOSpPZWbJtx5GXSFj884nRj36TLhTDBu879RvpsXpJH4Tiv/Z9uM2F8z+HD2PRmyRFAFXGbQY3/450xGxjVUcEUHwHo5a+45cZJnAo4SDAuOdGU+cvoGiTvzb5uUdOVlSb1YErqoTXqQJAYVFuYmOznkVFlUMws7NPmTCn1IbUek6iZiPI0XIfP/n4Am2kTeV2Q2mQ9J X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6P190MB0310.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39830400003)(136003)(366004)(34036004)(376002)(346002)(396003)(45080400002)(6506007)(83380400001)(53546011)(41300700001)(508600001)(33656002)(8676002)(52116002)(4326008)(66476007)(66946007)(66556008)(6666004)(316002)(41320700001)(1076003)(186003)(2616005)(6916009)(54906003)(6512007)(26005)(86362001)(36756003)(2906002)(38350700002)(38100700002)(8936002)(6486002)(30864003)(44832011)(5660300002)(21314003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5DSgzz5H1tJTybDt7hAVTgPFryjE6DbM8x+Kgeg4OSZ+Juar6CTWrX0TfJDT?= =?us-ascii?Q?0JDLT5CfctM++RjO0qbH8aC1O6lKTG2NDvqr/P4uBClxuc+WoTI787xD5/IV?= =?us-ascii?Q?hTJ4yA2joWYqaaf2wk6VeZwLW6SGeSqggfF76a9WD/gI1RfzgIOCW38Z7PgW?= =?us-ascii?Q?I0KEIzKoV2MG6GIXM2Hv8J0x60icd8lSV5PmZDhW6Om6/vi7lRMGTBGsgwlS?= =?us-ascii?Q?YrdPk34YvpEJituild1O6PkuEaBNUCfFxc4M+eGOZ0bBTxfPk9Hrjcjg73xa?= =?us-ascii?Q?Iby7bMipYH8s6M7QeNXYSSXO4LHCXU/zFL/UXc2ag9GIE8Ty0h7GN86OK/kX?= =?us-ascii?Q?WqzWtBUc5Rw70WFDEQy6cOexogOuiBnEmDgyINkNdRv/FFbQn6ls98uobI1I?= =?us-ascii?Q?CUx0nC3q0p6kRLi8JzNrVF6ivPEcPIlP90i0N/QT1zJIMgKk+rBj6Bi1D+ef?= =?us-ascii?Q?zhdbf6E+gSyPMofTcEieaV2kSL3raVClmkQiRbprFlvnZrqu1CEtkDSPQ+xf?= =?us-ascii?Q?MlB+1MGzrNZU2gzSVMdUCJTc3D4G/m0uD4SKlipIkqK7VyjI0yPgLSGb5rR/?= =?us-ascii?Q?X9nzQD7OqOls2TFCNVGQNbmClUt4o+/+vrnPmK+rwXZPjPXXPfMH2ql+5CmC?= =?us-ascii?Q?W+3K/BxChOKybVU1U0XJy1PdWOwiEVYAMIZps1X65a7stQ7tdpMvE1OtM4zR?= =?us-ascii?Q?3Ysju4JsVVCLp7gBQjOdeQWOAtLhK2iBVbec8OwjOtgM/qQiw6H6C4Gcwmzv?= =?us-ascii?Q?hZZtfb4M0dmMCik4RoOjHihgQiO0PAbcXScneSZSZDaR+nu3q388zCdcxDcb?= =?us-ascii?Q?EqOjReGTUFlKwf8QKxzz1rngBzWprO5Ayx9nlHBLhyds6ODGuKTJFOCRFvdF?= =?us-ascii?Q?zWCFR8kM2D5nCOXyYtmW8jNsGlV7+qh18khJWw6GQHaSIIJHft2GKY+1LBPu?= =?us-ascii?Q?axtSINPvw9XParK+MoNJrZ6Kq/vPPmaFPmbheJ1F1y4Q6Emr+lOxc3JYM1Uu?= =?us-ascii?Q?qRI0ZRPDu1NGI/NRyWET7n+dUKLGMqheJUo7qZz9TSlKJJVmYtOBGJ52AKBF?= =?us-ascii?Q?yKesacGKVo4IXQH0pzwDqCZi9c/RIKX3Tgt/fC7Ctk8gUTBrhPzCWYPbptyN?= =?us-ascii?Q?mSMIdlpKP3MuXnG+joTPpEDrn/6fgzRJjL0stWvxsLbDiOxDKO0yKjaidJPV?= =?us-ascii?Q?2m0svOI9+/Zl50tYjZfdylgQBJBy4xETl3MUWUfZUjaTsLzwi5Hm3yoh6kEY?= =?us-ascii?Q?9ooerOAJEsEs0P/nrrsYRRVStzNL89WZtDde/q8k0Ty3flDB6LpbkHa6xBv3?= =?us-ascii?Q?qvnYp9UM41kJspQ17w66PidEc9nR4Ql1oPIL3gdDQffXYMYx8tGnO10Acyil?= =?us-ascii?Q?NyGT/R1ScVk+v8Y5KFI9DKVCB5BTFTOk21vf6QCpIhKiI8EMlLmZB4gxpePo?= =?us-ascii?Q?6N3kRtMmdSUc/XmiA4UK0fu7uSCBnFHt/wptYwf7B2KuIQqed6IJkrdC3+O2?= =?us-ascii?Q?tA0cYLVhmIJ0IbxT0kuFRS5GKkFQcdPxnjoqB4gze8GPMSE/Q9ZypZV6ij7q?= =?us-ascii?Q?AgrL87/nOusOZuQ/GbKtZk5ZT950/jEDv0pSqAFzbVfvDCVz0Vi8M6Aq22VJ?= =?us-ascii?Q?9w=3D=3D?= X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 88b2bbf3-bd6e-4478-335e-08da7928eca7 X-MS-Exchange-CrossTenant-AuthSource: DB6P190MB0310.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 10:29:50.3785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: us0Gfhtx/cWDcbh2IIaiYnLP5RfYGcFnAZWXDtVuzahk0zupgqVSjXUbfP0b6VluXpQGVjK0fLgWaclqbqqtHmyxdp1WQWztRc0Nz7i6rJk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1P190MB0989 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adrian, On Mon, Aug 08, 2022 at 12:52:37PM +0300, Vadym Kochan wrote: > Hi Adrian, > > On Mon, Aug 08, 2022 at 12:19:10PM +0300, Adrian Hunter wrote: > > On 1/08/22 12:30, Vadym Kochan wrote: > > > Hi Florian, > > > > > > On Wed, Jul 27, 2022 at 07:45:32PM +0300, Vadym Kochan wrote: > > >> Hi Florian, > > >> > > >> On Tue, Jul 26, 2022 at 10:37:46AM -0700, Florian Fainelli wrote: > > >>> On 7/26/22 10:07, Vadym Kochan wrote: > > >>>> From: Elad Nachman > > >>>> > > >>>> There is a limitation on AC5 SoC that mmc controller > > >>>> can't have DMA access over 2G memory. > > >>>> > > >>>> Signed-off-by: Elad Nachman > > >>>> Signed-off-by: Vadym Kochan > > >>>> --- > > >>>> drivers/mmc/host/sdhci-xenon.c | 13 +++++++++++++ > > >>>> 1 file changed, 13 insertions(+) > > >>>> > > >>>> diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c > > >>>> index 08e838400b52..666d06b58564 100644 > > >>>> --- a/drivers/mmc/host/sdhci-xenon.c > > >>>> +++ b/drivers/mmc/host/sdhci-xenon.c > > >>>> @@ -18,6 +18,7 @@ > > >>>> #include > > >>>> #include > > >>>> #include > > >>>> +#include > > >>>> > > >>>> #include "sdhci-pltfm.h" > > >>>> #include "sdhci-xenon.h" > > >>>> @@ -422,6 +423,8 @@ static int xenon_probe_params(struct platform_device *pdev) > > >>>> struct xenon_priv *priv = sdhci_pltfm_priv(pltfm_host); > > >>>> u32 sdhc_id, nr_sdhc; > > >>>> u32 tuning_count; > > >>>> + struct device_node *np = pdev->dev.of_node; > > >>>> + struct sysinfo si; > > >>>> > > >>>> /* Disable HS200 on Armada AP806 */ > > >>>> if (priv->hw_version == XENON_AP806) > > >>>> @@ -450,6 +453,15 @@ static int xenon_probe_params(struct platform_device *pdev) > > >>>> } > > >>>> priv->tuning_count = tuning_count; > > >>>> > > >>>> + si_meminfo(&si); > > >>>> + > > >>>> + if (of_device_is_compatible(np, "marvell,ac5-sdhci") && > > >>>> + ((si.totalram * si.mem_unit) > 0x80000000 /*2G*/)) { > > >>> > > >>> Why not limit the DMA mask of the device and ensure, that bounce buffers get used so you can still do DMA? > > >>> > > >>> Also, you ought to be able to describe that limitation using Device Tree (assuming this is an option) and declaring a dedicated bus node for the SDHCI controller and providing a suitable dma-ranges property, see: arch/arm/boot/dts/bcm2711.dtsi and the 'soc' node for such examples. > > >>> > > >>> > > >> > > > > > > I could use DMA only in 2 ways: > > > > > > #1 Use sdhci bounce buffer with SDMA mode > > > > > > But there was the issue that SDMA requires that SDHCI v4 mode should > > > be enabled, and when I enable it via sdhci_enable_v4_mode(host) > > > then I got error that EXT_CSD can't be recognized. > > > > > > But if I comment this line in sdhci.c: > > > > > > int sdhci_setup_host(struct sdhci_host *host) > > > { > > > ... > > > > > > /* SDMA does not support 64-bit DMA if v4 mode not set */ > > > if ((host->flags & SDHCI_USE_64_BIT_DMA) && !host->v4_mode) { > > > pr_info("XXX SDMA does not support 64-bit DMA if v4 mode not set\n"); > > > host->flags &= ~SDHCI_USE_SDMA; > > > } > > > > > > ... > > > } > > > > > > then everything is OK. > > > > > > #2 Use restricted-dma-pool in device-tree > > > > > > But I am not sure if it is good solution compared to #1. > > > > > > Setting only DMA mask did not help because after some time I got > > > "DMA overflow address" error stack-traces. > > > > AFAICT using a DMA mask is the correct way to solve this. If that > > reveals another issue then that must be resolved also. Can you show > > the stack traces and what kernel they are from? > > > Not sure but the last thing I can think about mask and auto-bouncing is related to ?: static void mmc_setup_queue(struct mmc_queue *mq, struct mmc_card *card) { ... if (!mmc_dev(host)->dma_mask || !*mmc_dev(host)->dma_mask) blk_queue_bounce_limit(mq->queue, BLK_BOUNCE_HIGH); ... } Then theoretically block subsystem will do the bounce buffering, in that case I need to set 0 dma mask for mmc_host->class_device, at least it looks like so for me. Regards, > The Linux version is next-20220808 > > Here is a stacktrace: > > [ 40.537028] ------------[ cut here ]------------ > [ 40.541698] xenon-sdhci 805c0000.sdhci: DMA addr > 0x00000002ff700000+40960 overflow (mask 27fffffff, bus limit 0). > [ 40.551968] WARNING: CPU: 0 PID: 7 at kernel/dma/direct.h:103 > dma_direct_map_sg+0x28c/0x2b0 > [ 40.560321] Modules linked in: uio_pdrv_genirq > [ 40.564766] CPU: 0 PID: 7 Comm: kworker/0:0H Not tainted > 5.19.0-next-20220808 #20 > [ 40.572236] Hardware name: Marvell A0-AC5X Board (DT) > [ 40.577278] Workqueue: kblockd blk_mq_run_work_fn > [ 40.581980] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS > BTYPE=--) > [ 40.588929] pc : dma_direct_map_sg+0x28c/0x2b0 > [ 40.593366] lr : dma_direct_map_sg+0x28c/0x2b0 > [ 40.597801] sp : ffff80000a6eba20 > [ 40.601107] x29: ffff80000a6eba20 x28: ffff000006d66080 x27: > 0000000000000004 > [ 40.608233] x26: 0000000000000000 x25: ffff0000004de810 x24: > 0000000000000000 > [ 40.615358] x23: 0000000000000002 x22: fffffc0000000000 x21: > ffff800009153360 > [ 40.622484] x20: 0000000000000005 x19: 00000002ff700000 x18: > ffffffffffffffff > [ 40.629609] x17: 766f203036393034 x16: 2b30303030303766 x15: > 6632303030303030 > [ 40.636735] x14: 3078302072646461 x13: ffff80000a433d58 x12: > 00000000000002dc > [ 40.643860] x11: 00000000000000f4 x10: ffff80000a48bd58 x9 : > ffff80000a48bd58 > [ 40.650985] x8 : ffff80000a433d58 x7 : ffff80000a48bd58 x6 : > 0000000000000000 > [ 40.658110] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : > 0000000000000000 > [ 40.665234] x2 : 0000000000000000 x1 : 0000000000000000 x0 : > ffff0000004add00 > [ 40.672360] Call trace: > [ 40.674800] dma_direct_map_sg+0x28c/0x2b0 > [ 40.678890] __dma_map_sg_attrs+0x28/0xa0 > [ 40.682895] dma_map_sg_attrs+0x10/0x30 > [ 40.686725] sdhci_pre_dma_transfer+0xcc/0x150 > [ 40.691165] sdhci_pre_req+0x3c/0x50 > [ 40.694734] mmc_blk_mq_issue_rq+0x25c/0x9d0 > [ 40.698997] mmc_mq_queue_rq+0x118/0x2b0 > [ 40.702912] blk_mq_dispatch_rq_list+0x19c/0x800 > [ 40.707521] blk_mq_do_dispatch_sched+0x2bc/0x350 > [ 40.712218] __blk_mq_sched_dispatch_requests+0x10c/0x160 > [ 40.717608] blk_mq_sched_dispatch_requests+0x40/0x80 > [ 40.722651] __blk_mq_run_hw_queue+0x80/0xc0 > [ 40.726911] blk_mq_run_work_fn+0x24/0x30 > [ 40.730913] process_one_work+0x1d0/0x320 > [ 40.734919] worker_thread+0x14c/0x450 > [ 40.738662] kthread+0x10c/0x110 > [ 40.741885] ret_from_fork+0x10/0x20 > [ 40.745457] ---[ end trace 0000000000000000 ]--- > [ 40.750160] ------------[ cut here ]------------ > [ 40.754770] WARNING: CPU: 0 PID: 7 at drivers/mmc/host/sdhci.c:1152 > sdhci_send_command+0x7fc/0xea0 > [ 40.763719] Modules linked in: uio_pdrv_genirq > [ 40.768149] CPU: 0 PID: 7 Comm: kworker/0:0H Tainted: G W > 5.19.0-next-20220808 #20 > [ 40.777090] Hardware name: Marvell A0-AC5X Board (DT) > [ 40.782129] Workqueue: kblockd blk_mq_run_work_fn > [ 40.786827] pstate: a04000c9 (NzCv daIF +PAN -UAO -TCO -DIT -SSBS > BTYPE=--) > [ 40.793775] pc : sdhci_send_command+0x7fc/0xea0 > [ 40.798297] lr : sdhci_send_command+0x644/0xea0 > [ 40.802821] sp : ffff80000a6eb980 > [ 40.806127] x29: ffff80000a6eb980 x28: ffff80000a6ebcf8 x27: > 0000000000000002 > [ 40.813253] x26: 0000000000000000 x25: 0000000000000000 x24: > ffff0000004237c0 > [ 40.820378] x23: 000000000000000b x22: ffff000006d825b8 x21: > ffff000006d82628 > [ 40.827502] x20: ffff000006d825b8 x19: ffff000000423580 x18: > ffffffffffffffff > [ 40.834627] x17: 766f203036393034 x16: 2b30303030303766 x15: > 6632303030303030 > [ 40.841751] x14: 3078302072646461 x13: ffff80000a433d58 x12: > 00000000000002dc > [ 40.848876] x11: 00000000000000f4 x10: ffff80000a48bd58 x9 : > ffff80000a48bd58 > [ 40.856001] x8 : ffff80000a433d58 x7 : 0000000000000000 x6 : > ffff0000004deaf8 > [ 40.863125] x5 : 0000000000000000 x4 : 0000000000000020 x3 : > 0000000000000000 > [ 40.870250] x2 : 0000000000020401 x1 : 0000000000000001 x0 : > 00000000ffffffe4 > [ 40.877374] Call trace: > [ 40.879813] sdhci_send_command+0x7fc/0xea0 > [ 40.883989] sdhci_send_command_retry+0x40/0x140 > [ 40.888597] sdhci_request+0x70/0xd0 > [ 40.892167] __mmc_start_request+0x68/0x140 > [ 40.896345] mmc_start_request+0x78/0xa0 > [ 40.900260] mmc_blk_mq_issue_rq+0x284/0x9d0 > [ 40.904521] mmc_mq_queue_rq+0x118/0x2b0 > [ 40.908436] blk_mq_dispatch_rq_list+0x19c/0x800 > [ 40.913045] blk_mq_do_dispatch_sched+0x2bc/0x350 > [ 40.917741] __blk_mq_sched_dispatch_requests+0x10c/0x160 > [ 40.923131] blk_mq_sched_dispatch_requests+0x40/0x80 > [ 40.928173] __blk_mq_run_hw_queue+0x80/0xc0 > [ 40.932435] blk_mq_run_work_fn+0x24/0x30 > [ 40.936437] process_one_work+0x1d0/0x320 > [ 40.940442] worker_thread+0x14c/0x450 > [ 40.944184] kthread+0x10c/0x110 > [ 40.947407] ret_from_fork+0x10/0x20 > [ 40.950977] ---[ end trace 0000000000000000 ]--- > [ 40.960738] ------------[ cut here ]------------ > [ 40.965361] WARNING: CPU: 1 PID: 49 at drivers/mmc/host/sdhci.c:1152 > sdhci_send_command+0x7fc/0xea0 > [ 40.974403] Modules linked in: uio_pdrv_genirq > [ 40.978843] CPU: 1 PID: 49 Comm: kworker/1:1H Tainted: G W > 5.19.0-next-20220808 #20 > [ 40.987873] Hardware name: Marvell A0-AC5X Board (DT) > [ 40.992913] Workqueue: kblockd blk_mq_run_work_fn > [ 40.997613] pstate: a04000c9 (NzCv daIF +PAN -UAO -TCO -DIT -SSBS > BTYPE=--) > [ 41.004562] pc : sdhci_send_command+0x7fc/0xea0 > [ 41.009086] lr : sdhci_send_command+0x644/0xea0 > [ 41.013610] sp : ffff80000a9db980 > [ 41.016915] x29: ffff80000a9db980 x28: ffff80000a9dbcf8 x27: > 0000000000000002 > [ 41.024041] x26: 0000000000000000 x25: 0000000000000000 x24: > ffff0000004237c0 > [ 41.031166] x23: 000000000000000b x22: ffff000006d05eb8 x21: > ffff000006d05f28 > [ 41.038291] x20: ffff000006d05eb8 x19: ffff000000423580 x18: > fffffc0003fde640 > [ 41.045416] x17: 0000000000000000 x16: 0000000000000000 x15: > 0000000000000000 > [ 41.052540] x14: 0000000000000002 x13: 0000000000100000 x12: > 0000000000000000 > [ 41.059664] x11: 0000000000000000 x10: 0000000000000b10 x9 : > ffff80000a9db9e0 > [ 41.066789] x8 : ffff000000649af0 x7 : 0000000000000000 x6 : > ffff0000004deaf8 > [ 41.073914] x5 : 0000000000000000 x4 : 0000000000000020 x3 : > 0000000000000000 > [ 41.081039] x2 : 0000000000020401 x1 : 0000000000000001 x0 : > 00000000ffffffe4 > [ 41.088164] Call trace: > [ 41.090603] sdhci_send_command+0x7fc/0xea0 > [ 41.094779] sdhci_send_command_retry+0x40/0x140 > [ 41.099379] sdhci_request+0x70/0xd0 > [ 41.102949] __mmc_start_request+0x68/0x140 > [ 41.107127] mmc_start_request+0x78/0xa0 > [ 41.111042] mmc_blk_mq_issue_rq+0x284/0x9d0 > [ 41.115305] mmc_mq_queue_rq+0x118/0x2b0 > [ 41.119221] blk_mq_dispatch_rq_list+0x19c/0x800 > [ 41.123831] blk_mq_do_dispatch_sched+0x2bc/0x350 > [ 41.128528] __blk_mq_sched_dispatch_requests+0x10c/0x160 > [ 41.133917] blk_mq_sched_dispatch_requests+0x40/0x80 > [ 41.138959] __blk_mq_run_hw_queue+0x80/0xc0 > [ 41.143222] blk_mq_run_work_fn+0x24/0x30 > [ 41.147223] process_one_work+0x1d0/0x320 > [ 41.151230] worker_thread+0x14c/0x450 > [ 41.154973] kthread+0x10c/0x110 > [ 41.158195] ret_from_fork+0x10/0x20 > [ 41.161766] ---[ end trace 0000000000000000 ]--- > [ 41.171543] ------------[ cut here ]------------ > [ 41.176169] WARNING: CPU: 1 PID: 49 at drivers/mmc/host/sdhci.c:1152 > sdhci_send_command+0x7fc/0xea0 > [ 41.185210] Modules linked in: uio_pdrv_genirq > [ 41.189650] CPU: 1 PID: 49 Comm: kworker/1:1H Tainted: G W > 5.19.0-next-20220808 #20 > [ 41.198679] Hardware name: Marvell A0-AC5X Board (DT) > [ 41.203720] Workqueue: kblockd blk_mq_run_work_fn > [ 41.208420] pstate: a04000c9 (NzCv daIF +PAN -UAO -TCO -DIT -SSBS > BTYPE=--) > [ 41.215369] pc : sdhci_send_command+0x7fc/0xea0 > [ 41.219892] lr : sdhci_send_command+0x644/0xea0 > [ 41.224414] sp : ffff80000a9db980 > [ 41.227721] x29: ffff80000a9db980 x28: ffff80000a9dbcf8 x27: > 0000000000000002 > [ 41.234846] x26: 0000000000000000 x25: 0000000000000000 x24: > ffff0000004237c0 > [ 41.241972] x23: 000000000000000b x22: ffff000006d001b8 x21: > ffff000006d00228 > [ 41.249097] x20: ffff000006d001b8 x19: ffff000000423580 x18: > 0000000000000000 > [ 41.256223] x17: 0000000000000000 x16: 0000000000000000 x15: > 0000000000000000 > [ 41.263348] x14: 0000000000000002 x13: 0000000000100000 x12: > 0000000000000000 > [ 41.270473] x11: 0000000000000001 x10: 0000000000000b10 x9 : > ffff80000a9db9e0 > [ 41.277598] x8 : ffff000000649af0 x7 : 0000000000000000 x6 : > ffff0000004deaf8 > [ 41.284722] x5 : 0000000000000000 x4 : 0000000000000020 x3 : > 0000000000000000 > [ 41.291846] x2 : 0000000000020401 x1 : 0000000000000001 x0 : > 00000000ffffffe4 > [ 41.298971] Call trace: > [ 41.301410] sdhci_send_command+0x7fc/0xea0 > [ 41.305588] sdhci_send_command_retry+0x40/0x140 > [ 41.310198] sdhci_request+0x70/0xd0 > [ 41.313769] __mmc_start_request+0x68/0x140 > [ 41.317946] mmc_start_request+0x78/0xa0 > [ 41.321862] mmc_blk_mq_issue_rq+0x284/0x9d0 > [ 41.326125] mmc_mq_queue_rq+0x118/0x2b0 > [ 41.330040] blk_mq_dispatch_rq_list+0x19c/0x800 > [ 41.334649] blk_mq_do_dispatch_sched+0x2bc/0x350 > [ 41.339346] __blk_mq_sched_dispatch_requests+0x10c/0x160 > [ 41.344735] blk_mq_sched_dispatch_requests+0x40/0x80 > [ 41.349779] __blk_mq_run_hw_queue+0x80/0xc0 > [ 41.354040] blk_mq_run_work_fn+0x24/0x30 > [ 41.358041] process_one_work+0x1d0/0x320 > [ 41.362048] worker_thread+0x14c/0x450 > [ 41.365791] kthread+0x10c/0x110 > [ 41.369014] ret_from_fork+0x10/0x20 > [ 41.372584] ---[ end trace 0000000000000000 ]--- > [ 41.382383] ------------[ cut here ]------------ > [ 41.387009] WARNING: CPU: 1 PID: 49 at drivers/mmc/host/sdhci.c:1152 > sdhci_send_command+0x7fc/0xea0 > [ 41.396051] Modules linked in: uio_pdrv_genirq > [ 41.400491] CPU: 1 PID: 49 Comm: kworker/1:1H Tainted: G W > 5.19.0-next-20220808 #20 > [ 41.409520] Hardware name: Marvell A0-AC5X Board (DT) > [ 41.414561] Workqueue: kblockd blk_mq_run_work_fn > [ 41.419261] pstate: a04000c9 (NzCv daIF +PAN -UAO -TCO -DIT -SSBS > BTYPE=--) > [ 41.426210] pc : sdhci_send_command+0x7fc/0xea0 > [ 41.430734] lr : sdhci_send_command+0x644/0xea0 > [ 41.435256] sp : ffff80000a9db980 > [ 41.438562] x29: ffff80000a9db980 x28: ffff80000a9dbcf8 x27: > 0000000000000002 > [ 41.445687] x26: 0000000000000000 x25: 0000000000000000 x24: > ffff0000004237c0 > [ 41.452812] x23: 000000000000000b x22: ffff000006d004b8 x21: > ffff000006d00528 > [ 41.459937] x20: ffff000006d004b8 x19: ffff000000423580 x18: > 0000000000000000 > [ 41.467062] x17: 0000000000000000 x16: 0000000000000000 x15: > 0000000000000000 > [ 41.474187] x14: 0000000000000002 x13: 00000000000ff000 x12: > 0000000000000000 > [ 41.481311] x11: 0000000000000001 x10: 0000000000000b10 x9 : > ffff80000a9db9e0 > [ 41.488436] x8 : ffff000000649af0 x7 : 0000000000000000 x6 : > ffff0000004deaf8 > [ 41.495561] x5 : 0000000000000000 x4 : 0000000000000020 x3 : > 0000000000000000 > [ 41.502685] x2 : 0000000000020401 x1 : 0000000000000001 x0 : > 00000000ffffffe4 > [ 41.509811] Call trace: > [ 41.512250] sdhci_send_command+0x7fc/0xea0 > [ 41.516427] sdhci_send_command_retry+0x40/0x140 > [ 41.521035] sdhci_request+0x70/0xd0 > [ 41.524607] __mmc_start_request+0x68/0x140 > [ 41.528784] mmc_start_request+0x78/0xa0 > [ 41.532699] mmc_blk_mq_issue_rq+0x284/0x9d0 > [ 41.536961] mmc_mq_queue_rq+0x118/0x2b0 > [ 41.540876] blk_mq_dispatch_rq_list+0x19c/0x800 > [ 41.545485] blk_mq_do_dispatch_sched+0x2bc/0x350 > [ 41.550182] __blk_mq_sched_dispatch_requests+0x10c/0x160 > [ 41.555570] blk_mq_sched_dispatch_requests+0x40/0x80 > [ 41.560613] __blk_mq_run_hw_queue+0x80/0xc0 > [ 41.564874] blk_mq_run_work_fn+0x24/0x30 > [ 41.568875] process_one_work+0x1d0/0x320 > [ 41.572881] worker_thread+0x14c/0x450 > [ 41.576624] kthread+0x10c/0x110 > [ 41.579847] ret_from_fork+0x10/0x20 > [ 41.583428] ---[ end trace 0000000000000000 ]--- > > > > > > > >> Do I understand correctly that the swiotlb will be used in case DMA > > >> engine could not map the page in the specified range (limited by dma-ranges or > > >> dma-mask) ? > > >> > > >>> > > >>>> + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > > >>>> + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > > >>>> + dev_info(mmc_dev(mmc), "Disabling DMA because of 2GB DMA access limit.\n"); > > >>>> + } > > >>>> + > > >>>> return xenon_phy_parse_params(dev, host); > > >>>> } > > >>>> > > >>>> @@ -682,6 +694,7 @@ static const struct of_device_id sdhci_xenon_dt_ids[] = { > > >>>> { .compatible = "marvell,armada-ap807-sdhci", .data = (void *)XENON_AP807}, > > >>>> { .compatible = "marvell,armada-cp110-sdhci", .data = (void *)XENON_CP110}, > > >>>> { .compatible = "marvell,armada-3700-sdhci", .data = (void *)XENON_A3700}, > > >>>> + { .compatible = "marvell,ac5-sdhci", .data = (void *)XENON_AP806}, > > >>>> {} > > >>>> }; > > >>>> MODULE_DEVICE_TABLE(of, sdhci_xenon_dt_ids); > > >>> > > >>> > > >>> -- > > >>> Florian > > >> > > >> Thanks, > > >> > > > > > > Regards, > > > > Thanks, > Vadym Kochan