Re: [PATCH] drm/amd/display: set panel orientation before drm_dev_register

[Melissa Wen <mwen@igalia.com>]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

On 08/05, Simon Ser wrote:
> Hi,
> 
> Have you seen [1] and [2]? CC'ing Sean and Hans, it seems like there's
> a disagreement regarding probing early vs. setting the initial value to
> UNKNOWN.
> 
> If a driver doesn't fetch EDIDs before exposing them to user-space,
> then there is an amount of time where the connectors are exposed as
> CONNECTED but their EDID and mode list isn't properly set. But maybe
> that's what the GETCONNECTOR IOCTLs is supposed to do: probe the
> connector, fetch its EDID, return the proper mode list. So maybe
> drivers shouldn't probe early and should let user-space request probes?
> In which case we could create the panel orientation prop with "Normal",
> and update it accordingly when probing. 

Hi Simon,

I've followed these discussions but AFAIU the AMD display issue is not
exactly the same discussed in other drivers because here we are already
able to read EDID and get mode size needed for a quirk orientation
before drm device registration. So, I understand there isn't the need of
setting an initial value to the immutable property and update it later
(and all the issues this later update might cause). Am I missing
something?

> 
> At any rate, I've tested v2 on the Deck and it works properly.
> 
> Tested-by: Simon Ser <contact@emersion.fr>

Thanks for testing it!

Best regards,

Melissa

> 
> Thanks,
> 
> Simon
> 
> [1]: https://lore.kernel.org/dri-devel/CAMavQKJUpYP8jo2JDGMYNBGtbPSSO7z9BAComm5JQoty=HPtJg@mail.gmail.com/
> [2]: https://lore.kernel.org/dri-devel/20220530081910.3947168-1-hsinyi@chromium.org/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]