From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19735C00140 for ; Mon, 8 Aug 2022 20:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244398AbiHHUjg (ORCPT ); Mon, 8 Aug 2022 16:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbiHHUje (ORCPT ); Mon, 8 Aug 2022 16:39:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCD809596; Mon, 8 Aug 2022 13:39:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61FEE60C63; Mon, 8 Aug 2022 20:39:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88607C433D6; Mon, 8 Aug 2022 20:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659991172; bh=bOsZl8AcXb7mOFin6B3q83VOzh/KjSu7QJBidaDPK/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UVVq7nQ09hqex1SsBRtyBQ4G0DVWHOX9y4wVMS+M3xx0lWasENUMZ7yRLa4j5edt6 EkbdXOhjrYEX6vcNqiU7dU+6O7kQE54LKQrgX08EbQQddxMLQlzRMdpJVD2wMmj4cU 6n3IYP9YQXJHE9ltQmHCc0mMX56HoBsImnGMOJBMlSFfXz7fyDz7jbx+10de61nTVN 3RBnGH42xDxHy/nTsgvf1Om0tsLNdIeHIqphuNcChEFmbJqhNTYWgAt/juggZrTGsM aC52pKN7GuKYXYZ2LnZrJCEsWiaLVmWTJql5/3TRb7gJ4BAl/ezgKK4hjesV6G2F1Y /Sy1ED9lJnnnw== Received: by pali.im (Postfix) id A08BFF13; Mon, 8 Aug 2022 22:39:29 +0200 (CEST) Date: Mon, 8 Aug 2022 22:39:29 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: <20220808203929.ci4eardma3jwnroc@pali> References: <20220713125644.3117-1-pali@kernel.org> <20220808202456.lpwvhq22edb56ptf@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 August 2022 22:33:30 Andrew Lunn wrote: > On Mon, Aug 08, 2022 at 10:24:56PM +0200, Pali Rohár wrote: > > PING? > > It is too late for the merge window. > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > index 5ce55bdbb995..02ae1e153288 100644 > > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > @@ -13,7 +13,7 @@ > > > > > > / { > > > model = "Marvell Armada 3720 SoC"; > > > - compatible = "marvell,armada3720", "marvell,armada3710"; > > > + compatible = "marvell,armada3720", "marvell,armada3700"; > > Does it make sense to have a compatible here? The board .dts should > provide it. And if the board does not provide it, we probably want the > board to not boot because it does not have a compatible. > > Andrew Sounds like there should not be a compatible string and model string. I can prepare a followup patch to remove those strings from SoC dtsi file. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9D84C00140 for ; Mon, 8 Aug 2022 20:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jm7Cog5Vl1fn638yRtWY1A2EzC28hPeldDS/syRFoh8=; b=hkl26iIue84bn3 k41TcCWsPKglb7RmDdMfXpP8VSNsiFQ6ogwWbijNNHx9XUbdD5TFvPUsTaJ0MQY+5oHQzCxvL1xEI 6waLdy48EXxZMf5+poW6ZIHM+x/b5Iewj84CcoX4bhSn+iJGUDf+bmexJ6iJ/ttgrkeESs05d4DDF eIjifulJ6M65zwsbJwLvdyyxvlmVJ7Aff5NZJwizTUgo1+u0d3fUZrvxaCHOYXqbCR6Kb9mZQKf2M q+1fx6dGmysVHZuFHiK0+fr2yE2cXb9rHh/wDu6eSnohqylNKxKIIdYXW6gXndk9pvEecXGbdp0B5 A9O7AtwfnhNOMMV8ycyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oL9XG-00FxwE-UV; Mon, 08 Aug 2022 20:39:39 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oL9XD-00Fxum-Kp for linux-arm-kernel@lists.infradead.org; Mon, 08 Aug 2022 20:39:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 06E8CB80E89; Mon, 8 Aug 2022 20:39:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88607C433D6; Mon, 8 Aug 2022 20:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659991172; bh=bOsZl8AcXb7mOFin6B3q83VOzh/KjSu7QJBidaDPK/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UVVq7nQ09hqex1SsBRtyBQ4G0DVWHOX9y4wVMS+M3xx0lWasENUMZ7yRLa4j5edt6 EkbdXOhjrYEX6vcNqiU7dU+6O7kQE54LKQrgX08EbQQddxMLQlzRMdpJVD2wMmj4cU 6n3IYP9YQXJHE9ltQmHCc0mMX56HoBsImnGMOJBMlSFfXz7fyDz7jbx+10de61nTVN 3RBnGH42xDxHy/nTsgvf1Om0tsLNdIeHIqphuNcChEFmbJqhNTYWgAt/juggZrTGsM aC52pKN7GuKYXYZ2LnZrJCEsWiaLVmWTJql5/3TRb7gJ4BAl/ezgKK4hjesV6G2F1Y /Sy1ED9lJnnnw== Received: by pali.im (Postfix) id A08BFF13; Mon, 8 Aug 2022 22:39:29 +0200 (CEST) Date: Mon, 8 Aug 2022 22:39:29 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: <20220808203929.ci4eardma3jwnroc@pali> References: <20220713125644.3117-1-pali@kernel.org> <20220808202456.lpwvhq22edb56ptf@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220808_133935_858885_FC5DDC38 X-CRM114-Status: GOOD ( 19.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uZGF5IDA4IEF1Z3VzdCAyMDIyIDIyOjMzOjMwIEFuZHJldyBMdW5uIHdyb3RlOgo+IE9u IE1vbiwgQXVnIDA4LCAyMDIyIGF0IDEwOjI0OjU2UE0gKzAyMDAsIFBhbGkgUm9ow6FyIHdyb3Rl Ogo+ID4gUElORz8KPiAKPiBJdCBpcyB0b28gbGF0ZSBmb3IgdGhlIG1lcmdlIHdpbmRvdy4KPiAK PiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcy eC5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzJ4LmR0c2kKPiA+ ID4gaW5kZXggNWNlNTViZGJiOTk1Li4wMmFlMWUxNTMyODggMTAwNjQ0Cj4gPiA+IC0tLSBhL2Fy Y2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyeC5kdHNpCj4gPiA+ICsrKyBiL2Fy Y2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyeC5kdHNpCj4gPiA+IEBAIC0xMyw3 ICsxMyw3IEBACj4gPiA+ICAKPiA+ID4gIC8gewo+ID4gPiAgCW1vZGVsID0gIk1hcnZlbGwgQXJt YWRhIDM3MjAgU29DIjsKPiA+ID4gLQljb21wYXRpYmxlID0gIm1hcnZlbGwsYXJtYWRhMzcyMCIs ICJtYXJ2ZWxsLGFybWFkYTM3MTAiOwo+ID4gPiArCWNvbXBhdGlibGUgPSAibWFydmVsbCxhcm1h ZGEzNzIwIiwgIm1hcnZlbGwsYXJtYWRhMzcwMCI7Cj4gCj4gRG9lcyBpdCBtYWtlIHNlbnNlIHRv IGhhdmUgYSBjb21wYXRpYmxlIGhlcmU/IFRoZSBib2FyZCAuZHRzIHNob3VsZAo+IHByb3ZpZGUg aXQuIEFuZCBpZiB0aGUgYm9hcmQgZG9lcyBub3QgcHJvdmlkZSBpdCwgd2UgcHJvYmFibHkgd2Fu dCB0aGUKPiBib2FyZCB0byBub3QgYm9vdCBiZWNhdXNlIGl0IGRvZXMgbm90IGhhdmUgYSBjb21w YXRpYmxlLgo+IAo+ICAgIEFuZHJldwoKU291bmRzIGxpa2UgdGhlcmUgc2hvdWxkIG5vdCBiZSBh IGNvbXBhdGlibGUgc3RyaW5nIGFuZCBtb2RlbCBzdHJpbmcuCgpJIGNhbiBwcmVwYXJlIGEgZm9s bG93dXAgcGF0Y2ggdG8gcmVtb3ZlIHRob3NlIHN0cmluZ3MgZnJvbSBTb0MgZHRzaSBmaWxlLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=