Re: [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver

From: Dmitry Rokosov <DDRokosov@sberdevices.ru>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"stephan@gerhold.net" <stephan@gerhold.net>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	kernel <kernel@sberdevices.ru>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver
Date: Tue, 9 Aug 2022 09:52:49 +0000	[thread overview]
Message-ID: <20220809095251.vpp6arac3pkntdlo@CAB-WSD-L081021.sigma.sbrf.ru> (raw)
In-Reply-To: <20220806155523.37c3e587@jic23-huawei>

On Sat, Aug 06, 2022 at 03:55:23PM +0100, Jonathan Cameron wrote:

[...]

> > 
> > > > +       indio_dev->modes = 0; /* setup buffered mode later */  
> > > 
> > > Why explicit assignment to 0? Doesn't kzalloc() do it for you?  
> > 
> > kzalloc() will do it for me, of course. Previously, I initialized modes to
> > INDIO_DIRECT_MODE to just provide default value for that. Jonathan
> > suggested to replace it with 0. 
> 
> I did?  I wonder what I was smoking that day. 
> Should be set to INDIO_DIRECT_MODE as you had it previously.
> 
> (From what I recall it will work either way but we have in the past had
> core code that checked this and may do again in the future so drivers should
> still be setting it to specify they provide sysfs interfaces to directly read
> the channels).

Jonathan, really sorry I referred to you. I'm confused. This comment was
from Andy in the v3 discussion:

https://lore.kernel.org/linux-iio/CAHp75Vc0+ckNnm2tzLMPrjeFRjwoj3zy0C4koNShFRG3kP8b6w@mail.gmail.com/

I will revert this change. Thank you for feedback.

-- 
Thank you,
Dmitry