From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 047C5C19F2D for ; Tue, 9 Aug 2022 13:00:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6318A849F6; Tue, 9 Aug 2022 15:00:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="MJxxZvBJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 31EA4849EA; Tue, 9 Aug 2022 15:00:12 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1B5DF849EB for ; Tue, 9 Aug 2022 15:00:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BAF761117; Tue, 9 Aug 2022 13:00:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 661D3C433C1; Tue, 9 Aug 2022 13:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660050002; bh=QBDc5Y9yBfVzhkBLT6QiZo7p2yUytRSh+x0I6vgTZtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJxxZvBJLyVXPaDvQ0caO6BPryslsRgYI005eHWGigYc+fDn3ICj4zVI2daOTsXV8 iLcEOmC0XMqLGecSUt6K2dm4qWuDzmoJeBXIqe9CvWnCaE2erB/BN9bbtfdkPo2Sv5 UE3v+KlKQqDnQFs6uBEMBmxnFFK0TMmK+yOhFwO+BeKlteSFi/OwL1Mg9itp1lUkPK cPzSfdnn5wSg62djfYUckPHK28lvL9QKREfXrWsh3aQVzrdfLZgW+blJe9jbTJwIMo pPkLULBeiS8EGJeqHzmZnWD0UKTAxcpBHjTuOIxIXyYviXI7ygEOnQt4zBdWFtX+ti HrSCl0ovDQGTQ== Received: by pali.im (Postfix) id 66514C1F; Tue, 9 Aug 2022 14:59:59 +0200 (CEST) Date: Tue, 9 Aug 2022 14:59:59 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek Vasut Cc: Philip Oberfichtner , u-boot@lists.denx.de, Christoph Niedermaier , Stefano Babic , Marcel Ziswiler , Marek =?utf-8?B?QmVow7pu?= , Peng Fan , u-boot@dh-electronics.com Subject: Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig Message-ID: <20220809125959.jbb2udfqp6ievjr4@pali> References: <20220809100703.3101047-1-pro@denx.de> <20220809100703.3101047-2-pro@denx.de> <20220809105813.aa4vjcyiqm3mnqx4@pali> <41f76858-38d9-284b-1b54-b511f3b3cd67@denx.de> <20220809112151.jhrytuxraqcahzh5@pali> <4c124a1f-28cb-a805-ac6f-fd50ae2ee00e@denx.de> <20220809113224.4mvygsubvtb5wd7a@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tuesday 09 August 2022 13:38:32 Marek Vasut wrote: > On 8/9/22 13:32, Pali Rohár wrote: > > On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: > > > On 8/9/22 13:21, Pali Rohár wrote: > > > > > > (reducing the CC list) > > > > > > > On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: > > > > > On 8/9/22 12:58, Pali Rohár wrote: > > > > > > On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: > > > > > > > This converts CONFIG_SYS_L2_PL310 to Kconfig. > > > > > > ... > > > > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > > > > > index 949ebb46ba..dde06bdd96 100644 > > > > > > > --- a/arch/arm/Kconfig > > > > > > > +++ b/arch/arm/Kconfig > > > > > > > @@ -488,6 +488,10 @@ config TPL_SYS_THUMB_BUILD > > > > > > > density. For ARM architectures that support Thumb2 this flag will > > > > > > > result in Thumb2 code generated by GCC. > > > > > > > +config SYS_L2_PL310 > > > > > > > + bool "ARM PL310 L2 cache controller" > > > > > > > + help > > > > > > > + Enable support for ARM PL310 L2 cache controller in U-Boot > > > > > > > config SYS_L2CACHE_OFF > > > > > > > bool "L2cache off" > > > > > > > diff --git a/arch/arm/mach-mvebu/include/mach/config.h b/arch/arm/mach-mvebu/include/mach/config.h > > > > > > > index 4add0d9e10..0bba0a4cf9 100644 > > > > > > > --- a/arch/arm/mach-mvebu/include/mach/config.h > > > > > > > +++ b/arch/arm/mach-mvebu/include/mach/config.h > > > > > > > @@ -25,8 +25,6 @@ > > > > > > > #define MV88F78X60 /* for the DDR training bin_hdr code */ > > > > > > > #endif > > > > > > > -#define CONFIG_SYS_L2_PL310 > > > > > > > - > > > > > > > #define MV_UART_CONSOLE_BASE MVEBU_UART0_BASE > > > > > > > /* Needed for SPI NOR booting in SPL */ > > > > > > > > > > > > This option is required for mvebu SoC and is not user (de)-selectable. > > > > > > So please do not define it in each individual mvebu board. It would make > > > > > > it harder to introduce a new mvebu board into U-Boot. Instead enable it > > > > > > for mvebu SoCs like it was before this change. It can be done e.g. by > > > > > > "select" Kconfig keyword in mvebu Kconfig file. > > > > > > > > > > Should it rather be 'default y if MVEBU' in that new PL310 Kconfig option ? > > > > > > > > No, because this is just default value of this option and still allows > > > > end-user to de-select this option. > > > > > > > > "select" is IIRC the only way how to force Kconfig to always enable some > > > > symbol without any option for end-user to disable it. > > > > > > > > At least I do not know a way how CONFIG_SYS_L2_PL310 symbol could decide > > > > that it is required for CONFIG_MVEBU. Just symbol CONFIG_MVEBU can > > > > decide that it requires CONFIG_SYS_L2_PL310 symbol (and not in opposite > > > > direction). > > > > > > So why should the user be unable to deselect L2CC support on MVEBU ? > > > I can very well disable L2CC support on MX6 and the platform works without > > > it just fine. Maybe the MVEBU needs to be fixed to support the same instead > > > ? > > > > Well, I'm not sure, currently it is non-deselectable option. Maybe it is > > a bug... but at least change which is doing kconfig conversion should > > not change behavior. > > I agree -- I think your proposal to make this non-user-configurable is > changing the behavior, see: Are you joking here? Seems that missed the point. > Before -- you could comment the entry in include/configs/board.h out to > deselect an option. Is there such board? No - for obvious reason. Sorry, I'm not going to continue in this sausage discussion anymore.