From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B812BC19F2D for ; Tue, 9 Aug 2022 18:35:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D16B82A; Tue, 9 Aug 2022 20:34:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D16B82A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1660070116; bh=7fKyph/VnwgD4gdFhbx/zyFkwIqYkCu78oepQxP2E5o=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=L4CsMd/YpuwWpsLSkxAJe5TkMjx/QEd9YCmVWZEfrp22wQNg/feUdI5c2ZuMvDPgQ jt2WaBH7gW/HiWz+rAwQtId5r0KXY2be13/1yoEPG7SRhIMTumCkv0+tb7F6lf1Kne i4FKS0P/7PeSjNLr/+mj6Kh6k9R+pZBO4FUHcV38= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2BC7CF80162; Tue, 9 Aug 2022 20:34:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A2757F8016C; Tue, 9 Aug 2022 20:34:24 +0200 (CEST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EE86DF80132 for ; Tue, 9 Aug 2022 20:34:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EE86DF80132 Received: by mail-il1-f174.google.com with SMTP id p9so5761072ilq.13 for ; Tue, 09 Aug 2022 11:34:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=8ogzPNWERYDaKhNvvgajn1anoN29b7H+hifJpwoGmHM=; b=Kv3HK6YVt7tVP7QLb8o9lR/qjmloJBisn/4Flj5mNiEjbHS4kSz7omI+hEy9CF3oF/ Ydd0evTVjo0QHCseGkyVFCh8xo70Dbb5woBdYOjRq/NeL+tcuwTphC0KbL/JZgGkVeH9 mgTdXrkUqovLVn4xqrZMv9Yk32sB9AuJOQ1Ds35iJNsUpoLZgBmf6DiJfn1VgW0OJrDM dm3T35TBTA6jvJ0QBrCphQlm3eprisM5DygCEQSLN/gqTva5HASRv9R0E6u319LxzxY+ cwOVW2DNKds1QOebsvrCebwYHD6EXULcrUGXpNZVz+Owyj8oPghvLtkqf9MDQo+X6jnY vfwQ== X-Gm-Message-State: ACgBeo0tVolhVqfBTz2Nn0rsCn28X30S1JDsUgp/hldc9TAKk2VRVhcz hnLG+di28mAULxYohxM9hg== X-Google-Smtp-Source: AA6agR4PJWlLwUSgKHl9yVe2aHvPKGPlQc+9w37Y+GpjWSGItjiB5WV6pAjqzQQreJ8yjLm/o937fQ== X-Received: by 2002:a05:6e02:1a6f:b0:2de:b54a:1ce4 with SMTP id w15-20020a056e021a6f00b002deb54a1ce4mr10551590ilv.284.1660070054833; Tue, 09 Aug 2022 11:34:14 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id n16-20020a056602341000b00684f4b808ffsm1394696ioz.39.2022.08.09.11.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 11:34:14 -0700 (PDT) Received: (nullmailer pid 2158221 invoked by uid 1000); Tue, 09 Aug 2022 18:34:12 -0000 Date: Tue, 9 Aug 2022 12:34:12 -0600 From: Rob Herring To: Zhu Ning Subject: Re: [PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Message-ID: <20220809183412.GA2152771-robh@kernel.org> References: <20220804091800.744316-1-zhuning0077@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220804091800.744316-1-zhuning0077@gmail.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, broonie@kernel.org, Zhu Ning , David Yang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Aug 04, 2022 at 05:17:59PM +0800, Zhu Ning wrote: > Add device tree binding documentation for Everest ES8326 > > Signed-off-by: David Yang > Signed-off-by: Zhu Ning > ---- > v5 tested by dtschema > --- > .../bindings/sound/everest,es8326.yaml | 116 ++++++++++++++++++ > 1 file changed, 116 insertions(+) > create mode 100755 Documentation/devicetree/bindings/sound/everest,es8326.yaml > > diff --git a/Documentation/devicetree/bindings/sound/everest,es8326.yaml b/Documentation/devicetree/bindings/sound/everest,es8326.yaml > new file mode 100755 > index 000000000000..07781408e788 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/everest,es8326.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/everest,es8326.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Everest ES8326 audio CODEC > + > +maintainers: > + - David Yang > + > +properties: > + compatible: > + const: everest,es8326 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: clock for master clock (MCLK) > + > + clock-names: > + items: > + - const: mclk > + > + "#sound-dai-cells": > + const: 0 > + > + everest,jack-pol: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: | > + just the value of reg 57. Bit(3) decides whether the jack polarity is inverted. > + Bit(2) decides whether the button on the headset is inverted. > + Bit(1)/(0) decides the mic properity to be OMTP/CTIA or auto. > + minimum: 0x00 > + maximum: 0x0f > + default: 0x0f > + > + everest,mic1-src: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: > + the value of reg 2A when headset plugged. > + minimum: 0x00 > + maximum: 0x77 > + default: 0x22 > + > + everest,mic2-src: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: > + the value of reg 2A when headset unplugged. > + minimum: 0x00 > + maximum: 0x77 > + default: 0x44 > + > + everest,jack-detect-inverted: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Defined to invert the jack detection. No response to my questions on v3? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D1AC25B08 for ; Tue, 9 Aug 2022 19:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245278AbiHITCe (ORCPT ); Tue, 9 Aug 2022 15:02:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348299AbiHITBc (ORCPT ); Tue, 9 Aug 2022 15:01:32 -0400 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE5392AE32 for ; Tue, 9 Aug 2022 11:34:15 -0700 (PDT) Received: by mail-il1-f170.google.com with SMTP id x2so873047ilp.10 for ; Tue, 09 Aug 2022 11:34:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=8ogzPNWERYDaKhNvvgajn1anoN29b7H+hifJpwoGmHM=; b=ng9yJBK3MTV/2az8H9hy0vSAeNWETpIr4xGU8hj5+FTnrsXa/HjAjG4p3iH1sV0jrE wxLJ72ZD4VC2w6MLqFmrf4JUwXcrYIRy8QBJktnlgwspMIIG6e9pyJBsyiXdWPs7yE6C dy2TNo1Mo5R4urBl9KUUaXYxxpNORGayY0fWGfo6nK1TXYdrDxydSA+XR3cQmy+PmfOW WJTS4acZm0bub2G47fSq2Isdekr3wWaaQ73mwOOB+/yxtMOvO8uTSeTCnnY5hlpjGGp1 oCx8vyecVJ121LgwFWmkv5MovPlPlOxx3k0Qur4RCwLIyqEfFibQRncxM+7mdH/dGhxr 2POA== X-Gm-Message-State: ACgBeo0YJzcJJ4eyDtsxIWLT81AUtusCkT52LrP8B/Qqsk736cIPpcki 9KwxGRI1/jb2oDK/mINiqA== X-Google-Smtp-Source: AA6agR4PJWlLwUSgKHl9yVe2aHvPKGPlQc+9w37Y+GpjWSGItjiB5WV6pAjqzQQreJ8yjLm/o937fQ== X-Received: by 2002:a05:6e02:1a6f:b0:2de:b54a:1ce4 with SMTP id w15-20020a056e021a6f00b002deb54a1ce4mr10551590ilv.284.1660070054833; Tue, 09 Aug 2022 11:34:14 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id n16-20020a056602341000b00684f4b808ffsm1394696ioz.39.2022.08.09.11.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 11:34:14 -0700 (PDT) Received: (nullmailer pid 2158221 invoked by uid 1000); Tue, 09 Aug 2022 18:34:12 -0000 Date: Tue, 9 Aug 2022 12:34:12 -0600 From: Rob Herring To: Zhu Ning Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, broonie@kernel.org, devicetree@vger.kernel.org, David Yang , Zhu Ning Subject: Re: [PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Message-ID: <20220809183412.GA2152771-robh@kernel.org> References: <20220804091800.744316-1-zhuning0077@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220804091800.744316-1-zhuning0077@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 04, 2022 at 05:17:59PM +0800, Zhu Ning wrote: > Add device tree binding documentation for Everest ES8326 > > Signed-off-by: David Yang > Signed-off-by: Zhu Ning > ---- > v5 tested by dtschema > --- > .../bindings/sound/everest,es8326.yaml | 116 ++++++++++++++++++ > 1 file changed, 116 insertions(+) > create mode 100755 Documentation/devicetree/bindings/sound/everest,es8326.yaml > > diff --git a/Documentation/devicetree/bindings/sound/everest,es8326.yaml b/Documentation/devicetree/bindings/sound/everest,es8326.yaml > new file mode 100755 > index 000000000000..07781408e788 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/everest,es8326.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/everest,es8326.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Everest ES8326 audio CODEC > + > +maintainers: > + - David Yang > + > +properties: > + compatible: > + const: everest,es8326 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: clock for master clock (MCLK) > + > + clock-names: > + items: > + - const: mclk > + > + "#sound-dai-cells": > + const: 0 > + > + everest,jack-pol: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: | > + just the value of reg 57. Bit(3) decides whether the jack polarity is inverted. > + Bit(2) decides whether the button on the headset is inverted. > + Bit(1)/(0) decides the mic properity to be OMTP/CTIA or auto. > + minimum: 0x00 > + maximum: 0x0f > + default: 0x0f > + > + everest,mic1-src: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: > + the value of reg 2A when headset plugged. > + minimum: 0x00 > + maximum: 0x77 > + default: 0x22 > + > + everest,mic2-src: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: > + the value of reg 2A when headset unplugged. > + minimum: 0x00 > + maximum: 0x77 > + default: 0x44 > + > + everest,jack-detect-inverted: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Defined to invert the jack detection. No response to my questions on v3? Rob