From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A26FAC00140 for ; Wed, 10 Aug 2022 12:29:55 +0000 (UTC) Received: from localhost ([::1]:50948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLkqQ-00054i-JY for qemu-devel@archiver.kernel.org; Wed, 10 Aug 2022 08:29:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLkot-0002Da-Gz for qemu-devel@nongnu.org; Wed, 10 Aug 2022 08:28:19 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:39728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLkos-0002lo-1q for qemu-devel@nongnu.org; Wed, 10 Aug 2022 08:28:19 -0400 Received: by mail-wr1-x42e.google.com with SMTP id h13so17582914wrf.6 for ; Wed, 10 Aug 2022 05:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=t8nZ21QBoIE3muUsD8yEsXo6tW6EUTtAFupwkvuEGSA=; b=e6WO8r8/Hf1Q8zlWjiN0wvxkw4t13pwYBjmAHW45HdRwQQBGeV+stlw6shMdbYJkco O72Va7RIXq0RY9CmG0hLLXeoB/2VPnWa8jOG8h6mWNdX3TlD744xtNq3f5lQRcqH+uzt x8GVoo/VYCF7kgViwnygdbDovzEZtmNh0nHaiCGy46fl/IKOaLBAHVL+iUSSyjSaSyAJ 5uSVfZ+4Hjny9eCsbmIUFvhcNJ7EhhwAVUwwIgD3KCaR6s6Kyps8s6NDkVrYgrCSiCTo l8HBrenSxmO1+0swLXFIH5DU8rgqub8xP/kmnbwC9IzEQY0zIxNrlrAWhummVmxqcD8W V++g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=t8nZ21QBoIE3muUsD8yEsXo6tW6EUTtAFupwkvuEGSA=; b=rcMUFc0p2jWth9BbasBjpbMixlv62jFzur+f5MidBJ70LQU0Cp/D3ZtL9W42bdTquV p/qQ7Gi0K9KmGtLMU2r2Ed3MlfmuWac0u6vHw5WYHRCSiztfhJoPsVfPiphhEiHr4X3U payaXnMN2B6rhvMyjKW7vZ+ZvtxEwCRRwkXD67PcGgVk+nZ4TFAuujjtAfdo2s03Mugj 2psZN6LGOhdNlEkYaW8gQxfJxQ03gPHWsmLjHDMOY3A6wLhyI9AoZGagVnX+NJIr6a9C YLJSBhfPKaeHFpZEZVnUrJqrP8ZeTlUjjlFxlD66Tqp/H9Zi0f0KjkzVEoYSPWFqHOgH I+YA== X-Gm-Message-State: ACgBeo3wyMF1qXMzgE6OvI4l29Jq201XJKBoFS9h1hkzM2o0IHnYh26z MUfNkun93HPiFb7i3nOA70Tqog== X-Google-Smtp-Source: AA6agR7Rn6mn7wqGOf2234+z3bF1WYE6OqweGDrHl4aMryzAcmE4ofn52dt4wi3kJtokVzeB8pPZWQ== X-Received: by 2002:a5d:64a4:0:b0:220:b43e:d600 with SMTP id m4-20020a5d64a4000000b00220b43ed600mr16903522wrp.27.1660134496474; Wed, 10 Aug 2022 05:28:16 -0700 (PDT) Received: from localhost (cst2-173-67.cust.vodafone.cz. [31.30.173.67]) by smtp.gmail.com with ESMTPSA id c10-20020adffb4a000000b0021f1ec8776fsm15829553wrs.61.2022.08.10.05.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 05:28:15 -0700 (PDT) Date: Wed, 10 Aug 2022 14:28:14 +0200 From: Andrew Jones To: Ben Dooks Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Alistair.Francis@wdc.com, peter.maydell@linaro.org, qemu-arm@nongnu.org Subject: Re: [PATCH v4 2/6] hw/core: don't check return on qemu_fdt_setprop_string_array() Message-ID: <20220810122814.yg6rz7jnr7mqxatx@kamzik> References: <20220809185639.750345-1-qemu@ben.fluff.org> <20220809185639.750345-3-qemu@ben.fluff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220809185639.750345-3-qemu@ben.fluff.org> Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=ajones@ventanamicro.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 09, 2022 at 07:56:36PM +0100, Ben Dooks wrote: > The qemu_fdt_setprop_string_array() does not return error codes and > will call exit() if any of the fdt calls fails (and should print an > error with the node being altered). This is done to prepare for the > change for qemu_fdt_setprop_strings() helper which does not return > any error codes (hw/core/guest-loader.c is the only place where an > return is checked). > > Signed-off-by: Ben Dooks > --- > hw/core/guest-loader.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c > index 391c875a29..c61ebc4144 100644 > --- a/hw/core/guest-loader.c > +++ b/hw/core/guest-loader.c > @@ -57,25 +57,17 @@ static void loader_insert_platform_data(GuestLoaderState *s, int size, > > if (s->kernel) { > const char *compat[2] = { "multiboot,module", "multiboot,kernel" }; > - if (qemu_fdt_setprop_string_array(fdt, node, "compatible", > - (char **) &compat, > - ARRAY_SIZE(compat)) < 0) { > - error_setg(errp, "couldn't set %s/compatible", node); > - return; > - } > + qemu_fdt_setprop_string_array(fdt, node, "compatible", > + (char **) &compat, > + ARRAY_SIZE(compat)); > if (s->args) { > - if (qemu_fdt_setprop_string(fdt, node, "bootargs", s->args) < 0) { > - error_setg(errp, "couldn't set %s/bootargs", node); > - } > + qemu_fdt_setprop_string(fdt, node, "bootargs", s->args); > } > } else if (s->initrd) { > const char *compat[2] = { "multiboot,module", "multiboot,ramdisk" }; > - if (qemu_fdt_setprop_string_array(fdt, node, "compatible", > - (char **) &compat, > - ARRAY_SIZE(compat)) < 0) { > - error_setg(errp, "couldn't set %s/compatible", node); > - return; > - } > + qemu_fdt_setprop_string_array(fdt, node, "compatible", > + (char **) &compat, > + ARRAY_SIZE(compat)); > } > } > > -- > 2.35.1 > > Reviewed-by: Andrew Jones