From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org, Julien Grall <jgrall@amazon.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH 1/7] xen/arm64: head: Don't set x22 and update the documentation
Date: Fri, 12 Aug 2022 20:24:40 +0100 [thread overview]
Message-ID: <20220812192448.43016-2-julien@xen.org> (raw)
In-Reply-To: <20220812192448.43016-1-julien@xen.org>
From: Julien Grall <jgrall@amazon.com>
Since commit 7e14a47e7c73 ("xen/arm64: head Rework and document
launch()"), the boot code is setting x22 but not read it.
So remove the two instructions setting x22 and update the documentation
to show x22 has no specific purpose.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/arch/arm/arm64/head.S | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 1babcc65d7c9..26cc7705f556 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -71,7 +71,7 @@
* x19 - paddr(start)
* x20 - phys offset
* x21 - DTB address (boot cpu only)
- * x22 - is_secondary_cpu
+ * x22 -
* x23 - UART address
* x24 -
* x25 -
@@ -305,8 +305,6 @@ real_start_efi:
#endif
PRINT("- Boot CPU booting -\r\n")
- mov x22, #0 /* x22 := is_secondary_cpu */
-
bl check_cpu_mode
bl cpu_init
bl create_page_tables
@@ -345,8 +343,6 @@ GLOBAL(init_secondary)
adr x19, start /* x19 := paddr (start) */
sub x20, x19, x0 /* x20 := phys-offset */
- mov x22, #1 /* x22 := is_secondary_cpu */
-
mrs x0, mpidr_el1
ldr x13, =(~MPIDR_HWID_MASK)
bic x24, x0, x13 /* Mask out flags to get CPU ID */
--
2.37.1
next prev parent reply other threads:[~2022-08-12 19:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 19:24 [PATCH 0/7] xen/arm: More clean-ups and improvement Julien Grall
2022-08-12 19:24 ` Julien Grall [this message]
2022-08-15 1:36 ` [PATCH 1/7] xen/arm64: head: Don't set x22 and update the documentation Wei Chen
2022-08-15 13:43 ` Bertrand Marquis
2022-08-12 19:24 ` [PATCH 2/7] xen/arm64: head: Introduce get_table_slot() and use it Julien Grall
2022-08-15 1:45 ` Wei Chen
2022-08-15 14:45 ` Bertrand Marquis
2022-08-15 16:44 ` Julien Grall
2022-08-16 7:36 ` Bertrand Marquis
2022-08-12 19:24 ` [PATCH 3/7] xen/arm32: " Julien Grall
2022-08-15 1:48 ` Wei Chen
2022-08-15 14:56 ` Bertrand Marquis
2022-08-12 19:24 ` [PATCH 4/7] xen/arm32: heap: Rework adr_l so it doesn't rely on where Xen is loaded Julien Grall
2022-08-15 1:56 ` Wei Chen
2022-08-15 15:28 ` Bertrand Marquis
2022-08-12 19:24 ` [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str Julien Grall
2022-08-15 1:57 ` Jiamei Xie
2022-08-15 2:05 ` Wei Chen
2022-08-15 6:43 ` Jan Beulich
2022-08-15 8:17 ` Julien Grall
2022-08-15 8:21 ` Jan Beulich
2022-08-15 16:46 ` Julien Grall
2022-08-15 16:26 ` Bertrand Marquis
2022-08-12 19:24 ` [PATCH 6/7] xen/arm: Tweak the dump page-table walk output Julien Grall
2022-08-15 1:32 ` Henry Wang
2022-08-15 16:12 ` Bertrand Marquis
2022-08-12 19:24 ` [PATCH 7/8] patch arm32-tweak-enable-mmu.patch Julien Grall
2022-08-12 19:24 ` [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort Julien Grall
2022-08-15 1:40 ` Henry Wang
2022-08-15 16:47 ` Julien Grall
2022-08-16 3:29 ` Henry Wang
2022-08-31 19:12 ` Julien Grall
2022-08-15 16:39 ` Bertrand Marquis
2022-08-15 17:04 ` Julien Grall
2022-08-16 7:28 ` Bertrand Marquis
2022-08-31 19:17 ` Julien Grall
2022-08-12 19:24 ` [PATCH 8/8] " Julien Grall
2022-08-15 16:48 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812192448.43016-2-julien@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=jgrall@amazon.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.