From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660DF1102 for ; Mon, 15 Aug 2022 07:35:51 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id F351C5804E8; Mon, 15 Aug 2022 03:35:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 15 Aug 2022 03:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660548949; x=1660556149; bh=w9cQgkryOZ rTMuW8XbykeJZc+OJXgmDOa/70G6lboNg=; b=a5Ds27l9BT9gOjMBPCN8BzkuxZ JYLjsFx9gxDEY5jvI8+yLp7UJhD8WWmUdMHgdMOd1+jOTTL6z6nO8sE7C04QdVFr WKsmIChwrzUXFabb1EMJXVQUvs36XecJXmNqauTih8YUfEcCmz9tGvqhOxKqqKcj V8PxpauTR8IPSeHQMXP8A1pOzhALkkV1LapqiQ18CfJBZ5Myw3Oub8ZkCER5t6de DGF7ZEZAWC9+fYOH2qU0+/iopU/2mhJ+BdQA+1f9d3uq5a0rZ+HwzKciVD4pdXgQ leyj4feuLXBwYeqpUYKFT7cHsJfnGIXzODBJ4ELoFiRSvbxzpycNVsH8UrUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660548949; x=1660556149; bh=w9cQgkryOZrTMuW8XbykeJZc+OJX gmDOa/70G6lboNg=; b=EtirkQGRowRlx/E866o7sqMqyKYnM9kxioAwm+IzTakk qlysK9fam5BbvguehMYjkavviohBTL9rUlcSWF2QqgNO0MugdbsK1LeJVco4qE7z yuHH7FtGIqkC0iPFYWP3Zju9/czFX8FIaPHUOv17FKKmKwI0HDJ+gjyObV+csWXM B6XLw8tA4p4xn1EgA3TC4FfCsCMOEYtEgaoPMf4Ws4DyenyhpoE/C3YkXYJUGQBA xbuxhiYH+MYXdh4rLmhAfUSRRDZzxQRmVesNvIjYZwZlgRZQIBjq5hnm1zu8uc7H cNAC7YU2FuVXeXa2CE5pv/tdOanE4QGLbhHMLc7yAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepieehffffvefgiedthfeiieeutdfgffekhfehgfehgfeiuddutdfftdek ffehheevnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordht vggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Aug 2022 03:35:48 -0400 (EDT) Date: Mon, 15 Aug 2022 09:35:46 +0200 From: Maxime Ripard To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 03/35] drm/atomic: Add TV subconnector property to get/set_property Message-ID: <20220815073546.4isrl7o3bt5g23pk@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-3-3d53ae722097@cerno.tech> <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u67ey6tc73oyu5na" Content-Disposition: inline In-Reply-To: <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> --u67ey6tc73oyu5na Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Noralf, Thanks for your review On Mon, Aug 08, 2022 at 02:30:42PM +0200, Noralf Tr=F8nnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > The subconnector property was created by drm_mode_create_tv_properties(= ), > > but wasn't exposed to the userspace through the generic > > atomic_get/set_property implementation, and wasn't stored in any generic > > state structure. > >=20 > > Let's solve this. > >=20 > > Signed-off-by: Maxime Ripard > > I just realised that this and the select_subconnector property isn't > used by any drivers. Do you plan to use them? Maybe they don't need to > be wired up at all. I'm not sure really It's true that the subconnector and select_subconnector fields in the TV connector state aren't used by any driver, but the ch7006 and nouveau will update the property content through a call to drm_object_property_set_value https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i2c/ch7006_d= rv.c#L217 https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/nouveau/disp= nv04/tvnv17.c#L185 I think it could still be useful to report it in the connector state, if only for consistency? Maxime --u67ey6tc73oyu5na Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvn3UgAKCRDj7w1vZxhR xbmZAQD5nsl1fKLqTQPIrC0VdS9xyWDxecKIIygi1DB180AxtgEA6DpFUfV8x3sb JZ8Mmo3OvmOSy7NnGeEzHLlA/1/Mtg0= =joBf -----END PGP SIGNATURE----- --u67ey6tc73oyu5na-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF63BC00140 for ; Mon, 15 Aug 2022 07:36:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B045B00D3; Mon, 15 Aug 2022 07:36:18 +0000 (UTC) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FBB5AFD6E for ; Mon, 15 Aug 2022 07:35:50 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id F351C5804E8; Mon, 15 Aug 2022 03:35:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 15 Aug 2022 03:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660548949; x=1660556149; bh=w9cQgkryOZ rTMuW8XbykeJZc+OJXgmDOa/70G6lboNg=; b=a5Ds27l9BT9gOjMBPCN8BzkuxZ JYLjsFx9gxDEY5jvI8+yLp7UJhD8WWmUdMHgdMOd1+jOTTL6z6nO8sE7C04QdVFr WKsmIChwrzUXFabb1EMJXVQUvs36XecJXmNqauTih8YUfEcCmz9tGvqhOxKqqKcj V8PxpauTR8IPSeHQMXP8A1pOzhALkkV1LapqiQ18CfJBZ5Myw3Oub8ZkCER5t6de DGF7ZEZAWC9+fYOH2qU0+/iopU/2mhJ+BdQA+1f9d3uq5a0rZ+HwzKciVD4pdXgQ leyj4feuLXBwYeqpUYKFT7cHsJfnGIXzODBJ4ELoFiRSvbxzpycNVsH8UrUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660548949; x=1660556149; bh=w9cQgkryOZrTMuW8XbykeJZc+OJX gmDOa/70G6lboNg=; b=EtirkQGRowRlx/E866o7sqMqyKYnM9kxioAwm+IzTakk qlysK9fam5BbvguehMYjkavviohBTL9rUlcSWF2QqgNO0MugdbsK1LeJVco4qE7z yuHH7FtGIqkC0iPFYWP3Zju9/czFX8FIaPHUOv17FKKmKwI0HDJ+gjyObV+csWXM B6XLw8tA4p4xn1EgA3TC4FfCsCMOEYtEgaoPMf4Ws4DyenyhpoE/C3YkXYJUGQBA xbuxhiYH+MYXdh4rLmhAfUSRRDZzxQRmVesNvIjYZwZlgRZQIBjq5hnm1zu8uc7H cNAC7YU2FuVXeXa2CE5pv/tdOanE4QGLbhHMLc7yAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepieehffffvefgiedthfeiieeutdfgffekhfehgfehgfeiuddutdfftdek ffehheevnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordht vggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Aug 2022 03:35:48 -0400 (EDT) Date: Mon, 15 Aug 2022 09:35:46 +0200 From: Maxime Ripard To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Subject: Re: [PATCH v1 03/35] drm/atomic: Add TV subconnector property to get/set_property Message-ID: <20220815073546.4isrl7o3bt5g23pk@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-3-3d53ae722097@cerno.tech> <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u67ey6tc73oyu5na" Content-Disposition: inline In-Reply-To: <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Phil Elwell , Jerome Brunet , Samuel Holland , Kevin Hilman , Jernej Skrabec , Chen-Yu Tsai , Geert Uytterhoeven , linux-sunxi@lists.linux.dev, Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, Mateusz Kwiatkowski , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --u67ey6tc73oyu5na Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Noralf, Thanks for your review On Mon, Aug 08, 2022 at 02:30:42PM +0200, Noralf Tr=F8nnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > The subconnector property was created by drm_mode_create_tv_properties(= ), > > but wasn't exposed to the userspace through the generic > > atomic_get/set_property implementation, and wasn't stored in any generic > > state structure. > >=20 > > Let's solve this. > >=20 > > Signed-off-by: Maxime Ripard > > I just realised that this and the select_subconnector property isn't > used by any drivers. Do you plan to use them? Maybe they don't need to > be wired up at all. I'm not sure really It's true that the subconnector and select_subconnector fields in the TV connector state aren't used by any driver, but the ch7006 and nouveau will update the property content through a call to drm_object_property_set_value https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i2c/ch7006_d= rv.c#L217 https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/nouveau/disp= nv04/tvnv17.c#L185 I think it could still be useful to report it in the connector state, if only for consistency? Maxime --u67ey6tc73oyu5na Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvn3UgAKCRDj7w1vZxhR xbmZAQD5nsl1fKLqTQPIrC0VdS9xyWDxecKIIygi1DB180AxtgEA6DpFUfV8x3sb JZ8Mmo3OvmOSy7NnGeEzHLlA/1/Mtg0= =joBf -----END PGP SIGNATURE----- --u67ey6tc73oyu5na-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9837CC00140 for ; Mon, 15 Aug 2022 07:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5eQP5xPCBW3l0/c+CglIKcYJt8DvtN/h1ogxCDy77y4=; b=Vw2+iDc+FfkIqc6i50KLY/zOG3 cuMjFOoNHny9sgFF5Dn2tnjT3hXnEgfi+H2fH+jg33A/4b9ObQtEQ6Oa8bGF2nZ3Drv4HkmzyHVUZ jj9/ecfySHFRy8f/r/veR/lMdHb24zPggnDcmwifYzjvvKSC9hS5YMBnyOMmyRVglIOQTgm1EBT2s LFip1jKr4BmpaL5VVe5ynoHukgZk0y3PkKFcOBHulvZ5g2o9y296fYlJf5dUBiR8jVL/9/ftRiH+a I6NJZ7aSLwAijRUp0hyT9Pauwj9Tk7JSZSgmMUgQN7U+PXRiGRIn3/pr8V4Zho1eg9OwjCSgjpdwf bsIvGWqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNUef-00CdJ7-GA; Mon, 15 Aug 2022 07:36:57 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNUdb-00Ccld-Mw; Mon, 15 Aug 2022 07:35:53 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id F351C5804E8; Mon, 15 Aug 2022 03:35:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 15 Aug 2022 03:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660548949; x=1660556149; bh=w9cQgkryOZ rTMuW8XbykeJZc+OJXgmDOa/70G6lboNg=; b=a5Ds27l9BT9gOjMBPCN8BzkuxZ JYLjsFx9gxDEY5jvI8+yLp7UJhD8WWmUdMHgdMOd1+jOTTL6z6nO8sE7C04QdVFr WKsmIChwrzUXFabb1EMJXVQUvs36XecJXmNqauTih8YUfEcCmz9tGvqhOxKqqKcj V8PxpauTR8IPSeHQMXP8A1pOzhALkkV1LapqiQ18CfJBZ5Myw3Oub8ZkCER5t6de DGF7ZEZAWC9+fYOH2qU0+/iopU/2mhJ+BdQA+1f9d3uq5a0rZ+HwzKciVD4pdXgQ leyj4feuLXBwYeqpUYKFT7cHsJfnGIXzODBJ4ELoFiRSvbxzpycNVsH8UrUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660548949; x=1660556149; bh=w9cQgkryOZrTMuW8XbykeJZc+OJX gmDOa/70G6lboNg=; b=EtirkQGRowRlx/E866o7sqMqyKYnM9kxioAwm+IzTakk qlysK9fam5BbvguehMYjkavviohBTL9rUlcSWF2QqgNO0MugdbsK1LeJVco4qE7z yuHH7FtGIqkC0iPFYWP3Zju9/czFX8FIaPHUOv17FKKmKwI0HDJ+gjyObV+csWXM B6XLw8tA4p4xn1EgA3TC4FfCsCMOEYtEgaoPMf4Ws4DyenyhpoE/C3YkXYJUGQBA xbuxhiYH+MYXdh4rLmhAfUSRRDZzxQRmVesNvIjYZwZlgRZQIBjq5hnm1zu8uc7H cNAC7YU2FuVXeXa2CE5pv/tdOanE4QGLbhHMLc7yAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepieehffffvefgiedthfeiieeutdfgffekhfehgfehgfeiuddutdfftdek ffehheevnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordht vggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Aug 2022 03:35:48 -0400 (EDT) Date: Mon, 15 Aug 2022 09:35:46 +0200 From: Maxime Ripard To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 03/35] drm/atomic: Add TV subconnector property to get/set_property Message-ID: <20220815073546.4isrl7o3bt5g23pk@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-3-3d53ae722097@cerno.tech> <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> MIME-Version: 1.0 In-Reply-To: <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_003551_994477_8581DC07 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0945835092083288353==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============0945835092083288353== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u67ey6tc73oyu5na" Content-Disposition: inline --u67ey6tc73oyu5na Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Noralf, Thanks for your review On Mon, Aug 08, 2022 at 02:30:42PM +0200, Noralf Tr=F8nnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > The subconnector property was created by drm_mode_create_tv_properties(= ), > > but wasn't exposed to the userspace through the generic > > atomic_get/set_property implementation, and wasn't stored in any generic > > state structure. > >=20 > > Let's solve this. > >=20 > > Signed-off-by: Maxime Ripard > > I just realised that this and the select_subconnector property isn't > used by any drivers. Do you plan to use them? Maybe they don't need to > be wired up at all. I'm not sure really It's true that the subconnector and select_subconnector fields in the TV connector state aren't used by any driver, but the ch7006 and nouveau will update the property content through a call to drm_object_property_set_value https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i2c/ch7006_d= rv.c#L217 https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/nouveau/disp= nv04/tvnv17.c#L185 I think it could still be useful to report it in the connector state, if only for consistency? Maxime --u67ey6tc73oyu5na Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvn3UgAKCRDj7w1vZxhR xbmZAQD5nsl1fKLqTQPIrC0VdS9xyWDxecKIIygi1DB180AxtgEA6DpFUfV8x3sb JZ8Mmo3OvmOSy7NnGeEzHLlA/1/Mtg0= =joBf -----END PGP SIGNATURE----- --u67ey6tc73oyu5na-- --===============0945835092083288353== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============0945835092083288353==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D660C00140 for ; Mon, 15 Aug 2022 07:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F/Id2AY1d6VXwKbR5g78fHX3g/8gAL9mJOizIf3FVuw=; b=JSF9Xi4NCsd0tFTz+aUPvF4z0r BCQesFoh8/rogC24XmML20OQEXz88upZWhYIPNzSpysNtZIra95pIV9y1Bx4crUp6TqE93xLlT8lW QxyXDa7HHC0FrxEiw1uHofcUh9Jy2d1cMky2Xzs2/eshJuX+2XHkehPUI/4BjT6qM79LO0Ez35AU2 58WHOOW3OSCtL5TSEtxVj8iq6Jr35YImheOIMF2ZEr/d5WuV7EcXZeNS/ee5BPN1VAM3jwiCelxdg kg4VGaW/yidlPmc76Lp9xChwBQ6TxiEzgUPSkn//k6QdIWnHmj/xLCm+bwxbNRlvBI4zsTz9UKZoO uYKhrGXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNUen-00CdLK-Pb; Mon, 15 Aug 2022 07:37:07 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNUdb-00Ccld-Mw; Mon, 15 Aug 2022 07:35:53 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id F351C5804E8; Mon, 15 Aug 2022 03:35:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 15 Aug 2022 03:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660548949; x=1660556149; bh=w9cQgkryOZ rTMuW8XbykeJZc+OJXgmDOa/70G6lboNg=; b=a5Ds27l9BT9gOjMBPCN8BzkuxZ JYLjsFx9gxDEY5jvI8+yLp7UJhD8WWmUdMHgdMOd1+jOTTL6z6nO8sE7C04QdVFr WKsmIChwrzUXFabb1EMJXVQUvs36XecJXmNqauTih8YUfEcCmz9tGvqhOxKqqKcj V8PxpauTR8IPSeHQMXP8A1pOzhALkkV1LapqiQ18CfJBZ5Myw3Oub8ZkCER5t6de DGF7ZEZAWC9+fYOH2qU0+/iopU/2mhJ+BdQA+1f9d3uq5a0rZ+HwzKciVD4pdXgQ leyj4feuLXBwYeqpUYKFT7cHsJfnGIXzODBJ4ELoFiRSvbxzpycNVsH8UrUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660548949; x=1660556149; bh=w9cQgkryOZrTMuW8XbykeJZc+OJX gmDOa/70G6lboNg=; b=EtirkQGRowRlx/E866o7sqMqyKYnM9kxioAwm+IzTakk qlysK9fam5BbvguehMYjkavviohBTL9rUlcSWF2QqgNO0MugdbsK1LeJVco4qE7z yuHH7FtGIqkC0iPFYWP3Zju9/czFX8FIaPHUOv17FKKmKwI0HDJ+gjyObV+csWXM B6XLw8tA4p4xn1EgA3TC4FfCsCMOEYtEgaoPMf4Ws4DyenyhpoE/C3YkXYJUGQBA xbuxhiYH+MYXdh4rLmhAfUSRRDZzxQRmVesNvIjYZwZlgRZQIBjq5hnm1zu8uc7H cNAC7YU2FuVXeXa2CE5pv/tdOanE4QGLbhHMLc7yAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepieehffffvefgiedthfeiieeutdfgffekhfehgfehgfeiuddutdfftdek ffehheevnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordht vggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Aug 2022 03:35:48 -0400 (EDT) Date: Mon, 15 Aug 2022 09:35:46 +0200 From: Maxime Ripard To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 03/35] drm/atomic: Add TV subconnector property to get/set_property Message-ID: <20220815073546.4isrl7o3bt5g23pk@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-3-3d53ae722097@cerno.tech> <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> MIME-Version: 1.0 In-Reply-To: <6e47ce2d-25c7-7254-703d-2a1d3bb64373@tronnes.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_003551_994477_8581DC07 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4912052746640623659==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4912052746640623659== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u67ey6tc73oyu5na" Content-Disposition: inline --u67ey6tc73oyu5na Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Noralf, Thanks for your review On Mon, Aug 08, 2022 at 02:30:42PM +0200, Noralf Tr=F8nnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > The subconnector property was created by drm_mode_create_tv_properties(= ), > > but wasn't exposed to the userspace through the generic > > atomic_get/set_property implementation, and wasn't stored in any generic > > state structure. > >=20 > > Let's solve this. > >=20 > > Signed-off-by: Maxime Ripard > > I just realised that this and the select_subconnector property isn't > used by any drivers. Do you plan to use them? Maybe they don't need to > be wired up at all. I'm not sure really It's true that the subconnector and select_subconnector fields in the TV connector state aren't used by any driver, but the ch7006 and nouveau will update the property content through a call to drm_object_property_set_value https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i2c/ch7006_d= rv.c#L217 https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/nouveau/disp= nv04/tvnv17.c#L185 I think it could still be useful to report it in the connector state, if only for consistency? Maxime --u67ey6tc73oyu5na Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvn3UgAKCRDj7w1vZxhR xbmZAQD5nsl1fKLqTQPIrC0VdS9xyWDxecKIIygi1DB180AxtgEA6DpFUfV8x3sb JZ8Mmo3OvmOSy7NnGeEzHLlA/1/Mtg0= =joBf -----END PGP SIGNATURE----- --u67ey6tc73oyu5na-- --===============4912052746640623659== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4912052746640623659==--