* [RFC PATCH] tests/avocado: push default timeout to QemuBaseTest
@ 2022-08-16 13:38 Alex Bennée
2022-08-16 17:45 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2022-08-16 13:38 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, Alex Bennée, Cleber Rosa,
Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal
All of the QEMU tests eventually end up derrived from this class. Move
the default timeout from LinuxTest to ensure we catch them all.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/avocado/avocado_qemu/__init__.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
index ed4853c805..9d17a287cf 100644
--- a/tests/avocado/avocado_qemu/__init__.py
+++ b/tests/avocado/avocado_qemu/__init__.py
@@ -227,6 +227,10 @@ def exec_command_and_wait_for_pattern(test, command,
_console_interaction(test, success_message, failure_message, command + '\r')
class QemuBaseTest(avocado.Test):
+
+ # default timeout for all tests, can be overridden
+ timeout = 900
+
def _get_unique_tag_val(self, tag_name):
"""
Gets a tag value, if unique for a key
@@ -512,7 +516,6 @@ class LinuxTest(LinuxSSHMixIn, QemuSystemTest):
to start with than the more vanilla `QemuSystemTest` class.
"""
- timeout = 900
distro = None
username = 'root'
password = 'password'
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] tests/avocado: push default timeout to QemuBaseTest
2022-08-16 13:38 [RFC PATCH] tests/avocado: push default timeout to QemuBaseTest Alex Bennée
@ 2022-08-16 17:45 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2022-08-16 17:45 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: peter.maydell, Cleber Rosa, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal
On 8/16/22 08:38, Alex Bennée wrote:
> All of the QEMU tests eventually end up derrived from this class. Move
> the default timeout from LinuxTest to ensure we catch them all.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/avocado/avocado_qemu/__init__.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
> index ed4853c805..9d17a287cf 100644
> --- a/tests/avocado/avocado_qemu/__init__.py
> +++ b/tests/avocado/avocado_qemu/__init__.py
> @@ -227,6 +227,10 @@ def exec_command_and_wait_for_pattern(test, command,
> _console_interaction(test, success_message, failure_message, command + '\r')
>
> class QemuBaseTest(avocado.Test):
> +
> + # default timeout for all tests, can be overridden
> + timeout = 900
> +
> def _get_unique_tag_val(self, tag_name):
> """
> Gets a tag value, if unique for a key
> @@ -512,7 +516,6 @@ class LinuxTest(LinuxSSHMixIn, QemuSystemTest):
> to start with than the more vanilla `QemuSystemTest` class.
> """
>
> - timeout = 900
Is 15 minutes really a reasonable default?
r~
> distro = None
> username = 'root'
> password = 'password'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 13:38 [RFC PATCH] tests/avocado: push default timeout to QemuBaseTest Alex Bennée
2022-08-16 17:45 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.