All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: "Yee Lee (李建誼)" <Yee.Lee@mediatek.com>
Cc: Marco Elver <elver@google.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Max Schulze <max.schulze@online.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"naush@raspberrypi.com" <naush@raspberrypi.com>,
	"glider@google.com" <glider@google.com>,
	"dvyukov@google.com" <dvyukov@google.com>,
	"kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>
Subject: Re: kmemleak: Cannot insert 0xffffff806e24f000 into the object search tree (overlaps existing) [RPi CM4]
Date: Tue, 16 Aug 2022 15:26:29 +0100	[thread overview]
Message-ID: <20220816142628.GA11512@willie-the-truck> (raw)
In-Reply-To: <SI2PR03MB57530BCDBB59A9E2DCE38DCA906B9@SI2PR03MB5753.apcprd03.prod.outlook.com>

On Tue, Aug 16, 2022 at 10:52:19AM +0000, Yee Lee (李建誼) wrote:
> The kfence patch(07313a2b29ed) is based on the prior changes in
> kmemleak(0c24e061196c2 , merged in v6.0-rc1), but it shows up earlier in
> v5.19. 
> 
> @akpm
> Andrew, sorry that the short fix tag caused confusing. Can we pull out the
> patch(07313a2b29e) in v5.19.x?
> 
> Kfence: (07313a2b29ed) https://github.com/torvalds/linux/commit/07313a2b29ed1079eaa7722624544b97b3ead84b
> Kmemleak: (0c24e061196c2) https://github.com/torvalds/linux/commit/0c24e061196c21d53328d60f4ad0e5a2b3183343

Hmm, so if I'm understanding correctly then:

 - The kfence fix (07313a2b29ed) depends on a kmemleak change (0c24e061196c2)
   but the patches apply cleanly on their own.

 - The kmemleak change landed in the v6.0 merge window, but the kfence fix
   landed in 5.19 (and has a fixes tag)

So it sounds like we can either:

 1. Revert 07313a2b29ed in the stable trees which contain it and then fix
    the original issue some other way.

or,

 2. Backport 0c24e061196c2 everywhere that has 07313a2b29ed. Judging solely
    by the size of the patch, this doesn't look like a great idea.

Is that right?

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-16 14:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  9:52 kmemleak: Cannot insert 0xffffff806e24f000 into the object search tree (overlaps existing) [RPi CM4] Max Schulze
2022-08-15 12:47 ` Will Deacon
2022-08-15 15:50   ` Marco Elver
2022-08-16 10:52     ` Yee Lee (李建誼)
2022-08-16 14:26       ` Will Deacon [this message]
2022-08-16 14:34         ` Marco Elver
2022-08-16 15:31           ` Catalin Marinas
2022-08-16 15:46             ` Marco Elver
2022-08-16 15:53               ` Catalin Marinas
2022-08-16 23:39         ` Andrew Morton
2022-08-17  6:25           ` Greg Kroah-Hartman
2022-08-17  8:23             ` Catalin Marinas
2022-08-17 15:01               ` Marco Elver
2022-08-17 16:52                 ` Greg Kroah-Hartman
2022-08-17 17:02                   ` Catalin Marinas
2022-08-17 17:23                     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816142628.GA11512@willie-the-truck \
    --to=will@kernel.org \
    --cc=Yee.Lee@mediatek.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=max.schulze@online.de \
    --cc=naush@raspberrypi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.