From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D94714401 for ; Wed, 17 Aug 2022 13:19:01 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id EB4E02B059AF; Wed, 17 Aug 2022 09:18:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Aug 2022 09:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660742338; x=1660749538; bh=l9nnSULWeK Q3XggL/zqDG46qTFmpp//Ck12PCcxE0C4=; b=pF/7j9Cm7g40yrOScl4skNreL2 ccqXhCjvRZznSRSF8iv3BsajgJqsSxeejMYry/aJir12Cq0cDvoWOHMKSqK+hrHV /a27Uah7wwi9OZ7JdFLS7io3iwHSZhBkcRbqLKcFYW0VKdkH3qp7RyiNwZl94f1E zUKVdX0Co++619zrN85L7jZYtou5/rFWIReG9TxjiSrtRfHMVALZK0a2dIAiNPey k5xnYjBQ3midyovFl94hMcQQQnartAKyINKT1f2u5iiYyJQebKsLIWShk3lNd5zG iekKZZiB/p9w/dHaCx4QUo+QmNkBoWYG2huX0B7rx5qHpjlU+GQZnHln1NxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660742338; x=1660749538; bh=l9nnSULWeKQ3XggL/zqDG46qTFmp p//Ck12PCcxE0C4=; b=0yq+TQb2k0Ge8C7gWLSDZxUbaft3Y7NQ2c9RLH0PWcT2 PiTwPZj2vykG414dYWHWPehc5NXyFhrx3qTMKgDlx50h/Eu1NPTeQS4J/i0EBC9H 766vhkSIScDQvoKRkaqRMENnynoZCLR3D9h5DdZD+n40FTRjKuWenUtAJbtZe4fU oO89K0GrZnhFZ107Ch6BFcgp8mVf5U43254oG8WVsCnSXzedtRo8f5LGWaViy1dW F7W+bIb0hNWZMipRiW9UaIRKzNU5ffBRgnHRZj9R6Nd5RGbwMPcStxkuQrKAv5uS IJOmBt7TDmIRVxsyjLN2TIPOE1t6rTNFwJyi5emdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehiedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpedtleekjeeiudefvdfhieffteelhfeivdeliefgieeugffhvdelieffjeei geetjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 09:18:56 -0400 (EDT) Date: Wed, 17 Aug 2022 15:18:54 +0200 From: Maxime Ripard To: Geert Uytterhoeven Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, Linux Kernel Mailing List , Phil Elwell , Mateusz Kwiatkowski , Linux ARM , Dave Stevenson , "open list:ARM/Amlogic Meson..." , DRI Development , Dom Cobley Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property Message-ID: <20220817131854.jwmhqvhfhp77bbr3@houat> References: <20220816132040.uwirtjm5yr6rdd3q@houat> <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> <20220817074710.w4c4xwj7edly2b5p@houat> <20220817111454.pn2iltvyo2drebq7@houat> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pwhi6bupdwzq7ldy" Content-Disposition: inline In-Reply-To: --pwhi6bupdwzq7ldy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wro= te: > > > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard = wrote: > > > > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wr= ote: > > > > > > > > > > > Either you have to add them here (e.g. "hd720p50" and= "hd720p60"), or > > > > > > > > > > > handle them through "@". The latter would i= mpact "[PATCH v1 > > > > > > > > > > > 09/35] drm/modes: Move named modes parsing to a separ= ate function", as > > > > > > > > > > > currently a named mode and a refresh rate can't be sp= ecified both. > > > > > > > > > > > > > > > > > > > > I think the former would make more sense. It simplifies= a bit the > > > > > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode= property as a > > > > > > > > > > > command-line option" uses a separate "tv_mode" option= , and not the main > > > > > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > > > > > > > > > It's a separate story I think, we could have a named mo= de hd720p50, > > > > > > > > > > which would be equivalent to 1280x720,tv_mode=3Dhd720p > > > > > > > > > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=3Dhd720p"? > > > > > > > > > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=3Dhd720p > > > > > > > > > > > > > > Above you said "I think the former would make more sense", so= that > > > > > > > should be "1280x720,tv_mode=3Dhd720p50"? > > > > > > > > > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mod= e=3Dhd720p > > > > > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=3Dhd720p > > > > > > > > > > I disagree: hd720p50 and hd720p60 are different TV modes. > > > > > > > > I agree, and I don't see how that command-line doesn't express that? > > > > > > Oh, I see what you mean: yes, it expresses that. > > > But it is inconsistent with the NTSC/PAL/SECAM/hd{480,576}[ip] modes, > > > where the TV mode specifies both number of lines and frame rate. > > > > Only if we're using a named mode, and naming is hard :) >=20 > That's not true: "640x480,tv_mode=3DPAL-N" would give me a mode with > 625 lines and 25 frames/s, "640x480,tv_mode=3DPAL-M" would give me a > mode with 525 lines and 30 frames/s. In that series, "640x480,tv_mode=3DPAL-N" would be rejected as invalid: https://lore.kernel.org/dri-devel/20220728-rpi-analog-tv-properties-v1-14-3= d53ae722097@cerno.tech/ Maxime --pwhi6bupdwzq7ldy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvzqvgAKCRDj7w1vZxhR xevAAQDN39buWD69Y1UeITS4YCga5URhBHuCskbyb0E4+dbIUQD7BdiRmRfU6P3f TcmNW67KPvbwkbPIv57K49HlmhcZ6AQ= =egIl -----END PGP SIGNATURE----- --pwhi6bupdwzq7ldy-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AA52C25B08 for ; Wed, 17 Aug 2022 13:19:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 498B69291F; Wed, 17 Aug 2022 13:19:15 +0000 (UTC) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8646118A8C6 for ; Wed, 17 Aug 2022 13:19:01 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id EB4E02B059AF; Wed, 17 Aug 2022 09:18:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Aug 2022 09:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660742338; x=1660749538; bh=l9nnSULWeK Q3XggL/zqDG46qTFmpp//Ck12PCcxE0C4=; b=pF/7j9Cm7g40yrOScl4skNreL2 ccqXhCjvRZznSRSF8iv3BsajgJqsSxeejMYry/aJir12Cq0cDvoWOHMKSqK+hrHV /a27Uah7wwi9OZ7JdFLS7io3iwHSZhBkcRbqLKcFYW0VKdkH3qp7RyiNwZl94f1E zUKVdX0Co++619zrN85L7jZYtou5/rFWIReG9TxjiSrtRfHMVALZK0a2dIAiNPey k5xnYjBQ3midyovFl94hMcQQQnartAKyINKT1f2u5iiYyJQebKsLIWShk3lNd5zG iekKZZiB/p9w/dHaCx4QUo+QmNkBoWYG2huX0B7rx5qHpjlU+GQZnHln1NxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660742338; x=1660749538; bh=l9nnSULWeKQ3XggL/zqDG46qTFmp p//Ck12PCcxE0C4=; b=0yq+TQb2k0Ge8C7gWLSDZxUbaft3Y7NQ2c9RLH0PWcT2 PiTwPZj2vykG414dYWHWPehc5NXyFhrx3qTMKgDlx50h/Eu1NPTeQS4J/i0EBC9H 766vhkSIScDQvoKRkaqRMENnynoZCLR3D9h5DdZD+n40FTRjKuWenUtAJbtZe4fU oO89K0GrZnhFZ107Ch6BFcgp8mVf5U43254oG8WVsCnSXzedtRo8f5LGWaViy1dW F7W+bIb0hNWZMipRiW9UaIRKzNU5ffBRgnHRZj9R6Nd5RGbwMPcStxkuQrKAv5uS IJOmBt7TDmIRVxsyjLN2TIPOE1t6rTNFwJyi5emdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehiedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpedtleekjeeiudefvdfhieffteelhfeivdeliefgieeugffhvdelieffjeei geetjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 09:18:56 -0400 (EDT) Date: Wed, 17 Aug 2022 15:18:54 +0200 From: Maxime Ripard To: Geert Uytterhoeven Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property Message-ID: <20220817131854.jwmhqvhfhp77bbr3@houat> References: <20220816132040.uwirtjm5yr6rdd3q@houat> <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> <20220817074710.w4c4xwj7edly2b5p@houat> <20220817111454.pn2iltvyo2drebq7@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pwhi6bupdwzq7ldy" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , David Airlie , DRI Development , Phil Elwell , Jerome Brunet , Samuel Holland , Kevin Hilman , Jernej Skrabec , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Martin Blumenstingl , "open list:ARM/Amlogic Meson..." , Linux ARM , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , Mateusz Kwiatkowski , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --pwhi6bupdwzq7ldy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wro= te: > > > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard = wrote: > > > > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wr= ote: > > > > > > > > > > > Either you have to add them here (e.g. "hd720p50" and= "hd720p60"), or > > > > > > > > > > > handle them through "@". The latter would i= mpact "[PATCH v1 > > > > > > > > > > > 09/35] drm/modes: Move named modes parsing to a separ= ate function", as > > > > > > > > > > > currently a named mode and a refresh rate can't be sp= ecified both. > > > > > > > > > > > > > > > > > > > > I think the former would make more sense. It simplifies= a bit the > > > > > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode= property as a > > > > > > > > > > > command-line option" uses a separate "tv_mode" option= , and not the main > > > > > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > > > > > > > > > It's a separate story I think, we could have a named mo= de hd720p50, > > > > > > > > > > which would be equivalent to 1280x720,tv_mode=3Dhd720p > > > > > > > > > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=3Dhd720p"? > > > > > > > > > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=3Dhd720p > > > > > > > > > > > > > > Above you said "I think the former would make more sense", so= that > > > > > > > should be "1280x720,tv_mode=3Dhd720p50"? > > > > > > > > > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mod= e=3Dhd720p > > > > > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=3Dhd720p > > > > > > > > > > I disagree: hd720p50 and hd720p60 are different TV modes. > > > > > > > > I agree, and I don't see how that command-line doesn't express that? > > > > > > Oh, I see what you mean: yes, it expresses that. > > > But it is inconsistent with the NTSC/PAL/SECAM/hd{480,576}[ip] modes, > > > where the TV mode specifies both number of lines and frame rate. > > > > Only if we're using a named mode, and naming is hard :) >=20 > That's not true: "640x480,tv_mode=3DPAL-N" would give me a mode with > 625 lines and 25 frames/s, "640x480,tv_mode=3DPAL-M" would give me a > mode with 525 lines and 30 frames/s. In that series, "640x480,tv_mode=3DPAL-N" would be rejected as invalid: https://lore.kernel.org/dri-devel/20220728-rpi-analog-tv-properties-v1-14-3= d53ae722097@cerno.tech/ Maxime --pwhi6bupdwzq7ldy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvzqvgAKCRDj7w1vZxhR xevAAQDN39buWD69Y1UeITS4YCga5URhBHuCskbyb0E4+dbIUQD7BdiRmRfU6P3f TcmNW67KPvbwkbPIv57K49HlmhcZ6AQ= =egIl -----END PGP SIGNATURE----- --pwhi6bupdwzq7ldy-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F8E1C25B08 for ; Wed, 17 Aug 2022 13:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nX+UPitilHazAsrU6isVKVhE8MmNXv1EOBedHamgjfs=; b=HtKw3Y+sd8nWyTWhhw08ZIv240 FQ5VMIqGzjG7xyutzO7v5q4QxkspwnLtBf8lITLUIjWb0X3o9os60BAwQIoSqXoJBKN5JFkRTvOye ldBeth9B7GI5405r7PCzU/zNJAl1pFtg9VDU7Lp1yOvqv6fLUFxGLI5q4FnsKpHVSPUSXiif1hzEi WACVR68ioTr9RH+GdKlMH//gzZdxerOHRIR1avAfBoe+RwqwwJ0+AAm5GtzrbVssmuhP1HqQ+uPZr MXPp+X9CXuQXXcXLlZiL49804AxsA90wzN4b6LHNJI3dGilk6JeMCtB4irSh8y6RR9VXIRIEMwhbr coqOF/Bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOIwq-002JXM-Rd; Wed, 17 Aug 2022 13:19:04 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOIwn-002JVh-LQ; Wed, 17 Aug 2022 13:19:03 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id EB4E02B059AF; Wed, 17 Aug 2022 09:18:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Aug 2022 09:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660742338; x=1660749538; bh=l9nnSULWeK Q3XggL/zqDG46qTFmpp//Ck12PCcxE0C4=; b=pF/7j9Cm7g40yrOScl4skNreL2 ccqXhCjvRZznSRSF8iv3BsajgJqsSxeejMYry/aJir12Cq0cDvoWOHMKSqK+hrHV /a27Uah7wwi9OZ7JdFLS7io3iwHSZhBkcRbqLKcFYW0VKdkH3qp7RyiNwZl94f1E zUKVdX0Co++619zrN85L7jZYtou5/rFWIReG9TxjiSrtRfHMVALZK0a2dIAiNPey k5xnYjBQ3midyovFl94hMcQQQnartAKyINKT1f2u5iiYyJQebKsLIWShk3lNd5zG iekKZZiB/p9w/dHaCx4QUo+QmNkBoWYG2huX0B7rx5qHpjlU+GQZnHln1NxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660742338; x=1660749538; bh=l9nnSULWeKQ3XggL/zqDG46qTFmp p//Ck12PCcxE0C4=; b=0yq+TQb2k0Ge8C7gWLSDZxUbaft3Y7NQ2c9RLH0PWcT2 PiTwPZj2vykG414dYWHWPehc5NXyFhrx3qTMKgDlx50h/Eu1NPTeQS4J/i0EBC9H 766vhkSIScDQvoKRkaqRMENnynoZCLR3D9h5DdZD+n40FTRjKuWenUtAJbtZe4fU oO89K0GrZnhFZ107Ch6BFcgp8mVf5U43254oG8WVsCnSXzedtRo8f5LGWaViy1dW F7W+bIb0hNWZMipRiW9UaIRKzNU5ffBRgnHRZj9R6Nd5RGbwMPcStxkuQrKAv5uS IJOmBt7TDmIRVxsyjLN2TIPOE1t6rTNFwJyi5emdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehiedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpedtleekjeeiudefvdfhieffteelhfeivdeliefgieeugffhvdelieffjeei geetjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 09:18:56 -0400 (EDT) Date: Wed, 17 Aug 2022 15:18:54 +0200 From: Maxime Ripard To: Geert Uytterhoeven Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, Linux Kernel Mailing List , Phil Elwell , Mateusz Kwiatkowski , Linux ARM , Dave Stevenson , "open list:ARM/Amlogic Meson..." , DRI Development , Dom Cobley Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property Message-ID: <20220817131854.jwmhqvhfhp77bbr3@houat> References: <20220816132040.uwirtjm5yr6rdd3q@houat> <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> <20220817074710.w4c4xwj7edly2b5p@houat> <20220817111454.pn2iltvyo2drebq7@houat> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220817_061901_776986_BFC09557 X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5315168776827762561==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============5315168776827762561== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pwhi6bupdwzq7ldy" Content-Disposition: inline --pwhi6bupdwzq7ldy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wro= te: > > > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard = wrote: > > > > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wr= ote: > > > > > > > > > > > Either you have to add them here (e.g. "hd720p50" and= "hd720p60"), or > > > > > > > > > > > handle them through "@". The latter would i= mpact "[PATCH v1 > > > > > > > > > > > 09/35] drm/modes: Move named modes parsing to a separ= ate function", as > > > > > > > > > > > currently a named mode and a refresh rate can't be sp= ecified both. > > > > > > > > > > > > > > > > > > > > I think the former would make more sense. It simplifies= a bit the > > > > > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode= property as a > > > > > > > > > > > command-line option" uses a separate "tv_mode" option= , and not the main > > > > > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > > > > > > > > > It's a separate story I think, we could have a named mo= de hd720p50, > > > > > > > > > > which would be equivalent to 1280x720,tv_mode=3Dhd720p > > > > > > > > > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=3Dhd720p"? > > > > > > > > > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=3Dhd720p > > > > > > > > > > > > > > Above you said "I think the former would make more sense", so= that > > > > > > > should be "1280x720,tv_mode=3Dhd720p50"? > > > > > > > > > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mod= e=3Dhd720p > > > > > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=3Dhd720p > > > > > > > > > > I disagree: hd720p50 and hd720p60 are different TV modes. > > > > > > > > I agree, and I don't see how that command-line doesn't express that? > > > > > > Oh, I see what you mean: yes, it expresses that. > > > But it is inconsistent with the NTSC/PAL/SECAM/hd{480,576}[ip] modes, > > > where the TV mode specifies both number of lines and frame rate. > > > > Only if we're using a named mode, and naming is hard :) >=20 > That's not true: "640x480,tv_mode=3DPAL-N" would give me a mode with > 625 lines and 25 frames/s, "640x480,tv_mode=3DPAL-M" would give me a > mode with 525 lines and 30 frames/s. In that series, "640x480,tv_mode=3DPAL-N" would be rejected as invalid: https://lore.kernel.org/dri-devel/20220728-rpi-analog-tv-properties-v1-14-3= d53ae722097@cerno.tech/ Maxime --pwhi6bupdwzq7ldy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvzqvgAKCRDj7w1vZxhR xevAAQDN39buWD69Y1UeITS4YCga5URhBHuCskbyb0E4+dbIUQD7BdiRmRfU6P3f TcmNW67KPvbwkbPIv57K49HlmhcZ6AQ= =egIl -----END PGP SIGNATURE----- --pwhi6bupdwzq7ldy-- --===============5315168776827762561== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============5315168776827762561==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E9D4C25B08 for ; Wed, 17 Aug 2022 13:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YN9XKWAWS6Ti9OW0UxRORvxnvpqlK9Hz3HYMyAaIB4c=; b=iRNEmsq73FKThux64uRMYBGJDe VICRpMOaGIRVufeKn58D2fJQe+b60qB4CxqjP1atB9i8b82hvPskNYXAmpmqKuEjsv463LH+7/g5+ /5SVdiKvujjMH7vBYbruV9jasNeYFCnlV9fJ/NxnA7w+lTcRDV+CIQQrQG64GIQ8jXQGNIvgswPma OOX4uSg9kcRd1blyVbnFfDqvNThnMcfPukFYVUk988TeU8V/gDxZm6j+l4gSW3/3ibwQuhQfYNgY5 WQM2MjVN64QHiQsI6TtaG5CkH7jPMeTyC9T9xxOcg3m0V3094q5HZOawkpJ85fJBCdz2CoKYECBwx ZaBQYXTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOIwr-002JXU-JE; Wed, 17 Aug 2022 13:19:05 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOIwn-002JVh-LQ; Wed, 17 Aug 2022 13:19:03 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id EB4E02B059AF; Wed, 17 Aug 2022 09:18:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Aug 2022 09:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660742338; x=1660749538; bh=l9nnSULWeK Q3XggL/zqDG46qTFmpp//Ck12PCcxE0C4=; b=pF/7j9Cm7g40yrOScl4skNreL2 ccqXhCjvRZznSRSF8iv3BsajgJqsSxeejMYry/aJir12Cq0cDvoWOHMKSqK+hrHV /a27Uah7wwi9OZ7JdFLS7io3iwHSZhBkcRbqLKcFYW0VKdkH3qp7RyiNwZl94f1E zUKVdX0Co++619zrN85L7jZYtou5/rFWIReG9TxjiSrtRfHMVALZK0a2dIAiNPey k5xnYjBQ3midyovFl94hMcQQQnartAKyINKT1f2u5iiYyJQebKsLIWShk3lNd5zG iekKZZiB/p9w/dHaCx4QUo+QmNkBoWYG2huX0B7rx5qHpjlU+GQZnHln1NxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660742338; x=1660749538; bh=l9nnSULWeKQ3XggL/zqDG46qTFmp p//Ck12PCcxE0C4=; b=0yq+TQb2k0Ge8C7gWLSDZxUbaft3Y7NQ2c9RLH0PWcT2 PiTwPZj2vykG414dYWHWPehc5NXyFhrx3qTMKgDlx50h/Eu1NPTeQS4J/i0EBC9H 766vhkSIScDQvoKRkaqRMENnynoZCLR3D9h5DdZD+n40FTRjKuWenUtAJbtZe4fU oO89K0GrZnhFZ107Ch6BFcgp8mVf5U43254oG8WVsCnSXzedtRo8f5LGWaViy1dW F7W+bIb0hNWZMipRiW9UaIRKzNU5ffBRgnHRZj9R6Nd5RGbwMPcStxkuQrKAv5uS IJOmBt7TDmIRVxsyjLN2TIPOE1t6rTNFwJyi5emdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehiedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpedtleekjeeiudefvdfhieffteelhfeivdeliefgieeugffhvdelieffjeei geetjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 09:18:56 -0400 (EDT) Date: Wed, 17 Aug 2022 15:18:54 +0200 From: Maxime Ripard To: Geert Uytterhoeven Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, Linux Kernel Mailing List , Phil Elwell , Mateusz Kwiatkowski , Linux ARM , Dave Stevenson , "open list:ARM/Amlogic Meson..." , DRI Development , Dom Cobley Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property Message-ID: <20220817131854.jwmhqvhfhp77bbr3@houat> References: <20220816132040.uwirtjm5yr6rdd3q@houat> <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> <20220817074710.w4c4xwj7edly2b5p@houat> <20220817111454.pn2iltvyo2drebq7@houat> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220817_061901_776986_BFC09557 X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1973257405933922817==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1973257405933922817== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pwhi6bupdwzq7ldy" Content-Disposition: inline --pwhi6bupdwzq7ldy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 03:05:52PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Wed, Aug 17, 2022 at 1:15 PM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wro= te: > > > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard = wrote: > > > > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wr= ote: > > > > > > > > > > > Either you have to add them here (e.g. "hd720p50" and= "hd720p60"), or > > > > > > > > > > > handle them through "@". The latter would i= mpact "[PATCH v1 > > > > > > > > > > > 09/35] drm/modes: Move named modes parsing to a separ= ate function", as > > > > > > > > > > > currently a named mode and a refresh rate can't be sp= ecified both. > > > > > > > > > > > > > > > > > > > > I think the former would make more sense. It simplifies= a bit the > > > > > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode= property as a > > > > > > > > > > > command-line option" uses a separate "tv_mode" option= , and not the main > > > > > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > > > > > > > > > It's a separate story I think, we could have a named mo= de hd720p50, > > > > > > > > > > which would be equivalent to 1280x720,tv_mode=3Dhd720p > > > > > > > > > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=3Dhd720p"? > > > > > > > > > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=3Dhd720p > > > > > > > > > > > > > > Above you said "I think the former would make more sense", so= that > > > > > > > should be "1280x720,tv_mode=3Dhd720p50"? > > > > > > > > > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mod= e=3Dhd720p > > > > > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=3Dhd720p > > > > > > > > > > I disagree: hd720p50 and hd720p60 are different TV modes. > > > > > > > > I agree, and I don't see how that command-line doesn't express that? > > > > > > Oh, I see what you mean: yes, it expresses that. > > > But it is inconsistent with the NTSC/PAL/SECAM/hd{480,576}[ip] modes, > > > where the TV mode specifies both number of lines and frame rate. > > > > Only if we're using a named mode, and naming is hard :) >=20 > That's not true: "640x480,tv_mode=3DPAL-N" would give me a mode with > 625 lines and 25 frames/s, "640x480,tv_mode=3DPAL-M" would give me a > mode with 525 lines and 30 frames/s. In that series, "640x480,tv_mode=3DPAL-N" would be rejected as invalid: https://lore.kernel.org/dri-devel/20220728-rpi-analog-tv-properties-v1-14-3= d53ae722097@cerno.tech/ Maxime --pwhi6bupdwzq7ldy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvzqvgAKCRDj7w1vZxhR xevAAQDN39buWD69Y1UeITS4YCga5URhBHuCskbyb0E4+dbIUQD7BdiRmRfU6P3f TcmNW67KPvbwkbPIv57K49HlmhcZ6AQ= =egIl -----END PGP SIGNATURE----- --pwhi6bupdwzq7ldy-- --===============1973257405933922817== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1973257405933922817==--