From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oP2Vh-0000jf-3P for mharc-grub-devel@gnu.org; Fri, 19 Aug 2022 09:58:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP2Vf-0000id-JC for grub-devel@gnu.org; Fri, 19 Aug 2022 09:58:03 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:53110) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1oP2Ve-0007Gj-1W for grub-devel@gnu.org; Fri, 19 Aug 2022 09:58:03 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:35990 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2150996AbiHSN55 (ORCPT ); Fri, 19 Aug 2022 15:57:57 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Fri, 19 Aug 2022 15:57:55 +0200 From: Daniel Kiper To: Daniel Axtens Cc: grub-devel@gnu.org Subject: Re: [PATCH] Remove HFS support Message-ID: <20220819135755.vpfkmfyvysmdbzov@tomti.i.net-space.pl> References: <20220819133826.7456-1-dja@axtens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220819133826.7456-1-dja@axtens.net> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 13:58:03 -0000 On Fri, Aug 19, 2022 at 11:38:26PM +1000, Daniel Axtens wrote: > HFS is so so very old now. According to Wikipedia, HFS was > introduced in 1985 and the successor HFS+ came out in January > 1998. Mac OS dropped support for writing HFS in 2009 and dropped > support for reading HFS in 2019 with macOS 10.15. > > Grub's support for it doesn't survive contact with a fuzzer, and > the issues involve some horrible mess of mutual recursion that > would be time-consuming to sort out. > > HFS has been disabled under lockdown since commit 1c15848838d9 > ("fs/hfs: Disable under lockdown") which was part of an earlier > spin of security fixes. > > I think it's time to consign HFS to the dustbin of history. It's > firmly in the category of retrocomputing at this stage. > > This should not affect HFS+. > > There's a little bit of mess remaining: the macbless runtime > command and HFS+ need the HFS headers for embedded volume support. > I don't think that's really deployed any more, as it would have > been part of the HFS->HFS+ transition, but I'm not really game to > mess with either, in particular as macbless writes(!) to disk live. > (I'm fairly sure the grub-macbless tool invokes code from the > macbless module as well.) > > Signed-off-by: Daniel Axtens Reviewed-by: Daniel Kiper Daniel, thank you for preparing this patch! If I do not hear any major objections in the following weeks I will merge this patch or a variant of it in the second half of September. > --- > > `make check` is unchanged except for not running the hfs test any more. However, > I don't have any macs set up to boot linux with HFS+, so I can't say much more for > certain. If anyone can check grub-macbless in particular that would be wonderful. Yeah, that would be prefect. Any volunteers? Daniel