From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E6DAC00140 for ; Sun, 21 Aug 2022 12:17:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 577738410B; Sun, 21 Aug 2022 14:17:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bWXISe70"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2C32384118; Sun, 21 Aug 2022 14:17:37 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E89FF84109 for ; Sun, 21 Aug 2022 14:17:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id j6so6155801qkl.10 for ; Sun, 21 Aug 2022 05:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=BdIbysTe7U/SA16/MESmmX/uFc5yjwt8t+6bguH3xwQ=; b=bWXISe7035oHxE8k8Jbkw1SnsrltAaHi0yQTBR3deVU6E84ohhhTVSo0gd8wW/0bnX AKqItma/Bi+Toh/ssHOrq0o1xXgJlGTzTckw2CA/dKx5pBF/w7egUH9ZoxBDivebOOVc AEqamFJcTy3G0b4+2gzkkZ7iiTRotDEAn1QIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=BdIbysTe7U/SA16/MESmmX/uFc5yjwt8t+6bguH3xwQ=; b=3WgLLb0doeAi+BZ90aNtz25p6oNhpzQ2dB+cBLQ+Ibb2zzIHBn6kbkRlgFnyGZt3WY 2gGvO3WXvCJvvDYzS9RpsB1DQp1k1VIurYxozQIVmW/Yv6UKD9x42jYo2NC5589Kl7lJ yVZ7YftLdIb17S/J8koXQN1BgQtfBmsOv/u4noJSFEFxw1+OlYrD3NHkG50fChNDyHM1 z2Gbd+TNkA4NkTxbqpyBpcittLRWH5cJcszQFM+8vg2BpOW0E5BjWqR+8mAUg/FOwE4I mhHwCtKT9tC3efUwxVS2uKRQwyN4ZVKKOk73rU3C+B8LVctL/QY1A4pWqvkXaxwvHfqV +haA== X-Gm-Message-State: ACgBeo3Nw5el0FzAFXhQ4kdYSv8gdc0t7jPg9J2ePmKG746PPcWvsj9Y 2nwye5OTGCh4jKYnN3oGUsSlCw== X-Google-Smtp-Source: AA6agR4j51D4ZwKklidHwD9PPCpxwhrDu8KarVYQqZPAqgeHer0pUvPej3MA3WVG45VPj8v0041yzg== X-Received: by 2002:a05:620a:25ca:b0:6b8:7633:baf with SMTP id y10-20020a05620a25ca00b006b876330bafmr10533252qko.515.1661084252452; Sun, 21 Aug 2022 05:17:32 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id u4-20020a05620a454400b006bbe7ded98csm4996763qkp.112.2022.08.21.05.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Aug 2022 05:17:31 -0700 (PDT) Date: Sun, 21 Aug 2022 08:17:29 -0400 From: Tom Rini To: Simon Glass Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , U-Boot Mailing List Subject: Re: [PATCH 2/2] Makefile: Build final mpc85xx non-SPL image in standard file u-boot.bin Message-ID: <20220821121729.GR1146598@bill-the-cat> References: <20220801154220.20068-1-pali@kernel.org> <20220801154220.20068-2-pali@kernel.org> <20220801193900.zpbunhwopisefjjh@pali> <20220801231546.GY1146598@bill-the-cat> <20220803112801.6edejzme3lrsu77k@pali> <20220817210715.5w6hmzlm2d24jgcb@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/sjS7KIhTckiRu+4" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --/sjS7KIhTckiRu+4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 04:44:39PM -0600, Simon Glass wrote: > Hi, >=20 > On Wed, 17 Aug 2022 at 15:07, Pali Roh=E1r wrote: > > > > On Wednesday 03 August 2022 13:28:01 Pali Roh=E1r wrote: > > > On Monday 01 August 2022 19:15:46 Tom Rini wrote: > > > > On Mon, Aug 01, 2022 at 09:39:00PM +0200, Pali Roh=E1r wrote: > > > > > On Monday 01 August 2022 13:13:22 Simon Glass wrote: > > > > > > Hi Pali, > > > > > > > > > > > > On Mon, 1 Aug 2022 at 09:43, Pali Roh=E1r wro= te: > > > > > > > > > > > > > > Currently Makefile produces final mpc85xx image when SPL is n= ot used in > > > > > > > custom file u-boot-with-dtb.bin. It is quite confusing name a= s build > > > > > > > process produce also intermediate file standard file u-boot-d= tb.bin (which > > > > > > > is just intermediate and not bootable). Other platforms use u= -boot.bin > > > > > > > (UBOOT_BIN) as standard name for final bootable raw image. > > > > > > > > > > > > > > So change Makefile rules and binman to produce final bootable= file for > > > > > > > mpc85xx also into file u-boot.bin. There is just need for mpc= 85xx to not > > > > > > > define default rule for u-boot.bin then instruct binman (via = DTS file) to > > > > > > > store final image into u-boot.bin (instead of u-boot-with-dtb= =2Ebin) and > > > > > > > finally rename target u-boot-with-dtb.bin to u-boot.bin. > > > > > > > > > > > > > > With this change are also removed custom Makefile hacks for m= pc85xx that it > > > > > > > produced non-standard output file. And also updated documenta= tion. > > > > > > > > > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > > --- > > > > > > > Makefile | 19 +++++-------------- > > > > > > > arch/powerpc/dts/kmcent2-u-boot.dtsi | 2 +- > > > > > > > arch/powerpc/dts/u-boot.dtsi | 2 +- > > > > > > > board/freescale/p1_p2_rdb_pc/README | 2 +- > > > > > > > board/freescale/p2041rdb/README | 3 --- > > > > > > > board/freescale/t102xrdb/README | 2 +- > > > > > > > board/freescale/t104xrdb/README | 2 +- > > > > > > > board/freescale/t208xqds/README | 2 +- > > > > > > > board/freescale/t208xrdb/README | 2 +- > > > > > > > 9 files changed, 12 insertions(+), 24 deletions(-) > > > > > > > > > > > > At present u-boot.bin has a very standard meaning - it is U-Boo= t with the DT. > > > > > > > > > > > > Boards which need something more than that can/should use binma= n to > > > > > > create a separate file. > > > > > > > > > > > > I certainly agree that u-boot-with-dtb.bin is a terrible name, = though. > > > > > > Something more descriptive would be better. > > > > > > > > > > > > But is it possible to drop these SoC-specific rules in the Make= file > > > > > > and just build everything needed in the standard binman rule in= the > > > > > > Makefile? > > > > > > > > > > > > Regards, > > > > > > Simon > > > > > > > > > > I do not know what is binman doing and how to use it. I just do n= ot see > > > > > reason why it is needed to use such additional tool for building = final > > > > > binary for powerpc/mpc85xx as other arm boards do not use it at a= ll. > > > > > > > > > > Ad your comment "At present u-boot.bin has a very standard meanin= g - it > > > > > is U-Boot with the DT." - This is exactly what binman for mpc85xx > > > > > produces. > > > > > > > > > > So I see there could be improvements, but as a first step this my= patch > > > > > should be enough? > > > > > > > > So, one of the issues with PowerPC stuff is that much of it is so f= ar > > > > behind the rest of U-Boot in terms of frameworks. So yes, let us s= tart > > > > by fixing the functional problem you're describing here and then see > > > > what appetite exists for further work here. > > > > > > > > -- > > > > Tom > > > > > > Ok, so these two patches in this patch series is a starting point. > > > > > > Now I send another patch which does another cleanup in this area: > > > https://patchwork.ozlabs.org/project/uboot/patch/20220803112442.4735-= 1-pali@kernel.org/ > > > > PING? >=20 > I'm not sure what to say here and will leave it to Tom. And I'm assuming that Marek will pick this up, along with all of your other outstanding PowerPC patches that are essentially related to making the original turris platform work. --=20 Tom --/sjS7KIhTckiRu+4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMCIlYACgkQFHw5/5Y0 tyzzoAwAhhaweV09BFy5DCXpA8CAkXVFyZjx0lJP0XrPUufGFMrpJkKXrt0D7E3W agJ+mBBtwOFhWkQCsuud3I8s9RY3zbwpXPVlMZv87r0iYpt0ayEc05dYOJksgp+R Y9BBUux8kaWkNMMhZet3ZWro0qJnNhAWMr89HOOumh1YaW8Y32er2pIK9WUcFct7 UVSBStJnXbFYaXZ5Vn3U+WcM38z7VfQ/DiOoSsCiMJ21Lw4mcUyPFfjrE7Z/vzA6 qB5WGTgkGRGJrfmSi3TaSf6PVD5uNChek0tI7uGkurD++lhEAbfyXWYnv2/PXk4J OeZhdRVY/iRGue2jox1hdgWa37g+Z774aDPCZLLI8P1UNhZGak+nb+uQHYWIZJiR 33X3R5Gs4z1X4OxCGs3kEmrQqC7H2A17qXReYh5wSJbsxHsJfqYbWRqB5Ua0kIre YqNn6X5ASb3BA7OlD55Q2xWetjOu9RCp/GzDuqSo5K+wkbNYm3AOXXRgxwmM64pu nvcK+P3K =yVuL -----END PGP SIGNATURE----- --/sjS7KIhTckiRu+4--